On 2019.04.09 00:23, Christian Couder wrote: > On Mon, Apr 8, 2019 at 11:46 PM Josh Steadmon <stead...@google.com> wrote: > > > > Helped-By: Jonathan Tan <jonathanta...@google.com> > > Helped-By: Jeff King <p...@peff.net> > > Helped-By: Jonathan Nieder <jrnie...@gmail.com> > > Signed-off-by: Josh Steadmon <stead...@google.com> > > > > Signed-off-by: Josh Steadmon <stead...@google.com> > > Your S-o-B is duplicated an there is a spurious line between the > duplicated lines. Do you use an automated script/hook to add your > S-o-B?
I only use the --signoff flag to git-format-patch. It looks like the cause is that I have a hook to add a Gerrit Change-Id to my commit messages, and that hook added a blank line followed by Change-Id:blah after my original Signed-off-by line. Then git-format-patch added another Signed-off-by after the Change-Id. The Change-Id line was then stripped out by a wrapper around git-send-email.
