Hi Junio,
On Tue, 13 Jun 2017, Junio C Hamano wrote:
> Jeff King writes:
>
> > On Tue, Jun 13, 2017 at 01:42:02PM +0200, Johannes Schindelin wrote:
> >
> >> > As you probably guessed, I had tried that first and then figured that if
> >> > I needed to keep the config_key_is_valid() test anyway,
On Tue, Jun 13, 2017 at 09:40:49AM -0700, Junio C Hamano wrote:
> >> It is really tempting to avoid the extra strbuf, but then the error
> >> message would change from
> >>
> >>error: missing value for 'alias.br'
> >>
> >> to
> >>
> >>error: missing value for 'br'
> >>
> >> which is of
Jeff King writes:
> On Tue, Jun 13, 2017 at 01:42:02PM +0200, Johannes Schindelin wrote:
>
>> > As you probably guessed, I had tried that first and then figured that if
>> > I needed to keep the config_key_is_valid() test anyway, I could just as
>> > well keep the strbuf around for later use.
>>
On Tue, Jun 13, 2017 at 01:42:02PM +0200, Johannes Schindelin wrote:
> > As you probably guessed, I had tried that first and then figured that if
> > I needed to keep the config_key_is_valid() test anyway, I could just as
> > well keep the strbuf around for later use.
> >
> > Will change the code
Hi Peff,
On Tue, 13 Jun 2017, Johannes Schindelin wrote:
> On Sat, 10 Jun 2017, Jeff King wrote:
>
> > On Thu, Jun 08, 2017 at 09:53:50PM +0200, Johannes Schindelin wrote:
> >
> > > -char *alias_lookup(const char *alias)
> > > [...]
> > > {
> > > - char *v = NULL;
> > > - struct strbuf key = S
On Tue, Jun 13, 2017 at 01:21:28PM +0200, Johannes Schindelin wrote:
> > Two optional cleanups here:
> >
> > 1. We don't need to call config_key_is_valid when using a callback. We
> > only needed that to prevent the configset machinery from issuing a
> > warning. It does save us readi
Hi Peff,
On Sat, 10 Jun 2017, Jeff King wrote:
> On Thu, Jun 08, 2017 at 09:53:50PM +0200, Johannes Schindelin wrote:
>
> > -char *alias_lookup(const char *alias)
> > [...]
> > {
> > - char *v = NULL;
> > - struct strbuf key = STRBUF_INIT;
> > - strbuf_addf(&key, "alias.%s", alias);
> > -
On Thu, Jun 08, 2017 at 09:53:50PM +0200, Johannes Schindelin wrote:
> -char *alias_lookup(const char *alias)
> [...]
> {
> - char *v = NULL;
> - struct strbuf key = STRBUF_INIT;
> - strbuf_addf(&key, "alias.%s", alias);
> - if (git_config_key_is_valid(key.buf))
> - gi
When an alias expands to a shell command, and when we are inside a
regular worktree's subdirectory (i.e. not inside the .git/ directory nor
in a worktree initialized via `git worktree add`), and only then, the
current working directory is switched to the top-level directory of the
worktree before r
9 matches
Mail list logo
