On Tue, Jun 13, 2017 at 01:21:28PM +0200, Johannes Schindelin wrote: > > Two optional cleanups here: > > > > 1. We don't need to call config_key_is_valid when using a callback. We > > only needed that to prevent the configset machinery from issuing a > > warning. It does save us reading the config entirely when the > > program name is syntactically invalid as an alias, but that's a > > pretty rare case. > > It may be a pretty rare case, or it may not be. I do not want to think > hard about this, so I just wanted to keep that test. > > But since you suggested it, I will simply blame all the fallout (if any) > on you. > > ;-)
I accept all the blame. :) (And I was the person who added the is_valid check here, so I can take both blame and credit for the whole thing). -Peff
