Re: [PATCH v2 1/1] t0001: fix on case-insensitive filesystems

2019-06-24 Thread Junio C Hamano
Johannes Schindelin writes: > The other path category is the paths in the index, which _are_ > case-sensitive, no matter what core.ignoreCase says. > > So I'd rather keep the `fs`. Sensible. Thanks.

Re: [PATCH v2 1/1] t0001: fix on case-insensitive filesystems

2019-06-24 Thread Johannes Schindelin
Hi Junio, On Mon, 24 Jun 2019, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> I wonder if we want (possibly local) test_cmp_fspath that can be > >> used more like > >> > >>test_cmp_fspath "$(pwd)/realgitdir" "$(sed -e "s/^gitdir: //" > >> newdir/.git)" > >> > >> to compare two p

Re: [PATCH v2 1/1] t0001: fix on case-insensitive filesystems

2019-06-24 Thread Junio C Hamano
Johannes Schindelin writes: >> I wonder if we want (possibly local) test_cmp_fspath that can be >> used more like >> >> test_cmp_fspath "$(pwd)/realgitdir" "$(sed -e "s/^gitdir: //" >> newdir/.git)" >> >> to compare two paths, honoring the case sensitivity of the >> filesystem. > > I agree

Re: [PATCH v2 1/1] t0001: fix on case-insensitive filesystems

2019-06-24 Thread Johannes Schindelin
Hi Junio, On Fri, 21 Jun 2019, Junio C Hamano wrote: > Johannes Schindelin writes: > > > [Re-sending, as the Git mailing list seems to have decided to silently > > drop this patch, I cannot see it on public-inbox.org, at least] > > Move that below the three-dash lines; otherwise the above two li

Re: [PATCH v2 1/1] t0001: fix on case-insensitive filesystems

2019-06-21 Thread Junio C Hamano
Johannes Schindelin writes: > [Re-sending, as the Git mailing list seems to have decided to silently > drop this patch, I cannot see it on public-inbox.org, at least] Move that below the three-dash lines; otherwise the above two lines will make your in-body From: ineffective. > > From: Johannes

Re: [PATCH v2 1/1] t0001: fix on case-insensitive filesystems

2019-06-21 Thread Johannes Schindelin
[Re-sending, as the Git mailing list seems to have decided to silently drop this patch, I cannot see it on public-inbox.org, at least] From: Johannes Schindelin On a case-insensitive filesystem, such as HFS+ or NTFS, it is possible that the idea Bash has of the current directory differs in case