Hi Junio, On Mon, 24 Jun 2019, Junio C Hamano wrote:
> Johannes Schindelin <johannes.schinde...@gmx.de> writes: > > >> I wonder if we want (possibly local) test_cmp_fspath that can be > >> used more like > >> > >> test_cmp_fspath "$(pwd)/realgitdir" "$(sed -e "s/^gitdir: //" > >> newdir/.git)" > >> > >> to compare two paths, honoring the case sensitivity of the > >> filesystem. > > > > I agree that that's a much better approach to fix the issue. > > I find that response somewhat surprising :-|. In any case, I am not > sure what kind of 'path' other than the filesystem one we would deal > with in the context of Git and its test suite, so perhaps we should > drop 'fs' from the name of the helper function if we were to go that > route. The other path category is the paths in the index, which _are_ case-sensitive, no matter what core.ignoreCase says. So I'd rather keep the `fs`. Ciao, Dscho
