Re: [PATCH v2 0/3] format-patch: introduce option to suppress commit hashes

2015-12-14 Thread brian m. carlson
On Mon, Dec 14, 2015 at 04:32:39PM -0500, Jeff King wrote: > The intent here makes sense to me, and with the exception of the > test_line_count thing that Torsten mentioned, the code looks good. > > I briefly wondered if the option should simply be "--diffable" or > something like that, and trigge

Re: [PATCH v2 0/3] format-patch: introduce option to suppress commit hashes

2015-12-14 Thread Jeff King
On Sun, Dec 13, 2015 at 05:27:15PM +, brian m. carlson wrote: > git format-patch is often used to create patches that are then stored in > version control or displayed with diff. Having the commit hash in the > "From " line usually just creates diff noise in these cases, so this > series intr

[PATCH v2 0/3] format-patch: introduce option to suppress commit hashes

2015-12-13 Thread brian m. carlson
git format-patch is often used to create patches that are then stored in version control or displayed with diff. Having the commit hash in the "From " line usually just creates diff noise in these cases, so this series introduces --zero-commit to set that to all zeros. Changes from v1: * Rename t