On Sun, Dec 13, 2015 at 05:27:15PM +0000, brian m. carlson wrote: > git format-patch is often used to create patches that are then stored in > version control or displayed with diff. Having the commit hash in the > "From " line usually just creates diff noise in these cases, so this > series introduces --zero-commit to set that to all zeros. > > Changes from v1: > * Rename the option --zero-commit. > * Improve the tests to look for a 40-hex hash value in "From " header. > > brian m. carlson (3): > Introduce a null_oid constant. > format-patch: add an option to suppress commit hash > format-patch: check that header line has expected format
The intent here makes sense to me, and with the exception of the test_line_count thing that Torsten mentioned, the code looks good. I briefly wondered if the option should simply be "--diffable" or something like that, and trigger this new behavior as well as implying --no-signature. Along with any other relevant options (if any; I don't recall if --stat-width is terminal-dependent for format-patch, for example). But that is probably overkill. People can flip those switches individually if they want to (and even if somebody did want "--diffable", it may make sense to build it on top, so they can flip the zero-commit thing individually if they want). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
