On Wed, Dec 6, 2017 at 5:55 PM, Nathan PAYRE wrote:
> Junio C Hamano : writes:
>> Also "reusable in other place" is by itself not an unconditional
>> plus, until readers can be convinced that that 'other place' really
>> wants to be able to call this function. Is there some untold
>> motivation b
Nathan PAYRE writes:
> Junio C Hamano : writes:
>
>> ... throughout this patch, not limited to this section, indentation
>> is strange and there seem to be many "print" that show messages that
>> do not seem to be meant for end-user consumption. I can see that
>> this aspires to improve the read
Junio C Hamano : writes:
> ... throughout this patch, not limited to this section, indentation
> is strange and there seem to be many "print" that show messages that
> do not seem to be meant for end-user consumption. I can see that
> this aspires to improve the readability, but not quite yet ;-)
Nathan Payre writes:
> The existing code mixes parsing of email header with regular
> expression and actual code. Extract the parsing code into a new
> subroutine 'parse_header_line()'. This improves the code readability
> and make parse_header_line reusable in other place.
>
> Signed-off-by: Na
The existing code mixes parsing of email header with regular
expression and actual code. Extract the parsing code into a new
subroutine 'parse_header_line()'. This improves the code readability
and make parse_header_line reusable in other place.
Signed-off-by: Nathan Payre
Signed-off-by: Matthieu
The existing code mixes parsing of email header with regular
expression and actual code. Extract the parsing code into a new
subroutine 'parse_header_line()'. This improves the code readability
and make parse_header_line reusable in other place.
Signed-off-by: Nathan Payre
Signed-off-by: Matthieu
6 matches
Mail list logo
