Re: [PATCH v2] am: add am.signoff add config variable

2016-12-29 Thread Eduardo Habkost
On Thu, Dec 29, 2016 at 01:29:33PM +0530, Pranit Bauva wrote: > Hey Eduardo, > > On Thu, Dec 29, 2016 at 12:49 AM, Eduardo Habkost wrote: > >> test_expect_success '--no-signoff overrides am.signoff' ' > >> rm -fr .git/rebase-apply && > >> git reset --hard first && > >> test_conf

Re: [PATCH v2] am: add am.signoff add config variable

2016-12-29 Thread Pranit Bauva
Hey Eduardo, On Thu, Dec 29, 2016 at 12:49 AM, Eduardo Habkost wrote: >> test_expect_success '--no-signoff overrides am.signoff' ' >> rm -fr .git/rebase-apply && >> git reset --hard first && >> test_config am.signoff true && >> git am --no-signoff > printf "%s\n" "$s

Re: [PATCH v2] am: add am.signoff add config variable

2016-12-28 Thread Stefan Beller
On Wed, Dec 28, 2016 at 11:19 AM, Eduardo Habkost wrote: > On Wed, Dec 28, 2016 at 05:11:42PM -0200, Eduardo Habkost wrote: >> On Wed, Dec 28, 2016 at 10:51:28AM -0800, Stefan Beller wrote: >> > On Wed, Dec 28, 2016 at 10:35 AM, Eduardo Habkost >> > wrote: > [...] >> > > + test $(git cat-f

Re: [PATCH v2] am: add am.signoff add config variable

2016-12-28 Thread Eduardo Habkost
On Wed, Dec 28, 2016 at 05:11:42PM -0200, Eduardo Habkost wrote: > On Wed, Dec 28, 2016 at 10:51:28AM -0800, Stefan Beller wrote: > > On Wed, Dec 28, 2016 at 10:35 AM, Eduardo Habkost > > wrote: [...] > > > + test $(git cat-file commit HEAD | grep -c "Signed-off-by:") -eq 0 > > > > and the

Re: [PATCH v2] am: add am.signoff add config variable

2016-12-28 Thread Eduardo Habkost
On Wed, Dec 28, 2016 at 08:07:54PM +0100, Andreas Schwab wrote: > On Dez 28 2016, Eduardo Habkost wrote: > > > diff --git a/Documentation/git-am.txt b/Documentation/git-am.txt > > index 12879e402..f22f10d40 100644 > > --- a/Documentation/git-am.txt > > +++ b/Documentation/git-am.txt > > @@ -9,7 +

Re: [PATCH v2] am: add am.signoff add config variable

2016-12-28 Thread Eduardo Habkost
On Wed, Dec 28, 2016 at 10:51:28AM -0800, Stefan Beller wrote: > On Wed, Dec 28, 2016 at 10:35 AM, Eduardo Habkost wrote: > > git-am has options to enable --message-id and --3way by default, > > but no option to enable --signoff by default. Add a "am.signoff" > > config option. > > > > Signed-off-

Re: [PATCH v2] am: add am.signoff add config variable

2016-12-28 Thread Andreas Schwab
On Dez 28 2016, Eduardo Habkost wrote: > diff --git a/Documentation/git-am.txt b/Documentation/git-am.txt > index 12879e402..f22f10d40 100644 > --- a/Documentation/git-am.txt > +++ b/Documentation/git-am.txt > @@ -9,7 +9,7 @@ git-am - Apply a series of patches from a mailbox > SYNOPSIS > --

Re: [PATCH v2] am: add am.signoff add config variable

2016-12-28 Thread Stefan Beller
On Wed, Dec 28, 2016 at 10:35 AM, Eduardo Habkost wrote: > git-am has options to enable --message-id and --3way by default, > but no option to enable --signoff by default. Add a "am.signoff" > config option. > > Signed-off-by: Eduardo Habkost > --- > Changes v1 -> v2: > * Added documentation to D

[PATCH v2] am: add am.signoff add config variable

2016-12-28 Thread Eduardo Habkost
git-am has options to enable --message-id and --3way by default, but no option to enable --signoff by default. Add a "am.signoff" config option. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Added documentation to Documentation/git-am.txt and Documentation/config.txt * Added test cases