Hey Eduardo, On Thu, Dec 29, 2016 at 12:49 AM, Eduardo Habkost <ehabk...@redhat.com> wrote: >> test_expect_success '--no-signoff overrides am.signoff' ' >> rm -fr .git/rebase-apply && >> git reset --hard first && >> test_config am.signoff true && >> git am --no-signoff <patch2 && >> printf "%s\n" "$signoff" >expected && >> git cat-file commit HEAD^ | grep "Signed-off-by:" >actual && >> test_cmp expected actual && >> git cat-file commit HEAD | grep "Signed-off-by:" >actual && >> test_must_be_empty actual >> ' >> >> The test fails because the second "grep" command returns a >> non-zero exit code. Any suggestions to avoid that problem in a >> more idiomatic way? > > I just found out that "test_must_fail grep ..." is a common > idiom, so what about:
Is there any particular reason to use "grep" instead of "test_cmp"? To check for non-zero error code, you can always use "! test_cmp". Regards, Pranit Bauva
