Re: [PATCH v13 2/6] test-parse-options: print quiet as integer

2016-04-12 Thread Junio C Hamano
Pranit Bauva writes: > On Wed, Apr 13, 2016 at 3:03 AM, Junio C Hamano wrote: >> Pranit Bauva writes: >> >>> Current implementation of parse-options.c treats OPT__QUIET() as integer >>> and not boolean and thus it is more appropriate to print it as integer >>> to avoid confusion. >> >> There is

Re: [PATCH v13 2/6] test-parse-options: print quiet as integer

2016-04-12 Thread Pranit Bauva
On Wed, Apr 13, 2016 at 3:03 AM, Junio C Hamano wrote: > Pranit Bauva writes: > >> Current implementation of parse-options.c treats OPT__QUIET() as integer >> and not boolean and thus it is more appropriate to print it as integer >> to avoid confusion. > > There is no "confusion" factor involved,

Re: [PATCH v13 2/6] test-parse-options: print quiet as integer

2016-04-12 Thread Junio C Hamano
Pranit Bauva writes: > Current implementation of parse-options.c treats OPT__QUIET() as integer > and not boolean and thus it is more appropriate to print it as integer > to avoid confusion. There is no "confusion" factor involved, as we do not use native "boolean" type in our C code. IIUC, the

[PATCH v13 2/6] test-parse-options: print quiet as integer

2016-04-09 Thread Pranit Bauva
Current implementation of parse-options.c treats OPT__QUIET() as integer and not boolean and thus it is more appropriate to print it as integer to avoid confusion. Signed-off-by: Pranit Bauva --- t/t0040-parse-options.sh | 26 +- test-parse-options.c | 2 +- 2 files