Re: [PATCH v13 00/27] Convert "git stash" to C builtin

2019-03-03 Thread Thomas Gummerer
On 03/03, Junio C Hamano wrote: > Thomas Gummerer writes: > > > As I was advocating for this series to go into 'next' without a large > > refactor of this series, I'll put my money were my mouth is and try to > > make the cleanups and fixes required, though without trying to avoid > > further ext

Re: [PATCH v13 00/27] Convert "git stash" to C builtin

2019-03-02 Thread Junio C Hamano
Thomas Gummerer writes: > As I was advocating for this series to go into 'next' without a large > refactor of this series, I'll put my money were my mouth is and try to > make the cleanups and fixes required, though without trying to avoid > further external process calls, or changing the series

Re: [PATCH v13 00/27] Convert "git stash" to C builtin

2019-03-02 Thread Junio C Hamano
Thomas Gummerer writes: > One thing that came up in the latest reviews, was to keep the stash > script intact throughout the series, and to not re-introduce it after > deleting it. I did however not do that, as that would make the > range-diff quite a bit harder to read. Of course, if you start

Re: [PATCH v13 00/27] Convert "git stash" to C builtin

2019-02-26 Thread Johannes Schindelin
Hi Ævar, On Tue, 26 Feb 2019, Ævar Arnfjörð Bjarmason wrote: > > On Tue, Feb 26 2019, Thomas Gummerer wrote: > > > As I was advocating for this series to go into 'next' without a large > > refactor of this series, I'll put my money were my mouth is and try to > > make the cleanups and fixes req

Re: [PATCH v13 00/27] Convert "git stash" to C builtin

2019-02-26 Thread Ævar Arnfjörð Bjarmason
On Tue, Feb 26 2019, Thomas Gummerer wrote: > As I was advocating for this series to go into 'next' without a large > refactor of this series, I'll put my money were my mouth is and try to > make the cleanups and fixes required, though without trying to avoid > further external process calls, or

Re: [PATCH v13 00/27] Convert "git stash" to C builtin

2019-02-26 Thread Thomas Gummerer
On 02/26, Johannes Schindelin wrote: > Hi Thomas, > > On Mon, 25 Feb 2019, Thomas Gummerer wrote: > > 22: 51809c70ca ! 23: 56a5ce2aeb stash: convert `stash--helper.c` into > > `stash.c` > > @@ -13,7 +13,7 @@ > > called directly and not by a shell script. > > > > Sign

Re: [PATCH v13 00/27] Convert "git stash" to C builtin

2019-02-26 Thread Johannes Schindelin
Hi Thomas, On Mon, 25 Feb 2019, Thomas Gummerer wrote: > As I was advocating for this series to go into 'next' without a large > refactor of this series, I'll put my money were my mouth is and try to > make the cleanups and fixes required, though without trying to avoid > further external process

[PATCH v13 00/27] Convert "git stash" to C builtin

2019-02-25 Thread Thomas Gummerer
As I was advocating for this series to go into 'next' without a large refactor of this series, I'll put my money were my mouth is and try to make the cleanups and fixes required, though without trying to avoid further external process calls, or changing the series around too much. One thing to con