Re: [PATCH 4/4] range-diff: indent special lines as context

2018-08-16 Thread Johannes Schindelin
Hi Stefan, On Tue, 14 Aug 2018, Stefan Beller wrote: > On Tue, Aug 14, 2018 at 11:54 AM Johannes Schindelin > wrote: > > > > On Mon, 13 Aug 2018, Stefan Beller wrote: > > > > > > > The later lines that indicate a change to the Makefile will be > > > > > treated as context both in the outer and i

Re: [PATCH 4/4] range-diff: indent special lines as context

2018-08-14 Thread Stefan Beller
On Tue, Aug 14, 2018 at 11:54 AM Johannes Schindelin wrote: > > Hi Stefan, > > On Mon, 13 Aug 2018, Stefan Beller wrote: > > > > > The later lines that indicate a change to the Makefile will be treated > > > > as > > > > context both in the outer and inner diff, such that those lines stay > > > >

Re: [PATCH 4/4] range-diff: indent special lines as context

2018-08-14 Thread Johannes Schindelin
Hi Stefan, On Mon, 13 Aug 2018, Stefan Beller wrote: > > > The later lines that indicate a change to the Makefile will be treated as > > > context both in the outer and inner diff, such that those lines stay > > > regular color. > > > > While I am a fan of having those lines colored correctly, I

Re: [PATCH 4/4] range-diff: indent special lines as context

2018-08-13 Thread Stefan Beller
> > The later lines that indicate a change to the Makefile will be treated as > > context both in the outer and inner diff, such that those lines stay > > regular color. > > While I am a fan of having those lines colored correctly, I have to admit > that I am not exactly enthusiastic about that ext

Re: [PATCH 4/4] range-diff: indent special lines as context

2018-08-13 Thread Johannes Schindelin
Hi Stefan, On Fri, 10 Aug 2018, Stefan Beller wrote: > The range-diff coloring is a bit fuzzy when it comes to special lines of > a diff, such as indicating new and old files with +++ and ---, as it > would pickup the first character and interpret it for its coloring, which > seems annoying as in

[PATCH 4/4] range-diff: indent special lines as context

2018-08-10 Thread Stefan Beller
The range-diff coloring is a bit fuzzy when it comes to special lines of a diff, such as indicating new and old files with +++ and ---, as it would pickup the first character and interpret it for its coloring, which seems annoying as in regular diffs, these lines are colored bold via DIFF_METAINFO.