Re: [PATCH 2/2] show color hints based on state of the git tree

2012-10-15 Thread Junio C Hamano
Simon Oosthoek writes: > The point of the thread and the patch was to enable the possibility of > colors in the prompt without messing it up. > > The actual colors used are more or less how I'm used to it, but as you > said they may not be suitable to everyone. > > @Junio, is this patch something

Re: [PATCH 2/2] show color hints based on state of the git tree

2012-10-15 Thread Michael J Gruber
Simon Oosthoek venit, vidit, dixit 15.10.2012 15:20: > Hi Michael, sorry for the duplicate, forgot to reply-all... > > On 10/15/2012 11:13 AM, Michael J Gruber wrote: > >> ...only because you don't know the color coding scheme. It's green >> because those changes are saved somewhere (in the index

Re: [PATCH 2/2] show color hints based on state of the git tree

2012-10-15 Thread Simon Oosthoek
On 10/15/2012 11:39 AM, Junio C Hamano wrote: Thanks for bringing some sanity to the color of the bikeshed ;-) As I don't use colors very much, I didn't bother checking the color assignment in the patch in question, but everything you said in your response makes 100% sense, including the traffic

Re: [PATCH 2/2] show color hints based on state of the git tree

2012-10-15 Thread Simon Oosthoek
Hi Michael, sorry for the duplicate, forgot to reply-all... On 10/15/2012 11:13 AM, Michael J Gruber wrote: ...only because you don't know the color coding scheme. It's green because those changes are saved somewhere (in the index) and would even survice a branch switch. But git doesn't exac

Re: [PATCH 2/2] show color hints based on state of the git tree

2012-10-15 Thread Simon Oosthoek
On 10/15/2012 11:13 AM, Michael J Gruber wrote: It really doesn't matter much what works for you, and it doesn't matter what works for me either. The point is: What works for most users? Obviously, that was my point as well ;-) I'm quite unfamiliar with the color coding of git (I hadn't enab

Re: [PATCH 2/2] show color hints based on state of the git tree

2012-10-15 Thread Michael J Gruber
Simon Oosthoek venit, vidit, dixit 15.10.2012 11:01: > On 10/15/2012 10:23 AM, Michael J Gruber wrote: >> Sorry for being late ($DAYJOB and such), but I just noticed this is on >> next already: >> >>> + if [ -n "${GIT_PS1_SHOWCOLORHINT-}" ]; then >> >> You're missing the "S" here

Re: [PATCH 2/2] show color hints based on state of the git tree

2012-10-15 Thread Simon Oosthoek
On 10/15/2012 10:23 AM, Michael J Gruber wrote: Sorry for being late ($DAYJOB and such), but I just noticed this is on next already: + if [ -n "${GIT_PS1_SHOWCOLORHINT-}" ]; then You're missing the "S" here (HINTS). indeed, well spotted! My test setup was apparently co

Re: [PATCH 2/2] show color hints based on state of the git tree

2012-10-15 Thread Michael J Gruber
Sorry for being late ($DAYJOB and such), but I just noticed this is on next already: Simon Oosthoek venit, vidit, dixit 05.10.2012 23:10: > By setting GIT_PS1_SHOW_COLORHINTS when using __git_ps1 > as PROMPT_COMMAND, you will get color hints in addition to > a different character (*+% etc.) > > S

[PATCH 2/2] show color hints based on state of the git tree

2012-10-10 Thread Simon Oosthoek
By setting GIT_PS1_SHOW_COLORHINTS when using __git_ps1 as PROMPT_COMMAND, you will get color hints in addition to a different character (*+% etc.) to indicate the state of the tree. Signed-off-by: Simon Oosthoek --- contrib/completion/git-prompt.sh | 36 +++- 1

[PATCH 2/2] show color hints based on state of the git tree

2012-10-10 Thread Simon Oosthoek
By setting GIT_PS1_SHOW_COLORHINTS when using __git_ps1 as PROMPT_COMMAND, you will get color hints in addition to a different character (*+% etc.) to indicate the state of the tree. Signed-off-by: Simon Oosthoek --- contrib/completion/git-prompt.sh | 36 +++- 1

[PATCH 2/2] show color hints based on state of the git tree

2012-10-05 Thread Simon Oosthoek
By setting GIT_PS1_SHOW_COLORHINTS when using __git_ps1 as PROMPT_COMMAND, you will get color hints in addition to a different character (*+% etc.) Signed-off-by: Simon Oosthoek --- contrib/completion/git-prompt.sh | 42 +++--- 1 file changed, 39 insertions(+),