On 08/29/2013 11:24 PM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> Matthieu Moy writes:
>>
>>> Do I really need to quote the paragraph in CodingGuidelines?
>>
>> Existing violations are not an excuse to make things worse by adding
>> more. I think with these comments we can expect a re
On 08/29/2013 11:25 PM, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> Actually, I think not fixing it inside that 1/8 is good, as there
>> are many existing "cmd > file" (and worse, "cmd > file-$x") in these
>> test-*.sh scripts. Clean-up is better done as a follow-up patch.
>>
>> Here are
Junio C Hamano writes:
>> May I ask what pattern you used to replace all these or if you went
>> through manually ?
>
> "M-x query-replace" from "> " to ">" with manual inspection. I never
> use full automation myself, as I do not trust that I am careful
> enough and it is prone to unexpected cha
Antoine Pelisse writes:
> On Thu, Aug 29, 2013 at 11:24 PM, Junio C Hamano wrote:
>> -- >8 --
>> Subject: [PATCH 9/8] contrib/remote-helpers: style updates for test scripts
>>
>> During the review of the main series it was noticed that these test
>> scripts can use updates to conform to our codi
On Thu, Aug 29, 2013 at 11:24 PM, Junio C Hamano wrote:
> -- >8 --
> Subject: [PATCH 9/8] contrib/remote-helpers: style updates for test scripts
>
> During the review of the main series it was noticed that these test
> scripts can use updates to conform to our coding style better, but
> fixing the
Junio C Hamano writes:
> Actually, I think not fixing it inside that 1/8 is good, as there
> are many existing "cmd > file" (and worse, "cmd > file-$x") in these
> test-*.sh scripts. Clean-up is better done as a follow-up patch.
>
> Here are two that I noticed.
>
> -- >8 --
> Subject: [PATCH 9/8
Junio C Hamano writes:
> Matthieu Moy writes:
>
>> Do I really need to quote the paragraph in CodingGuidelines?
>
> Existing violations are not an excuse to make things worse by adding
> more. I think with these comments we can expect a reroll coming,
> and it should be trivial for any contribu
On Wed, Aug 28, 2013 at 4:58 PM, Junio C Hamano wrote:
> Matthieu Moy writes:
>
>> Felipe Contreras writes:
>>
>>> On Wed, Aug 28, 2013 at 3:05 PM, Matthieu Moy
>>> wrote:
>>>
> + bzr log | grep "^committer: " > ../actual
> + ) &&
> +
> + echo "committer: Grégoire "
Matthieu Moy writes:
> Felipe Contreras writes:
>
>> On Wed, Aug 28, 2013 at 3:05 PM, Matthieu Moy
>> wrote:
>>
+ bzr log | grep "^committer: " > ../actual
+ ) &&
+
+ echo "committer: Grégoire " > expected &&
>>>
>>> Git's source code usually says >../actual and
On Wed, Aug 28, 2013 at 4:21 PM, Felipe Contreras
wrote:
> On Wed, Aug 28, 2013 at 3:54 PM, Antoine Pelisse wrote:
>> On Wed, Aug 28, 2013 at 10:48 PM, Felipe Contreras
>> wrote:
>>> On Wed, Aug 28, 2013 at 3:05 PM, Matthieu Moy
>>> wrote:
Felipe Contreras writes:
> + echo gr
On Wed, Aug 28, 2013 at 4:05 PM, Matthieu Moy
wrote:
> Felipe Contreras writes:
>
>> On Wed, Aug 28, 2013 at 3:05 PM, Matthieu Moy
>> wrote:
>>
+ bzr log | grep "^committer: " > ../actual
+ ) &&
+
+ echo "committer: Grégoire " > expected &&
>>>
>>> Git's source co
On Wed, Aug 28, 2013 at 3:54 PM, Antoine Pelisse wrote:
> On Wed, Aug 28, 2013 at 10:48 PM, Felipe Contreras
> wrote:
>> On Wed, Aug 28, 2013 at 3:05 PM, Matthieu Moy
>> wrote:
>>> Felipe Contreras writes:
>>>
+ echo greg >> content &&
+ git add content &&
+ git commi
Felipe Contreras writes:
> On Wed, Aug 28, 2013 at 3:05 PM, Matthieu Moy
> wrote:
>
>>> + bzr log | grep "^committer: " > ../actual
>>> + ) &&
>>> +
>>> + echo "committer: Grégoire " > expected &&
>>
>> Git's source code usually says >../actual and >expected, without space
>> after '
On Wed, Aug 28, 2013 at 10:48 PM, Felipe Contreras
wrote:
> On Wed, Aug 28, 2013 at 3:05 PM, Matthieu Moy
> wrote:
>> Felipe Contreras writes:
>>
>>> + echo greg >> content &&
>>> + git add content &&
>>> + git commit -m one
>>
>> test_commit would make it shorter.
>
> And it would m
On Wed, Aug 28, 2013 at 3:05 PM, Matthieu Moy
wrote:
> Felipe Contreras writes:
>
>> + echo greg >> content &&
>> + git add content &&
>> + git commit -m one
>
> test_commit would make it shorter.
And it would make it inconsistent with the rest of the script.
>> + bzr log | grep
On Wed, Aug 28, 2013 at 3:23 PM, Felipe Contreras
wrote:
> Reported-by: Joakim Verona
> Signed-off-by: Felipe Contreras
> ---
> contrib/remote-helpers/git-remote-bzr | 1 +
> contrib/remote-helpers/test-bzr.sh| 30 ++
> 2 files changed, 31 insertions(+)
>
> diff
Felipe Contreras writes:
> + echo greg >> content &&
> + git add content &&
> + git commit -m one
test_commit would make it shorter.
> + bzr log | grep "^committer: " > ../actual
> + ) &&
> +
> + echo "committer: Grégoire " > expected &&
Git's source code usually says >
Reported-by: Joakim Verona
Signed-off-by: Felipe Contreras
---
contrib/remote-helpers/git-remote-bzr | 1 +
contrib/remote-helpers/test-bzr.sh| 30 ++
2 files changed, 31 insertions(+)
diff --git a/contrib/remote-helpers/git-remote-bzr
b/contrib/remote-helpers/
18 matches
Mail list logo
