On 08/29/2013 11:25 PM, Junio C Hamano wrote: > Junio C Hamano <gits...@pobox.com> writes: > >> Actually, I think not fixing it inside that 1/8 is good, as there >> are many existing "cmd > file" (and worse, "cmd > file-$x") in these >> test-*.sh scripts. Clean-up is better done as a follow-up patch. >> >> Here are two that I noticed. >> >> -- >8 -- >> Subject: [PATCH 9/8] contrib/remote-helpers: style updates for test scripts > > And here is the second one. > > -- >8 -- > Subject: [PATCH 10/8] remote-helpers: quote variable references in > redirection targets > > Even though it is not required by POSIX to double-quote the > redirection target in a variable, our code does so because some > versions of bash issue a warning without the quotes. > > Signed-off-by: Junio C Hamano <gits...@pobox.com> > --- > contrib/remote-helpers/test-hg-hg-git.sh | 40 > ++++++++++++++++---------------- > 1 file changed, 20 insertions(+), 20 deletions(-) > [...]
Looks good. Reviewed-by: Michael Haggerty <mhag...@alum.mit.edu> Michael -- Michael Haggerty mhag...@alum.mit.edu http://softwareswirl.blogspot.com/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
