Re: [PATCH 1/2] pack-objects: enforce --depth limit in reused deltas

2017-01-27 Thread Junio C Hamano
Jeff King writes: >> > +#On the receiving end, "index-pack --fix-thin" will >> > +#complete the pack with a base copy of tree X-1. >> >> blob? tree? I think the argument would work the same way for either >> type of objects, but the previous paragraph is using blob as the >> example, so

Re: [PATCH 1/2] pack-objects: enforce --depth limit in reused deltas

2017-01-27 Thread Jeff King
On Fri, Jan 27, 2017 at 03:31:36PM -0800, Junio C Hamano wrote: > Jeff King writes: > > > Since 898b14c (pack-objects: rework check_delta_limit usage, > > 2007-04-16), we check the delta depth limit only when > > figuring out whether we should make a new delta. We don't > > consider it at all wh

Re: [PATCH 1/2] pack-objects: enforce --depth limit in reused deltas

2017-01-27 Thread Junio C Hamano
Jeff King writes: > Since 898b14c (pack-objects: rework check_delta_limit usage, > 2007-04-16), we check the delta depth limit only when > figuring out whether we should make a new delta. We don't > consider it at all when reusing deltas, which means that > packing once with --depth=250, and then

[PATCH 1/2] pack-objects: enforce --depth limit in reused deltas

2017-01-27 Thread Jeff King
Since 898b14c (pack-objects: rework check_delta_limit usage, 2007-04-16), we check the delta depth limit only when figuring out whether we should make a new delta. We don't consider it at all when reusing deltas, which means that packing once with --depth=250, and then again with --depth=50, the se