Re: [PATCH 1/2] git version --build-options: report the build platform, too

2017-12-09 Thread Johannes Schindelin
Hi Eric, On Sat, 9 Dec 2017, Eric Sunshine wrote: > On Fri, Dec 08, 2017 at 04:19:25PM -0500, Eric Sunshine wrote: > > On Fri, Dec 8, 2017 at 4:17 PM, Eric Sunshine > > wrote: > > > On Fri, Dec 8, 2017 at 12:43 PM, Junio C Hamano wrote: > > >> Jonathan Nieder writes: > > >>> Can this use GIT_

Re: [PATCH 1/2] git version --build-options: report the build platform, too

2017-12-09 Thread Eric Sunshine
On Fri, Dec 08, 2017 at 04:19:25PM -0500, Eric Sunshine wrote: > On Fri, Dec 8, 2017 at 4:17 PM, Eric Sunshine wrote: > > On Fri, Dec 8, 2017 at 12:43 PM, Junio C Hamano wrote: > >> Jonathan Nieder writes: > >>> Can this use GIT_BUILD_PLATFORM directly instead of going via the > >>> indirection

Re: [PATCH 1/2] git version --build-options: report the build platform, too

2017-12-08 Thread Eric Sunshine
On Fri, Dec 8, 2017 at 4:17 PM, Eric Sunshine wrote: > On Fri, Dec 8, 2017 at 12:43 PM, Junio C Hamano wrote: >> Jonathan Nieder writes: @@ -413,6 +414,7 @@ int cmd_version(int argc, const char **argv, const char *prefix) if (build_options) { printf("s

Re: [PATCH 1/2] git version --build-options: report the build platform, too

2017-12-08 Thread Eric Sunshine
On Fri, Dec 8, 2017 at 12:43 PM, Junio C Hamano wrote: > Jonathan Nieder writes: >>> @@ -413,6 +414,7 @@ int cmd_version(int argc, const char **argv, const char >>> *prefix) >>> >>> if (build_options) { >>> printf("sizeof-long: %d\n", (int)sizeof(long)); >>> +printf

Re: [PATCH 1/2] git version --build-options: report the build platform, too

2017-12-08 Thread Junio C Hamano
Jonathan Nieder writes: >> @@ -390,6 +390,7 @@ const char *help_unknown_cmd(const char *cmd) >> >> int cmd_version(int argc, const char **argv, const char *prefix) >> { >> +static char build_platform[] = GIT_BUILD_PLATFORM; >> int build_options = 0; >> const char * const usage[]

Re: [PATCH 1/2] git version --build-options: report the build platform, too

2017-12-08 Thread Jonathan Nieder
Hi, Johannes Schindelin wrote: > From: Adric Norris > > When asking for bug reports to include the output of `git version > --build-options`, the idea is that we get a better idea of the > environment where said bug occurs. In this context, it is useful to > distinguish between 32 and 64-bit bui

[PATCH 1/2] git version --build-options: report the build platform, too

2017-12-08 Thread Johannes Schindelin
From: Adric Norris When asking for bug reports to include the output of `git version --build-options`, the idea is that we get a better idea of the environment where said bug occurs. In this context, it is useful to distinguish between 32 and 64-bit builds. We start by distinguishing between x86