Hi Eric, On Sat, 9 Dec 2017, Eric Sunshine wrote:
> On Fri, Dec 08, 2017 at 04:19:25PM -0500, Eric Sunshine wrote: > > On Fri, Dec 8, 2017 at 4:17 PM, Eric Sunshine <sunsh...@sunshineco.com> > > wrote: > > > On Fri, Dec 8, 2017 at 12:43 PM, Junio C Hamano <gits...@pobox.com> wrote: > > >> Jonathan Nieder <jrnie...@gmail.com> writes: > > >>> Can this use GIT_BUILD_PLATFORM directly instead of going via the > > >>> indirection > > >>> of a mutable static string? That is, something like > > >>> > > >>> printf("machine: %s\n", GIT_BUILD_PLATFORM); > > >> > > >> Good point. And if this is externally identified as "machine", > > >> probably the macro should also use the same word, not "platform". > > >> We can go either way, as long as we are consistent, though. > > > > > > In Autoconf parlance, this would be called "host architecture" > > > (GIT_HOST_ARCH). > > > > My bad: "host cpu", rather (GIT_HOST_CPU). > > Dscho, when you re-roll, perhaps replace the current patch with the > one below which determines the CPU type automatically rather than > having to manually maintain and augment a bunch of #ifdefs in help.h. Will do! Ciao, Dscho