Hi Chris,
On Wed, 4 May 2016, Christian Couder wrote:
> On Wed, May 4, 2016 at 4:56 PM, Johannes Schindelin
> wrote:
> >
> > On Wed, 4 May 2016, Christian Couder wrote:
> >
> >> My intent was to try to show that there is some important value to make
> >> the subject close to the "low level" thin
Hi Dscho,
On Wed, May 4, 2016 at 4:56 PM, Johannes Schindelin
wrote:
> Hi Christian,
>
> On Wed, 4 May 2016, Christian Couder wrote:
>
>> My intent was to try to show that there is some important value to make
>> the subject close to the "low level" thing the patch actually does.
>
> I disagree.
Hi Christian,
On Wed, 4 May 2016, Christian Couder wrote:
> My intent was to try to show that there is some important value to make
> the subject close to the "low level" thing the patch actually does.
I disagree. The place to describe low-level details that are not
immediately obvious from the
Hi Dscho,
On Wed, May 4, 2016 at 2:21 PM, Johannes Schindelin
wrote:
> If your patch series contained *one* patch whose intent was to prepare for
> a libified 'apply', yes, indeed, I would think that it would make for a
> fine commit subject. Especially if the other patches tried to do
> complete
Hi Chris,
On Wed, 4 May 2016, Christian Couder wrote:
> On Wed, May 4, 2016 at 1:05 PM, Johannes Schindelin
> wrote:
>
> > So... why not just say "bisect--helper: prepare for modes other than
> > 'next-all'"?
>
> For (an extreme) example, in my patch series about libifying "git apply"
> functi
On Wed, May 4, 2016 at 1:05 PM, Johannes Schindelin
wrote:
> Hi Christian,
>
> On Wed, 4 May 2016, Christian Couder wrote:
>
>> On Wed, May 4, 2016 at 8:07 AM, Eric Sunshine
>> wrote:
>> > On Wed, May 4, 2016 at 1:07 AM, Pranit Bauva
>> > wrote:
>> >> bisect--helper: use OPT_CMDMODE instead of
On Wed, May 4, 2016 at 4:35 PM, Johannes Schindelin
wrote:
> Hi Christian,
>
> On Wed, 4 May 2016, Christian Couder wrote:
>
>> On Wed, May 4, 2016 at 8:07 AM, Eric Sunshine
>> wrote:
>> > On Wed, May 4, 2016 at 1:07 AM, Pranit Bauva
>> > wrote:
>> >> bisect--helper: use OPT_CMDMODE instead of
Hi Christian,
On Wed, 4 May 2016, Christian Couder wrote:
> On Wed, May 4, 2016 at 8:07 AM, Eric Sunshine wrote:
> > On Wed, May 4, 2016 at 1:07 AM, Pranit Bauva wrote:
> >> bisect--helper: use OPT_CMDMODE instead of OPT_BOOL
> >
> > This subject is too low-level, talking about implementation d
Hi Pranit,
On Wed, 4 May 2016, Pranit Bauva wrote:
> `--next-all` is meant to be used as a sub command to support multiple
> "operation mode" though the current implementation does not contain any
> other sub command along side with `--next-all` but further commits will
> include some more subcom
Eric Sunshine writes:
>> +enum sub_commands {
>
> How about calling this 'enum subcommand' (no underscore, non-plural)?
>
>> + NEXT_ALL = 1
>> +};
>> +
>> int cmd_bisect__helper(int argc, const char **argv, const char *prefix)
>> {
>> - int next_all = 0;
>> + int sub_command =
On Wed, May 4, 2016 at 8:07 AM, Eric Sunshine wrote:
> On Wed, May 4, 2016 at 1:07 AM, Pranit Bauva wrote:
>> bisect--helper: use OPT_CMDMODE instead of OPT_BOOL
>
> This subject is too low-level, talking about implementation details,
> whereas it should be giving a high-level summary of the chan
On Wed, May 4, 2016 at 1:07 AM, Pranit Bauva wrote:
> bisect--helper: use OPT_CMDMODE instead of OPT_BOOL
This subject is too low-level, talking about implementation details,
whereas it should be giving a high-level summary of the change.
> `--next-all` is meant to be used as a sub command to su
On Wed, May 4, 2016 at 10:37 AM, Pranit Bauva wrote:
> `--next-all` is meant to be used as a sub command to support multiple
> "operation mode" though the current implementation does not contain any
> other sub command along side with `--next-all` but further commits will
> include some more subco
`--next-all` is meant to be used as a sub command to support multiple
"operation mode" though the current implementation does not contain any
other sub command along side with `--next-all` but further commits will
include some more subcommands.
Mentored-by: Lars Schneider
Mentored-by: Christain C
14 matches
Mail list logo
