Re: [PATCH 04/17] Name local variables more consistently

2012-08-27 Thread Junio C Hamano
Jeff King writes: > Yeah, I agree that "refnames" would be better. I think something like > "spec" or "refspec" would indicate better that they are to be matched > against, but then you run afoul of confusing that with colon-delimited > refspecs (which I do not think fetch-pack understands at all

Re: [PATCH 04/17] Name local variables more consistently

2012-08-27 Thread Junio C Hamano
Michael Haggerty writes: > On 08/26/2012 07:39 PM, Junio C Hamano wrote: > ... >> After all, this codepath is not limited to branches these days as >> the word "head" implies. Rather, has what we >> asked for, and has what the other sides have, and we are >> trying to make sure we haven't aske

Re: [PATCH 04/17] Name local variables more consistently

2012-08-27 Thread Jeff King
On Mon, Aug 27, 2012 at 11:22:36AM +0200, Michael Haggerty wrote: > > Using one name is better, but I wonder "heads" is the better one > > between the two. > > > > After all, this codepath is not limited to branches these days as > > the word "head" implies. Rather, has what we > > asked for, a

Re: [PATCH 04/17] Name local variables more consistently

2012-08-27 Thread Michael Haggerty
On 08/26/2012 07:39 PM, Junio C Hamano wrote: > Jeff King writes: > >> On Thu, Aug 23, 2012 at 10:10:29AM +0200, mhag...@alum.mit.edu wrote: >> >>> From: Michael Haggerty >>> >>> Use the names (nr_heads, heads) consistently across functions, instead >>> of sometimes naming the same values (nr_ma

Re: [PATCH 04/17] Name local variables more consistently

2012-08-26 Thread Junio C Hamano
Jeff King writes: > On Thu, Aug 23, 2012 at 10:10:29AM +0200, mhag...@alum.mit.edu wrote: > >> From: Michael Haggerty >> >> Use the names (nr_heads, heads) consistently across functions, instead >> of sometimes naming the same values (nr_match, match). > > I think this is fine, although: > >> -

Re: [PATCH 04/17] Name local variables more consistently

2012-08-24 Thread Michael Haggerty
On 08/23/2012 10:39 AM, Jeff King wrote: > On Thu, Aug 23, 2012 at 10:10:29AM +0200, mhag...@alum.mit.edu wrote: > >> From: Michael Haggerty >> >> Use the names (nr_heads, heads) consistently across functions, instead >> of sometimes naming the same values (nr_match, match). > > I think this is

Re: [PATCH 04/17] Name local variables more consistently

2012-08-23 Thread Jeff King
On Thu, Aug 23, 2012 at 10:10:29AM +0200, mhag...@alum.mit.edu wrote: > From: Michael Haggerty > > Use the names (nr_heads, heads) consistently across functions, instead > of sometimes naming the same values (nr_match, match). I think this is fine, although: > --- a/builtin/fetch-pack.c > +++

[PATCH 04/17] Name local variables more consistently

2012-08-23 Thread mhagger
From: Michael Haggerty Use the names (nr_heads, heads) consistently across functions, instead of sometimes naming the same values (nr_match, match). Signed-off-by: Michael Haggerty --- builtin/fetch-pack.c | 27 +-- 1 file changed, 13 insertions(+), 14 deletions(-) dif