Re: [PATCH 0/2] add format specifiers to display trailers

2016-11-29 Thread Keller, Jacob E
On Mon, 2016-11-21 at 09:23 -0800, Junio C Hamano wrote: > Jacob Keller writes: > > > > We have %s and %b so that we can reconstruct the whole thing by > > > using both.  It is unclear how %bT fits in this picture.  I > > > wonder > > > if we also need another placeholder that expands to the body

Re: [PATCH 0/2] add format specifiers to display trailers

2016-11-21 Thread Junio C Hamano
Jacob Keller writes: >> We have %s and %b so that we can reconstruct the whole thing by >> using both. It is unclear how %bT fits in this picture. I wonder >> if we also need another placeholder that expands to the body of the >> message without the trailer---otherwise the whole set would becom

[PATCH 0/2] add format specifiers to display trailers

2016-11-18 Thread Jacob Keller
From: Jacob Keller This is based off of jt/use-trailer-api-in-commands so that we can make use of the public trailer API that will parse a string for trailers. I use trailers as a way to store extra commit metadata, and would like a convenient way to obtain the trailers of a commit message easil

Re: [PATCH 0/2] add format specifiers to display trailers

2016-11-18 Thread Jacob Keller
On Fri, Nov 18, 2016 at 3:38 PM, Junio C Hamano wrote: > Jacob Keller writes: > >> Git interpret-trailers will not recognize this as a trailer block >> because it doesn't have any standard git tags within it. Would it be ok >> to augment the trailer interpretation to say that if we have over 75%

Re: [PATCH 0/2] add format specifiers to display trailers

2016-11-18 Thread Junio C Hamano
Jacob Keller writes: > Git interpret-trailers will not recognize this as a trailer block > because it doesn't have any standard git tags within it. Would it be ok > to augment the trailer interpretation to say that if we have over 75% > trailers in the block that we accept it even if it doesn't h

[PATCH 0/2] add format specifiers to display trailers

2016-11-18 Thread Jacob Keller
From: Jacob Keller This is based off of jt/use-trailer-api-in-commands so that we can make use of the public trailer API that will parse a string for trailers. I use trailers as a way to store extra commit metadata, and would like a convenient way to obtain the trailers of a commit message easil