Re: [PATCH] userdiff: Add a builtin pattern for dts files

2019-01-17 Thread Rob Herring
On Sun, Jan 13, 2019 at 3:26 PM Alban Gruin wrote: > > Hi Stephen, > > thank you for your patch. I left a few comments below. > > Le 11/01/2019 à 22:51, Stephen Boyd a écrit : > > The Linux kernel receives many patches to the devicetree files each > > release. The hunk header for those patches ty

Re: [PATCH] userdiff: Add a builtin pattern for dts files

2019-01-17 Thread Alban Gruin
Hi, sorry for the late answer. Le 14/01/2019 à 19:34, Stephen Boyd a écrit : > Quoting Alban Gruin (2019-01-13 13:26:21) >> Hi Stephen, >> >> thank you for your patch. I left a few comments below. >> >> Le 11/01/2019 à 22:51, Stephen Boyd a écrit : >>> diff --git a/userdiff.c b/userdiff.c >>> ind

Re: [PATCH] userdiff: Add a builtin pattern for dts files

2019-01-17 Thread Alban Gruin
Hi Junio, Le 14/01/2019 à 19:34, Junio C Hamano a écrit : > Alban Gruin writes: > >> thank you for your patch. I left a few comments below. >> >> Le 11/01/2019 à 22:51, Stephen Boyd a écrit: >>> The Linux kernel receives many patches to the devicetree files each >>> release. The hunk header for

Re: [PATCH] userdiff: Add a builtin pattern for dts files

2019-01-14 Thread Junio C Hamano
Alban Gruin writes: > thank you for your patch. I left a few comments below. > > Le 11/01/2019 à 22:51, Stephen Boyd a écrit: >> The Linux kernel receives many patches to the devicetree files each >> release. The hunk header for those patches typically show nothing, >> making it difficult to fig

Re: [PATCH] userdiff: Add a builtin pattern for dts files

2019-01-14 Thread Stephen Boyd
Quoting Alban Gruin (2019-01-13 13:26:21) > Hi Stephen, > > thank you for your patch. I left a few comments below. > > Le 11/01/2019 à 22:51, Stephen Boyd a écrit : > > diff --git a/userdiff.c b/userdiff.c > > index 97007abe5b16..2bc964e11089 100644 > > --- a/userdiff.c > > +++ b/userdiff.c > >

Re: [PATCH] userdiff: Add a builtin pattern for dts files

2019-01-13 Thread Alban Gruin
Hi Stephen, thank you for your patch. I left a few comments below. Le 11/01/2019 à 22:51, Stephen Boyd a écrit : > The Linux kernel receives many patches to the devicetree files each > release. The hunk header for those patches typically show nothing, > making it difficult to figure out what nod

[PATCH] userdiff: Add a builtin pattern for dts files

2019-01-11 Thread Stephen Boyd
The Linux kernel receives many patches to the devicetree files each release. The hunk header for those patches typically show nothing, making it difficult to figure out what node is being modified without applying the patch or opening the file and seeking to the context. Let's add a builtin 'dts' p