Re: [PATCH] upload-pack: turn on uploadpack.allowAnySHA1InWant=true

2018-12-17 Thread David Turner
On December 17, 2018 5:57:50 PM EST, "Ævar Arnfjörð Bjarmason" wrote: > >On Mon, Dec 17 2018, David Turner wrote: > >> Overall, I like this. One nit: > >Thanks for the review! > >> On December 17, 2018 5:16:25 PM EST, "Ævar Arnfjörð Bjarmason" > wrote: >>>--- a/upload-pack.c >>>+++ b/upload-pa

Re: [PATCH] upload-pack: turn on uploadpack.allowAnySHA1InWant=true

2018-12-17 Thread Ævar Arnfjörð Bjarmason
On Mon, Dec 17 2018, David Turner wrote: > Overall, I like this. One nit: Thanks for the review! > On December 17, 2018 5:16:25 PM EST, "Ævar Arnfjörð Bjarmason" > wrote: >>--- a/upload-pack.c >>+++ b/upload-pack.c >>@@ -54,7 +54,8 @@ static int no_progress, daemon_mode; >> #define ALLOW_REA

Re: [PATCH] upload-pack: turn on uploadpack.allowAnySHA1InWant=true

2018-12-17 Thread David Turner
Overall, I like this. One nit: On December 17, 2018 5:16:25 PM EST, "Ævar Arnfjörð Bjarmason" wrote: >--- a/upload-pack.c >+++ b/upload-pack.c >@@ -54,7 +54,8 @@ static int no_progress, daemon_mode; > #define ALLOW_REACHABLE_SHA1 02 >/* Allow request of any sha1. Implies ALLOW_TIP_SHA1 and >ALL

[PATCH] upload-pack: turn on uploadpack.allowAnySHA1InWant=true

2018-12-17 Thread Ævar Arnfjörð Bjarmason
Unconditionally turn on uploadpack.allowAnySHA1InWant=true which means that the lesser uploadpack.allow{Tip,Reachable}SHA1InWant settings are implicitly "true" as well. This is because as mentioned in 235ec24352e ("doc: mention transfer data leaks in more places", 2016-11-14) this has always been