Overall, I like this. One nit: On December 17, 2018 5:16:25 PM EST, "Ævar Arnfjörð Bjarmason" <[email protected]> wrote: >--- a/upload-pack.c >+++ b/upload-pack.c >@@ -54,7 +54,8 @@ static int no_progress, daemon_mode; > #define ALLOW_REACHABLE_SHA1 02 >/* Allow request of any sha1. Implies ALLOW_TIP_SHA1 and >ALLOW_REACHABLE_SHA1. */ > #define ALLOW_ANY_SHA1 07 >-static unsigned int allow_unadvertised_object_request; >+static unsigned int allow_unadvertised_object_request = ( >+ ALLOW_TIP_SHA1 | ALLOW_REACHABLE_SHA1 | ALLOW_ANY_SHA1);
ALLOW_ANY_SHA1 already includes the other two. -- Sent from my Android device with K-9 Mail. Please excuse my brevity.
