Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability

2012-10-09 Thread Joachim Schmitz
Junio C Hamano wrote: Junio C Hamano writes: Ben Walton writes: Avoid a GNU-ism in the cp options used by t5400-send-pack. Change -a to -pR. Signed-off-by: Ben Walton --- Thanks, but is "-p" essential for this test to pass, or can we get away with just "-R"? Besides, when you spot a

Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability

2012-10-08 Thread Junio C Hamano
Ben Walton writes: > On Mon, Oct 8, 2012 at 6:45 PM, Junio C Hamano wrote: >> Junio C Hamano writes: >> Thanks, but is "-p" essential for this test to pass, or can we get away with just "-R"? >>> >>> Besides, when you spot a potential problem, please ask "git grep" >>> to catch them a

Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability

2012-10-08 Thread Ben Walton
On Mon, Oct 8, 2012 at 6:45 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >>> Thanks, but is "-p" essential for this test to pass, or can we get >>> away with just "-R"? >> >> Besides, when you spot a potential problem, please ask "git grep" >> to catch them all. > > In other words, how ab

Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability

2012-10-08 Thread Junio C Hamano
Junio C Hamano writes: >> Thanks, but is "-p" essential for this test to pass, or can we get >> away with just "-R"? > > Besides, when you spot a potential problem, please ask "git grep" > to catch them all. In other words, how about doing this instead? -- >8 -- Subject: tests: "cp -a" is a GNU

Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability

2012-10-08 Thread Junio C Hamano
Junio C Hamano writes: > Ben Walton writes: > >> Avoid a GNU-ism in the cp options used by t5400-send-pack. Change -a >> to -pR. >> >> Signed-off-by: Ben Walton >> --- > > Thanks, but is "-p" essential for this test to pass, or can we get > away with just "-R"? Besides, when you spot a potent

Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability

2012-10-08 Thread Junio C Hamano
Ben Walton writes: > Avoid a GNU-ism in the cp options used by t5400-send-pack. Change -a > to -pR. > > Signed-off-by: Ben Walton > --- Thanks, but is "-p" essential for this test to pass, or can we get away with just "-R"? > t/t5400-send-pack.sh | 2 +- > 1 file changed, 1 insertion(+), 1 d

[PATCH] t/t5400-send-pack: Use POSIX options to cp for portability

2012-10-08 Thread Ben Walton
Avoid a GNU-ism in the cp options used by t5400-send-pack. Change -a to -pR. Signed-off-by: Ben Walton --- t/t5400-send-pack.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5400-send-pack.sh b/t/t5400-send-pack.sh index 250c720..65b3b0f 100755 --- a/t/t5400-send-pack.s