Re: [PATCH] pack-objects: turn off bitmaps when we see --shallow lines

On Tue, Aug 12, 2014 at 10:13:03PM +0700, Duy Nguyen wrote: > On Tue, Aug 12, 2014 at 11:34 AM, Jeff King wrote: > > Arguably is_repository_shallow should return 1 if anybody has registered > > a shallow graft, but that wouldn't be enough to fix this (we'd still > > need to check it again _after_

Re: [PATCH] pack-objects: turn off bitmaps when we see --shallow lines

On Tue, Aug 12, 2014 at 11:34 AM, Jeff King wrote: > Arguably is_repository_shallow should return 1 if anybody has registered > a shallow graft, but that wouldn't be enough to fix this (we'd still > need to check it again _after_ reading the --shallow lines). So I think > this fix is fine here. I

[PATCH] pack-objects: turn off bitmaps when we see --shallow lines

Reachability bitmaps do not work with shallow operations, because they cache a view of the object reachability that represents the true objects. Whereas a shallow repository (or a shallow operation in a repository) is inherently cutting off the object graph with a graft. We explicitly disallow the