On Tue, Aug 12, 2014 at 11:34 AM, Jeff King <p...@peff.net> wrote: > Arguably is_repository_shallow should return 1 if anybody has registered > a shallow graft, but that wouldn't be enough to fix this (we'd still > need to check it again _after_ reading the --shallow lines). So I think > this fix is fine here. I don't know if any other parts of the code would > care, though.
It's getting too subtle (is_repository_shallow fails to return 1). register_shallow() is used elsewhere too, luckily pack bitmap's use is still limited in pack-objects (I think).I prefer (in future) to teach is_repository_shallow about register_shallow and move it to right before get_object_list_from_bitmap() is called, and some sort of mechanism to say "hey I'm all set, never change shallow repo status again from now on, or just die if you have to do it" to protect us from similar bugs. But for now your fix is good (and simple). -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
