Oops, I missed Junio's message [1] while looking through my backlog.
Sorry for the noise.
Philip
On 04/07/2019 11:40, Philip Oakley wrote:
If all the issues are cleared then I believe it is a case of providing
a clean reroll (maybe identical to previous..) to Junio and the list
to confirm that
On 27/06/2019 18:10, Dr. Adam Nielsen wrote:
On 25.06.19 13:31, Philip Oakley wrote:
only one minor point...
>>> + - For example, a pattern `doc/frotz/` matches `doc/frotz`
directory,
>>> + but not `a/doc/frotz` directory; however `frotz/` matches `frotz`
>
> her I misread this as: "but
"Dr. Adam Nielsen" writes:
> Hi everyone,
>
> any comments about the patch note from 04.06 ?
https://git.kernel.org/pub/scm/git/git.git/log/ shows that the topic
holding the patch has already been merged to the 'master' branch
about 6 days ago, at
https://git.kernel.org/pub/scm/git/git.git/comm
On 25.06.19 13:31, Philip Oakley wrote:
only one minor point...
>>> + - For example, a pattern `doc/frotz/` matches `doc/frotz` directory,
>>> + but not `a/doc/frotz` directory; however `frotz/` matches `frotz`
>
> her I misread this as: "but not a `doc/frotz` directory;"
> i.e. the leadin
only one minor point...
On 25/06/2019 12:05, Dr. Adam Nielsen wrote:
Hi everyone,
any comments about the patch note from 04.06 ?
All the best,
Adam
On 04.06.19 19:34, Dr. Adam Nielsen wrote:
gitignore.txt: make slash-rules more readable
Renew paragraphs relevant for pattern with slash.
Aim
Hi everyone,
any comments about the patch note from 04.06 ?
All the best,
Adam
On 04.06.19 19:34, Dr. Adam Nielsen wrote:
gitignore.txt: make slash-rules more readable
Renew paragraphs relevant for pattern with slash.
Aim to make it more clear and to avoid possible
pitfalls for the reader. Ad
gitignore.txt: make slash-rules more readable
Renew paragraphs relevant for pattern with slash.
Aim to make it more clear and to avoid possible
pitfalls for the reader. Add some examples.
Signed-off-by: Dr. Adam Nielsen
---
Documentation/gitignore.txt | 66
Hi Philip
On 04.06.19 14:34, Philip Oakley wrote:
I think the rules end up being difficult because we describe them from a
coders implementation viewpoint, rather than a users descriptive
viewpoint. Thus we avoided things like the difficult to code slashes in
the front/middle, and we get caugh
Hi Adam,
On 31/05/2019 08:44, Dr. Adam Nielsen wrote:
gitignore.txt: make slash-rules more readable
Remove meta-rule in a paragraph for trailing-slash.
Be precise whenever a trailing slash would make a
difference. Improve paragraph for pattern without slash.
Remove rule for leading slash because
On 03/06/2019 19:01, Junio C Hamano wrote:
Philip Oakley writes:
From a user perspective, implementation issues shouldn't be part of
the description unless absolutely essential.
Most user aren't aware of the implementation so don't grok/understand
what the fuss is about and ignore it...
Oh,
Philip Oakley writes:
> From a user perspective, implementation issues shouldn't be part of
> the description unless absolutely essential.
> Most user aren't aware of the implementation so don't grok/understand
> what the fuss is about and ignore it...
Oh, absolutely. But unfortunately I do not
gitignore.txt: make slash-rules more readable
Remove meta-rule in a paragraph for trailing-slash.
Be precise whenever a trailing slash would make a
difference. Improve or add paragraphs relevant
for pattern with slash. Add some slash examples
in example section.
Signed-off-by: Dr. Adam Nielsen
Hi Philip,
On 01.06.19 11:33, Philip Oakley wrote:
From a user perspective, implementation issues shouldn't be part of the
description unless absolutely essential.
Most user aren't aware of the implementation so don't grok/understand
what the fuss is about and ignore it...
I agree with tha
Minor spelling mistake at end:
On 31/05/2019 08:44, Dr. Adam Nielsen wrote:
+ (a regular file), "foo/bar" (a diretory), but it does not match
+ "foo/bar/hello.c" (a regular file), as the asterisk in the
+ patter does not match "bar/hello.c" which has a slash in it.
s/patter/pattern/
+
-
Hi Junio,
On 31/05/2019 17:30, Junio C Hamano wrote:
I think the updated text is readable, except for one nit.
Specifically, if you took my suggestion in an earlier review to
explicitly say that leading slash is merely a workaround for a
string without slash to anchor the pattern to the director
gitignore.txt: make slash-rules more readable
Remove meta-rule in a paragraph for trailing-slash.
Be precise whenever a trailing slash would make a
difference. Improve paragraph for pattern without slash.
Remove rule for leading slash because its now redundant.
Instead, add examples for leading
---
Documentation/gitignore.txt | 75 ++---
1 file changed, 54 insertions(+), 21 deletions(-)
diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt
index b5bc9dbff0..ce944779a5 100644
--- a/Documentation/gitignore.txt
+++ b/Documentation/gitignore.
"Dr. Adam Nielsen" writes:
>>> + - The pattern `doc/frotz` and `/doc/frotz` have the same effect
>>> + in any `.gitignore` file. Both pattern contain a non-trailing
>>> + slash and thus match relative to the location of the
>>> + `.gitignore` file.
>>
>> ... this paragraph wouldn't have bee
On 31.05.19 18:30, Junio C Hamano wrote:
"Dr. Adam Nielsen" writes:
gitignore.txt: make slash-rules more readable
Remove meta-rule in a paragraph for trailing-slash.
Be precise whenever a trailing slash would make a
difference. Improve paragraph for pattern without slash.
Remove rule for le
"Dr. Adam Nielsen" writes:
> gitignore.txt: make slash-rules more readable
>
> Remove meta-rule in a paragraph for trailing-slash.
> Be precise whenever a trailing slash would make a
> difference. Improve paragraph for pattern without slash.
> Remove rule for leading slash because its now redun
gitignore.txt: make slash-rules more readable
Remove meta-rule in a paragraph for trailing-slash.
Be precise whenever a trailing slash would make a
difference. Improve paragraph for pattern without slash.
Remove rule for leading slash because its now redundant.
Instead, add examples for leading
On 19.05.19 19:42, Philip Oakley wrote:
Hi Adam,
Hi Philip
a) keep going. the documentation does need improving!
Thank you for the encouragement!
b) also have a look at the `git help glossary` for 'glob' pattern
descriptions for other ideas.
The glob entry looks very familiar to some e
On 18.05.19 21:34, Philip Oakley wrote:
Hi Adam
Hi Philip
On 18/05/2019 15:07, Dr. Adam Nielsen wrote:
This "Otherwise" below could be the complement to the initial "If", or
could be part of a "matches" pair of example sentences. At least on my
initial reading I paired it via the 'matches'
Am 18.05.19 um 16:13 schrieb Dr. Adam Nielsen:
> - - If the pattern ends with a slash, it is removed for the
> - purpose of the following description, but it would only find
> + - A slash `/` is used as a directory separator. A leading and trailing
> + slash have special meaning and are explain
"Dr. Adam Nielsen" writes:
> gitignore.txt: make slash-rules more readable
>
> Make all paragraphs valid, even if they are not read
> in strict order.
I think you are giving up on this, and I do not think that is
particularly a bad thing ;-)
> + - A slash `/` is used as a directory separator. A
Hi Adam
On 18/05/2019 15:07, Dr. Adam Nielsen wrote:
+ - If the pattern contains no slash or only a trailing slash,
+ the pattern is matched against all files and folders (recursively)
+ from the location of the `.gitignore` file.
+ For example, `frotz/` matches `frotz` and `a/frotz` that
gitignore.txt: make slash-rules more readable
Make all paragraphs valid, even if they are not read
in strict order. Make paragraph better understandable
for pattern without slash. Add sentece and example
for pattern with slash. Be precise whenever a trailing
slashe would make a difference. Add so
gitignore.txt: make slash-rules more readable
Make all paragraphs valid, even if they are not read
in strict order. Make paragraph better understandable
for pattern without slash. Add sentece and example
for pattern with slash. Be precise whenever a trailing
slashe would make a difference. Add so
On 18.05.19 08:42, Johannes Sixt wrote:
Am 17.05.19 um 23:43 schrieb Dr. Adam Nielsen:
Another thing that I noticed is that its not mentioned anywhere that
the pattern use a slash as a directory separator (instead of a
backslash), its only clear from the examples. Maybe its worth to
mention i
Am 17.05.19 um 23:43 schrieb Dr. Adam Nielsen:
>> Another thing that I noticed is that its not mentioned anywhere that
>> the pattern use a slash as a directory separator (instead of a
>> backslash), its only clear from the examples. Maybe its worth to
>> mention it in the "PATTERN FORMAT" section.
Another thing that I noticed is that its not mentioned anywhere that the
pattern use a slash as a directory separator (instead of a backslash),
its only clear from the examples. Maybe its worth to mention it in the
"PATTERN FORMAT" section. Also its maybe worth to introduce the term
"leading
On 08.05.19 07:33, Junio C Hamano wrote:
"Dr. Adam Nielsen" writes:
+ - A pattern that contains a non-trailing slash is matched relative to the
location of the `.gitignore` file.
+ For example, `doc/frotz/` matches `doc/frotz` directory, but not
+ `a/doc/frotz` (relative from the `.gi
"Dr. Adam Nielsen" writes:
> + - A pattern that contains a non-trailing slash is matched
> + For example, `doc/frotz/` matches `doc/frotz` directory, but not
> + `a/doc/frotz` (relative from the `.gitignore` file).
> + Note that the pattern `doc/frotz` and `/doc/frotz` have the
> + same e
"Dr. Adam Nielsen" writes:
> On 07.05.19 12:07, Junio C Hamano wrote:
>> "Dr. Adam Nielsen" writes:
>>
>>> gitignore.txt: make slash-rules more readable
>>>
>>> Make all paragraphs valid, even if they are not read
>>> in strict order. Make paragraph better understandable
>>> for pattern without
gitignore.txt: make slash-rules more readable
Make all paragraphs valid, even if they are not read
in strict order. Make paragraph better understandable
for pattern without slash. Add paragraph for pattern
with slash. Be precise whenever a trailing slashes
would make a difference. Add some example
On 07.05.19 12:07, Junio C Hamano wrote:
"Dr. Adam Nielsen" writes:
gitignore.txt: make slash-rules more readable
Make all paragraphs valid, even if they are not read
in strict order. Make paragraph better understandable
for pattern without slash. Add paragraph for pattern
with slash. Be p
"Dr. Adam Nielsen" writes:
> gitignore.txt: make slash-rules more readable
>
> Make all paragraphs valid, even if they are not read
> in strict order. Make paragraph better understandable
> for pattern without slash. Add paragraph for pattern
> with slash. Be precise whenever a trailing slashes
gitignore.txt: make slash-rules more readable
Make all paragraphs valid, even if they are not read
in strict order. Make paragraph better understandable
for pattern without slash. Add paragraph for pattern
with slash. Be precise whenever a trailing slashes
would make a difference. Add some exampl
---
Documentation/gitignore.txt | 37 -
1 file changed, 24 insertions(+), 13 deletions(-)
diff --git a/Documentation/gitignore.txt b/Documentation/gitignore.txt
index b5bc9dbff0..3a6fb9117c 100644
--- a/Documentation/gitignore.txt
+++ b/Documentation/gitignore.
39 matches
Mail list logo
