Julien Carsique writes:
> Hi,
>
> Thank you both for your feedback!
> I'm looking at applying your requests:
> - add tests,
> - variable renaming,
> - use of local,
> - fix multiple issues on string parsing
> - avoid useless bash-isms? Did you agree on the ones I should remove?
>
> I'll send an u
On 2014-10-07 11:57, Julien Carsique wrote:
> Hi,
>
> Thank you both for your feedback!
> I'm looking at applying your requests:
> - add tests,
> - variable renaming,
> - use of local,
> - fix multiple issues on string parsing
> - avoid useless bash-isms? Did you agree on the ones I should remove?
Hi,
Thank you both for your feedback!
I'm looking at applying your requests:
- add tests,
- variable renaming,
- use of local,
- fix multiple issues on string parsing
- avoid useless bash-isms? Did you agree on the ones I should remove?
I'll send an updated patch asap. Tell me if I forgot somethi
Richard Hansen writes:
>> and there is no hope to "fix" them to stick to
>> the bare-minimum POSIX,
>
> I don't think it'd be hard to convert it to pure POSIX if there was a
> desire to do so.
Not necessarily; if you make it so slow to be usable as a prompt
script, that is not a "conversion". B
On 2014-09-30 18:35, Junio C Hamano wrote:
> Richard Hansen writes:
>> * While this syntax works in both Bash and Zsh (assuming no
>> pattern-special characters), my preference is to stick to POSIX[1]
>> when possible.
>
> Nah. The existing script is full of bash-isms like local you
>
Richard Hansen writes:
> Additional cases could be added to handle git-svn if needed.
Thanks for a review (everything I omitted above looked good to me).
>> +
>> __git_ps1_upstream_name=${__git_ps1_upstream_name/$__head/=}
>
> * This could break if ${__head} contai
Julien Carsique writes:
> From: Julien Carsique
>
> When using the "name" option of GIT_PS1_SHOWUPSTREAM to show the upstream
> abbrev name, if the upstream name is the same as the local name, then some
> space could be saved in the prompt. This is especially needed on long branch
> names.
>
> R
On 2014-09-30 11:36, Julien Carsique wrote:
> From: Julien Carsique
>
> When using the "name" option of GIT_PS1_SHOWUPSTREAM to show the upstream
> abbrev name, if the upstream name is the same as the local name, then some
> space could be saved in the prompt. This is especially needed on long br
From: Julien Carsique
When using the "name" option of GIT_PS1_SHOWUPSTREAM to show the upstream
abbrev name, if the upstream name is the same as the local name, then some
space could be saved in the prompt. This is especially needed on long branch
names.
Replace the upstream name with the sign '
9 matches
Mail list logo
