Jeff King writes:
> I'd suggest s/F/f/ in the message to match our usual style, though I see
> this code has a lot of capitalized errors already. :)
Yup, I'd prepare a prelim clean-up before this step.
>> +test_expect_success 'failure to write cover-letter aborts gracefully' '
>> +test_when
On Fri, Feb 22, 2019 at 1:28 PM Jeff King wrote:
> > diff --git a/builtin/log.c b/builtin/log.c
> > index 3e145fe502..43fc9a07df 100644
> > --- a/builtin/log.c
> > +++ b/builtin/log.c
> > @@ -1047,7 +1047,7 @@ static void make_cover_letter(struct rev_info *rev,
> > int use_stdout,
> >
> > i
On Thu, Feb 21, 2019 at 03:50:11PM -0800, Junio C Hamano wrote:
> The make_cover_letter() function is supposed to open a new file for
> writing, and let the caller write into it via FILE *rev->diffopt.file
> but because the function does not return anything, the caller does not
> bother checking t
The make_cover_letter() function is supposed to open a new file for
writing, and let the caller write into it via FILE *rev->diffopt.file
but because the function does not return anything, the caller does not
bother checking the return value.
Make sure it dies, instead of keep going with a NULL ou
4 matches
Mail list logo
