Jeff King <p...@peff.net> writes:

> I'd suggest s/F/f/ in the message to match our usual style, though I see
> this code has a lot of capitalized errors already. :)

Yup, I'd prepare a prelim clean-up before this step.

>> +test_expect_success 'failure to write cover-letter aborts gracefully' '
>> +    test_when_finished "rmdir 0000-cover-letter.patch" &&
>> +    mkdir 0000-cover-letter.patch &&
>> +    test_must_fail git format-patch --no-renames --cover-letter -1
>> +'
>
> Cute test. :)

Those who can find this "cute" would probably know, but for others,
this is a trick to test codepath for "cannot create a file" error
without requiring SANITY prerequisite.

Reply via email to