Re: [PATCH] config: preserve case for one-shot config on the command line

2017-02-21 Thread Junio C Hamano
Jeff King writes: >> +. ./test-lib.sh > > There are a bunch of other "git -c" tests inside t1300. I don't know if > it would be better to put them all together. I considered it, but it is already very long and I suspect it would be better in the longer term to split the command-line one out into

Re: [PATCH] config: preserve case for one-shot config on the command line

2017-02-20 Thread Jeff King
On Mon, Feb 20, 2017 at 01:58:07AM -0800, Junio C Hamano wrote: > Since nothing seems to have happened in the meantime, here is what > I'll queue so that we won't forget for now. Lars's tests based on > how the scripted "git submodule" uses "git config" may still be > valid, but it is somewhat a

Re: [PATCH] config: preserve case for one-shot config on the command line

2017-02-20 Thread Lars Schneider
> On 20 Feb 2017, at 10:58, Junio C Hamano wrote: > > Junio C Hamano writes: > >> I still haven't queued any of the variants I posted (and I do not >> think other people sent their own versions, either). I need to pick >> one and queue, with a test or two. Perhaps after -rc2. >> >> Others

Re: [PATCH] config: preserve case for one-shot config on the command line

2017-02-20 Thread Junio C Hamano
is not the focus of this topic. -- >8 -- From: Junio C Hamano Date: Wed, 15 Feb 2017 15:48:44 -0800 Subject: [PATCH] config: preserve case for one-shot config on the command line The "git -c = cmd" mechanism is to pretend that a configuration variable is set to while the cmd is runnin

Re: [PATCH] config: preserve case for one-shot config on the command line

2017-02-16 Thread Junio C Hamano
Jeff King writes: > On Thu, Feb 16, 2017 at 11:30:28AM +0100, Lars Schneider wrote: > >> >> > On 16 Feb 2017, at 00:48, Junio C Hamano wrote: >> > >> > The "git -c = cmd" mechanism is to pretend that a >> >> The problem is also present for gitconfig variables e.g. >> git config --local submod

Re: [PATCH] config: preserve case for one-shot config on the command line

2017-02-16 Thread Jeff King
On Thu, Feb 16, 2017 at 11:30:28AM +0100, Lars Schneider wrote: > > > On 16 Feb 2017, at 00:48, Junio C Hamano wrote: > > > > The "git -c = cmd" mechanism is to pretend that a > > The problem is also present for gitconfig variables e.g. > git config --local submodule.UPPERSUB.update none Hrm,

Re: [PATCH] config: preserve case for one-shot config on the command line

2017-02-16 Thread Junio C Hamano
Lars Schneider writes: >> On 16 Feb 2017, at 00:48, Junio C Hamano wrote: >> >> The "git -c = cmd" mechanism is to pretend that a > > The problem is also present for gitconfig variables e.g. > git config --local submodule.UPPERSUB.update none Yuck. > But your patch below fixes that, too! Heh

Re: [PATCH] config: preserve case for one-shot config on the command line

2017-02-16 Thread Lars Schneider
> On 16 Feb 2017, at 00:48, Junio C Hamano wrote: > > The "git -c = cmd" mechanism is to pretend that a The problem is also present for gitconfig variables e.g. git config --local submodule.UPPERSUB.update none But your patch below fixes that, too! > configuration variable is set to while

[PATCH] config: preserve case for one-shot config on the command line

2017-02-15 Thread Junio C Hamano
The "git -c = cmd" mechanism is to pretend that a configuration variable is set to while the cmd is running. The code to do so however downcased in its entirety, which is wrong for a three-level ... The part needs to stay as-is. Reported-by: Lars Schneider Diagnosed-by: Jonathan Tan Signed