Jeff King <p...@peff.net> writes: >> +. ./test-lib.sh > > There are a bunch of other "git -c" tests inside t1300. I don't know if > it would be better to put them all together.
I considered it, but it is already very long and I suspect it would be better in the longer term to split the command-line one out into a separate script, for the reasons you state. I can move these at the end of 1300 in the meantime, and leave the split for somebody else to be done later. > Arguably, those other ones should get pulled out here to the new script. > More scripts means that the tests have fewer hidden dependencies, and we > can parallelize the run more. I admit I've shied away from new scripts > in the past because the number allocation is such a pain. > >> +test_expect_success 'last one wins: two level vars' ' >> + echo VAL >expect && >> + >> + # sec.var and sec.VAR are the same variable, as the first >> + # and the last level of a configuration variable name is >> + # case insensitive. Test both setting and querying. > > I assume by "setting and querying" here you mean "setting via -c, > querying via git-config". Yes. Should I update it to be more explicit? > There are two blocks of tests, each with their own "expect" value. > Should the top "expect" here be moved down with its block to make that > more clear? Perhaps. Let me try that one. Thanks.
