Re: [PATCH] builtin/apply.c: fuzzy_matchlines:trying to fix some inefficiencies

On Thu, Mar 20, 2014 at 11:35:03AM +0200, George Papanikolaou wrote: > Hi again guys, > I forgot to add the signed-of line to the tiny patch I sent earlier for GSOC. > Any ideas about the changes? > Thanks... You don't give any detail on the inefficiencies, or what specific benchmark is made fast

Re: [PATCH] builtin/apply.c: fuzzy_matchlines:trying to fix some inefficiencies

Hi, Thanks for the feedback, On Thu, Mar 20, 2014 at 11:58 AM, Michael Haggerty wrote: > > Why is this an improvement? Do you expect this function to be called > often for empty lines (as opposed, for example, to lines consisting > solely of whitespace characters)? > Yes, you are probably right

Re: [PATCH] builtin/apply.c: fuzzy_matchlines:trying to fix some inefficiencies

Hello and welcome. See the comments inline. On 03/20/2014 02:32 AM, George Papanikolaou wrote: > Hi fellows, > I'm planning on applying on GSOC 2014... > > I tried my luck with that kinda weird microproject about inefficiencies, > and I think I've discovered some. > > (also on a totally differe

[PATCH] builtin/apply.c: fuzzy_matchlines:trying to fix some inefficiencies

Hi again guys, I forgot to add the signed-of line to the tiny patch I sent earlier for GSOC. Any ideas about the changes? Thanks... Signed-off-by: George Papanikolaou --- builtin/apply.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/builtin/apply.

[PATCH] builtin/apply.c: fuzzy_matchlines:trying to fix some inefficiencies

Hi fellows, I'm planning on applying on GSOC 2014... I tried my luck with that kinda weird microproject about inefficiencies, and I think I've discovered some. (also on a totally different mood, there are some warning about empty format strings during compilation that could easily be silenced wit