On 2019.10.14 17:12, Jonathan Tan wrote:
> The specification of promisor packfiles (in partial-clone.txt) states
> that the .promisor files that accompany packfiles do not matter (just
> like .keep files), so whenever a packfile is fetched from the promisor
> remote, Git has been writing empty .pro
I have a few questions below, but they're probably due to lack of a full
understanding on my part of how packfiles are managed.
On 2019.08.26 14:47, Jonathan Tan wrote:
> The specification of promisor packfiles (in partial-clone.txt) states
> that the .promisor files that accompany packfiles do no
On 2019.10.07 14:46, Jonathan Tan wrote:
> > We'd like to collect better statistics about where the time is spent in
> > fetches and pushes so that we can hopefully identify some areas for
> > future optimization. So let's add some trace2 regions around some of the
> > fetch/push phases so we can b
* Use the repository struct argument in transport_push(), rather than
the global the_repository.
Josh Steadmon (2):
fetch: add trace2 instrumentation
push: add trace2 instrumentation
builtin/fetch.c | 22 +++---
builtin/push.c | 2 ++
fetch-pack.c| 13 -
t
Add trace2 regions to fetch-pack.c and builtins/fetch.c to better track
time spent in the various phases of a fetch:
* listing refs
* negotiation for protocol versions v0-v2
* fetching refs
* consuming refs
Signed-off-by: Josh Steadmon
---
builtin/fetch.c | 22 +++---
fetch
Add trace2 regions in transport.c and builtin/push.c to better track
time spent in various phases of pushing:
* Listing refs
* Checking submodules
* Pushing submodules
* Pushing refs
Signed-off-by: Josh Steadmon
---
builtin/push.c | 2 ++
transport.c| 14 --
2 files changed
Make it explicit that we always want trace2 "version" events to be the
first event of any trace session. Also list the changes that would or
would not cause the EVENT format version field to be incremented.
Change-Id: I20b9ac1fa0786bcaad7e290cc805cbf45b323021
Signed-off-by: Jos
Changes since V4:
* Avoid the use of the non-specific term "overload" in code, trace
output, commit messages, and documentation.
* Remove an unnecessary include that was breaking the Windows
build.
Josh Steadmon (4):
docs: mention trace2 target-dir mode in git-config
docs: clar
62cfaa4500
Signed-off-by: Josh Steadmon
---
Documentation/technical/api-trace2.txt | 7 +++
Documentation/trace2-target-values.txt | 4 +++-
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/Documentation/technical/api-trace2.txt
b/Documentation/technical/api-trace2.txt
index
should be safe to generate new trace files again.
The default value for trace2.maxFiles is zero, which disables the file
count check.
The config can also be overridden with a new environment variable:
GIT_TRACE2_MAX_FILES.
Change-Id: I8fc613e88dd99ffcdeea9d6c1f232c3670096a9e
Signed-off-by: Josh
often the file count check triggers in practice.
Bump up the event format version since we've added a new event type.
Change-Id: I0953c1a891ad93585ddcd8e22575ec34c0ebe73c
Signed-off-by: Josh Steadmon
---
Documentation/technical/api-trace2.txt | 16 +++--
t/t0212-trace2-event.sh
On 2019.10.04 11:12, Johannes Schindelin wrote:
> Hi Josh,
>
> On Thu, 3 Oct 2019, Josh Steadmon wrote:
>
> > [...]
> > diff --git a/trace2/tr2_dst.c b/trace2/tr2_dst.c
> > index 5dda0ca1cd..af3405f179 100644
> > --- a/trace2/tr2_dst.c
> > +++ b/trace2/t
On 2019.10.04 09:25, Junio C Hamano wrote:
> Josh Steadmon writes:
>
> > trace2 can write files into a target directory. With heavy usage, this
> > directory can fill up with files, causing difficulty for
> > trace-processing systems.
>
> Sorry for not mentioning t
Move the description of trace2's target-directory behavior into the
shared trace2-target-values file so that it is included in both the
git-config and api-trace2 docs. Leave the SID discussion only in
api-trace2 since it's a technical detail.
Signed-off-by: Josh Steadmon
---
Doc
value for trace2.maxFiles is zero, which disables the
overload check.
The config can also be overridden with a new environment variable:
GIT_TRACE2_MAX_FILES.
Signed-off-by: Josh Steadmon
---
Documentation/config/trace2.txt | 6 +++
t/t0212-trace2-event.sh | 17 +++
trace2
often the overload protection feature is triggered in practice.
Bump up the event format version since we've added a new event type.
Signed-off-by: Josh Steadmon
---
Documentation/technical/api-trace2.txt | 15 ++--
t/t0212-trace2-event.sh| 4 ++-
t
vent comes
after the version event.
I am still incrementing the EVT and writing a new "overload" event,
since you said in the last review that this approache seems best to you.
But I am also happy to keep the EVT=1 and make "overload" a new field in
the "version" ev
Make it explicit that we always want trace2 "version" events to be the
first event of any trace session. Also list the changes that would or
would not cause the EVENT format version field to be incremented.
Signed-off-by: Josh Steadmon
---
Documentation/technical/api-trace2.txt | 8 +
Add trace2 regions to fetch-pack.c and builtins/fetch.c to better track
time spent in the various phases of a fetch:
* listing refs
* negotiation for protocol versions v0-v2
* fetching refs
* consuming refs
Signed-off-by: Josh Steadmon
---
builtin/fetch.c | 22 +++---
fetch
We'd like to collect better statistics about where the time is spent in
fetches and pushes so that we can hopefully identify some areas for
future optimization. So let's add some trace2 regions around some of the
fetch/push phases so we can break down their timing.
Josh Steadmon (2):
Add trace2 regions in transport.c and builtin/push.c to better track
time spent in various phases of pushing:
* Listing refs
* Checking submodules
* Pushing submodules
* Pushing refs
Signed-off-by: Josh Steadmon
---
builtin/push.c | 2 ++
transport.c| 14 --
2 files changed
On 2019.09.19 14:23, Jeff Hostetler wrote:
>
>
> On 9/16/2019 2:20 PM, Josh Steadmon wrote:
> > On 2019.09.16 10:11, Jeff Hostetler wrote:
> > >
> > >
> > > On 9/16/2019 8:07 AM, Derrick Stolee wrote:
> > > > On 9/13/2019 8:26 PM, Josh Ste
On 2019.09.16 10:11, Jeff Hostetler wrote:
>
>
> On 9/16/2019 8:07 AM, Derrick Stolee wrote:
> > On 9/13/2019 8:26 PM, Josh Steadmon wrote:
> > > Add a new "overload" event type for trace2 event destinations. Write
> > > this event into the s
On 2019.09.16 08:07, Derrick Stolee wrote:
> On 9/13/2019 8:26 PM, Josh Steadmon wrote:
> > Add a new "overload" event type for trace2 event destinations. Write
> > this event into the sentinel file created by the trace2.maxFiles
> > feature. Bump up the event for
g how
often the overload protection feature is triggered in practice.
Signed-off-by: Josh Steadmon
---
Documentation/technical/api-trace2.txt | 17 ++--
trace2/tr2_dst.c | 38 --
trace2/tr2_dst.h | 3 ++
trace2/
same time.
* Removed some unnecessary sanity-checking in the test.
* Fixed a coccicheck complaint about strbuf_addbuf.
* Used hardcoded file modes to be consistent with the rest of the
project.
Josh Steadmon (3):
docs: mention trace2 target-dir mode in git-config
trace2: don't ov
Move the description of trace2's target-directory behavior into the
shared trace2-target-values file so that it is included in both the
git-config and api-trace2 docs. Leave the SID discussion only in
api-trace2 since it's a technical detail.
Signed-off-by: Josh Steadmon
---
Doc
test to make sure that contention between multiple
processes all writing to the same target directory does not become an
issue.
Signed-off-by: Josh Steadmon
---
Documentation/config/trace2.txt | 6 +++
t/t0212-trace2-event.sh | 17 +++
trace2/tr2_dst.c| 86
On 2019.09.07 10:26, Junio C Hamano wrote:
> * js/trace2-json-schema (2019-07-25) 3 commits
> . ci: run trace2 schema validation in the CI suite
> . trace2: add a schema validator for trace2 events
> . trace2: add a JSON schema for trace2 events
>
> The JSON output produced by "trace2" subsyst
ly have a merge to perform (by resetting the "side" branch
to its original state).
* reworded commit message
]
Improved-by: Martin Ågren
Signed-off-by: Michael J Gruber
Signed-off-by: Martin Ågren
Signed-off-by: Josh Steadmon
---
Documentation/githooks.txt
Signed-off-by: Michael J Gruber
Signed-off-by: Josh Steadmon
---
Documentation/git-merge.txt | 2 +-
Documentation/merge-options.txt | 4
builtin/merge.c | 6 +++---
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/Documentation/git-merge.txt b/Document
the tests to follow the example set in patch 1/4.
* Reworded commit messages to match with the current state of certain
flags, which changed in between V1 and V2 of this series.
Josh Steadmon (1):
t7503: verify proper hook execution
Michael J Gruber (3):
merge: do no-verify like commit
gi
utable hook
* when testing that the merge hook did not run, make sure we
actually have a merge to perform (by resetting the "side" branch
to its original state).
]
Improved-by: Martin Ågren
Signed-off-by: Michael J Gruber
Signed-off-by: Martin Ågren
Signed-off-
setup inside a test_expect_success block.
Improved-by: Martin Ågren
Signed-off-by: Martin Ågren
Signed-off-by: Josh Steadmon
---
t/t7503-pre-commit-hook.sh | 157 +
1 file changed, 89 insertions(+), 68 deletions(-)
diff --git a/t/t7503-pre-commit-hook.sh b/t/
On 2019.08.06 11:14, Junio C Hamano wrote:
> Josh Steadmon writes:
>
> > t7503 did not verify that the expected hooks actually ran during
> > testing. Fix that by making the hook scripts write their $0 into a file
> > so that we can compare actual execution vs. expected
setup inside a test_expect_success block.
Improved-by: Martin Ågren
Signed-off-by: Martin Ågren
Signed-off-by: Josh Steadmon
---
t/t7503-pre-commit-hook.sh | 157 +
1 file changed, 89 insertions(+), 68 deletions(-)
diff --git a/t/t7503-pre-commit-hook.sh b/t/
Signed-off-by: Michael J Gruber
Signed-off-by: Josh Steadmon
---
Documentation/git-merge.txt | 2 +-
Documentation/merge-options.txt | 4
builtin/merge.c | 6 +++---
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/Documentation/git-merge.txt b/Document
ly have a merge to perform (by resetting the "side" branch
to its original state).
* reworded commit message
]
Improved-by: Martin Ågren
Signed-off-by: Michael J Gruber
Signed-off-by: Martin Ågren
Signed-off-by: Josh Steadmon
---
Documentation/githooks.txt
flags, which changed in between V1 and V2 of this series.
Josh Steadmon (1):
t7503: verify proper hook execution
Michael J Gruber (3):
merge: do no-verify like commit
git-merge: honor pre-merge-commit hook
merge: --no-verify to bypass pre-merge-commit hook
Documentation/git-merge.txt
utable hook
* when testing that the merge hook did not run, make sure we
actually have a merge to perform (by resetting the "side" branch
to its original state).
]
Improved-by: Martin Ågren
Signed-off-by: Michael J Gruber
Signed-off-by: Martin Ågren
Signed-off-
On 2019.08.05 11:34, Jeff Hostetler wrote:
>
>
> On 8/2/2019 6:02 PM, Josh Steadmon wrote:
> > trace2 can write files into a target directory. With heavy usage, this
> > directory can fill up with files, causing difficulty for
> > trace-processing systems.
> &
On 2019.08.05 20:01, SZEDER Gábor wrote:
> On Fri, Aug 02, 2019 at 03:02:35PM -0700, Josh Steadmon wrote:
> > +test_expect_success "don't overload target directory" '
> > + mkdir trace_target_dir &&
> &g
On 2019.08.02 11:45, Martin Ågren wrote:
> On Fri, 2 Aug 2019 at 00:20, Josh Steadmon wrote:
>
> > diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt
> > index 82cd573776..7c4c994858 100644
> > --- a/Documentation/githooks.txt
> > +++ b/Documentat
On 2019.08.02 11:56, Martin Ågren wrote:
> [Dropped cc-list the first time around. Apologies to those who receive
> this twice...]
>
> On Fri, 2 Aug 2019 at 00:20, Josh Steadmon wrote:
> >
> > This series adds a new pre-merge-commit hook, similar in usage to
> > pre
test to make sure that contention between multiple
processes all writing to the same target directory does not become an
issue.
Signed-off-by: Josh Steadmon
---
Documentation/config/trace2.txt | 6 +++
t/t0210-trace2-normal.sh| 19
trace2/tr2_dst.c| 86
Move the description of trace2's target-directory behavior into the
shared trace2-target-values file so that it is included in both the
git-config and api-trace2 docs. Leave the SID discussion only in
api-trace2 since it's a technical detail.
Signed-off-by: Josh Steadmon
---
Doc
ves the file count threshold from a #define constant to a config
option.
* Renames the threshold override envvar to be consistent with other
trace2 envvars.
* Simplified the new test case in t0210.
Josh Steadmon (2):
docs: mention trace2 target-dir mode in git-config
trace2: don't ove
On 2019.07.31 13:04, Jeff Hostetler via GitGitGadget wrote:
> This patch series contains a few column alignment and whitespace fixes for
> perf target format. This should make it a little easier to read.
>
> Jeff Hostetler (3):
> trace2: cleanup column alignment in perf target format
> trace2:
V2's patch 4/4) into patch 3/4.
Modified the tests to follow the example set in patch 1/4.
* Reworded commit messages to match with the current state of certain
flags, which changed in between V1 and V2 of this series.
Josh Steadmon (1):
t7503: verify proper hook execution
Michael J Gru
setup inside a test_expect_success block.
Signed-off-by: Josh Steadmon
---
t/t7503-pre-commit-hook.sh | 162 +
1 file changed, 94 insertions(+), 68 deletions(-)
diff --git a/t/t7503-pre-commit-hook.sh b/t/t7503-pre-commit-hook.sh
index 984889b39d..500bdd97c2 1
o follow new pattern from this series' patch 1/4
* reworded commit message
]
Signed-off-by: Michael J Gruber
Signed-off-by: Josh Steadmon
---
Documentation/githooks.txt| 7 +++
builtin/merge.c | 12 +
...-pre-commit-and-p
at both do the same in the same way. This also changes the output of
"git merge --help" to be more clear that the hook return code is
respected by default.
[js: * reworded commit message
* squashed documentation changes from original series' patch 3/4
]
Signed-off-by: Michael J Gr
g documentation to reflect new hook name
* cleaned up trailing whitespace
* squashed test changes from the original series' patch 4/4
* modified tests to follow pattern from this series' patch 1/4
]
Signed-off-by: Michael J Gruber
Signed-off-by: Josh Steadmon
---
Documentat
On 2019.07.26 15:03, Josh Steadmon wrote:
[snip]
> [ajv-cli] can validate the full 1.7M line trace output in just over a
> minute. Moreover, it has helpful output when validation fails. So I
> would be happy to re-implement this using ajv-cli.
Unfortunately, ajv on Travis is much slowe
On 2019.07.30 09:13, Martin Ågren wrote:
> On Tue, 30 Jul 2019 at 01:43, Josh Steadmon wrote:
> >
> > On 2019.07.29 22:04, Martin Ågren wrote:
> > > This script seems to me like if it passes 100%, we can be fairly sure
> > > we're ok, but [...]
>
>
On 2019.07.30 14:00, Jeff Hostetler wrote:
>
>
> On 7/29/2019 6:20 PM, Josh Steadmon wrote:
> > trace2 can write files into a target directory. With heavy usage, this
> > directory can fill up with files, causing difficulty for
> > trace-processing systems.
>
>
On 2019.07.30 12:46, Jeff Hostetler wrote:
[snip]
> Also release sentinel_path ?
> (And in both of the return statements below.)
Thanks for the catch. Fixed in V2.
On 2019.07.30 12:46, Jeff Hostetler wrote:
>
>
> On 7/29/2019 6:20 PM, Josh Steadmon wrote:
> > trace2 can write files into a target directory. With heavy usage, this
> > directory can fill up with files, causing difficulty for
> > trace-processing systems.
> &g
On 2019.07.30 09:29, Derrick Stolee wrote:
> On 7/29/2019 6:20 PM, Josh Steadmon wrote:
> > trace2 can write files into a target directory. With heavy usage, this
> > directory can fill up with files, causing difficulty for
> > trace-processing systems.
> >
> > Wh
On 2019.07.29 22:04, Martin Ågren wrote:
> On Fri, 19 Jul 2019 at 00:57, Josh Steadmon wrote:
> > +test_expect_success '--no-verify with succeeding hook (merge)' '
> > +
> > + git checkout side &&
> > + git merge --no-verify -m "
On 2019.07.29 22:29, Martin Ågren wrote:
> On Fri, 19 Jul 2019 at 01:56, Josh Steadmon wrote:
> > This series revives an old suggestion [...] to make merge honor
> > pre-commit hook or a separate pre-merge hook. Since pre-commit does not
> > receive any arguments (which th
On 2019.07.29 22:02, Martin Ågren wrote:
> On Fri, 19 Jul 2019 at 00:57, Josh Steadmon wrote:
> > From: Michael J Gruber
> >
> > Analogous to commit, introduce a '--no-verify' option which bypasses the
> > pre-merge hook. The shorthand '-n' is take
On 2019.07.29 22:09, Martin Ågren wrote:
> On Fri, 19 Jul 2019 at 01:56, Josh Steadmon wrote:
> > * Martin's objection on 1/4 that the sample hook would always exit
> > successfully is (I believe) incorrect. To test this, I ran
> > "/bin/true && exec tes
trace2 output format).
* Make the overload threshold (and the whole overload feature)
configurable.
Signed-off-by: Josh Steadmon
---
t/t0210-trace2-normal.sh | 15
trace2/tr2_dst.c | 81
2 files changed, 96 insertions(+)
diff --git a/t/t0210
On 2019.07.26 14:12, Johannes Schindelin wrote:
> Hi,
>
> On Fri, 26 Jul 2019, SZEDER Gábor wrote:
>
> > On Wed, Jul 24, 2019 at 04:06:50PM -0700, Josh Steadmon wrote:
> >
> > > 3: acf3aebcaa ! 3: a07458b2e4 ci: run trace2 schema validation in the
> > &
On 2019.07.25 09:14, Junio C Hamano wrote:
> SZEDER Gábor writes:
>
> >> I would appreciate any feedback on better ways to integrate the
> >> validator into the CI suite.
> >
> > How about adding a test script dedicated to JSON schema validation,
> > which runs only as many git commands as needed
On 2019.07.01 13:19, Emily Shaffer wrote:
> Existing documentation on revision walks seems to be primarily intended
> as a reference for those already familiar with the procedure. This
> tutorial attempts to give an entry-level guide to a couple of bare-bones
> revision walks so that new Git contri
Signed-off-by: Josh Steadmon
---
ci/run-build-and-tests.sh | 6 ++
1 file changed, 6 insertions(+)
diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh
index cdd2913440..ec38bf379a 100755
--- a/ci/run-build-and-tests.sh
+++ b/ci/run-build-and-tests.sh
@@ -14,6 +14,8 @@ make
-schema/reference/combining.html#allof
Signed-off-by: Josh Steadmon
---
t/trace_schema_validator/README | 23 +
t/trace_schema_validator/event_schema.json| 398 ++
t/trace_schema_validator/list_schema.json | 401 ++
.../strict_list_schema.json
ropped the documenation fix, as it can be submitted separately from
this series
* added JSON-array versions of the schema (currently unused)
* added the validation test to the CI suite
Josh Steadmon (3):
trace2: Add a JSON schema for trace2 events
trace2: add a schema validator for trace2 e
-off-by: Josh Steadmon
---
t/trace_schema_validator/.gitignore | 1 +
t/trace_schema_validator/Makefile | 18
.../trace_schema_validator.go | 82 +++
3 files changed, 101 insertions(+)
create mode 100644 t/trace_schema_validator/.gitignore
Thanks for the review, replies are inline below.
On 2019.07.11 15:35, Jakub Narebski wrote:
> Josh Steadmon writes:
>
> > trace_schema_validator can be used to verify that trace2 event output
> > conforms to the expectations set by the API documentation and codified
> >
On 2019.07.10 20:32, Jakub Narebski wrote:
> Josh Steadmon writes:
>
> > Define a JSON schema[1] that can be used to validate trace2 event
> > objects. This can be used to add regression tests to verify that the
> > event output format does not change unexpectedly.
>
(I'm resending this cover letter with fixed Message-Id so that threading
@ public-inbox works properly. Sorry for the noise.)
I would like to revive discussion on this series; I have addressed most
of the review comments on the original series sent by Michael, with the
following exceptions:
* Mar
I would like to revive discussion on this series; I have addressed most
of the review comments on the original series sent by Michael, with the
following exceptions:
* Martin's objection on 1/4 that the sample hook would always exit
successfully is (I believe) incorrect. To test this, I ran
"/
ned-off-by: Josh Steadmon
---
...> t7503-pre-commit-and-pre-merge-hooks.sh} | 66 ++-
1 file changed, 65 insertions(+), 1 deletion(-)
rename t/{t7503-pre-commit-hook.sh => t7503-pre-commit-and-pre-merge-hooks.sh}
(67%)
diff --git a/t/t7503-pre-commit-hook.sh
b/t/t7503-pr
commit to 2/4.]
Signed-off-by: Michael J Gruber
Signed-off-by: Josh Steadmon
---
Documentation/githooks.txt | 2 +-
builtin/merge.c| 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt
index dcc6606d44..6a93478
(or any
other commit).
[js: addressed review comments:
* clarified that hook should write messages to stderr
* only discard the index if the hook is actually present
]
Signed-off-by: Michael J Gruber
Signed-off-by: Josh Steadmon
---
Documentation/githooks.txt| 7
by: Michael J Gruber
Signed-off-by: Josh Steadmon
---
Documentation/git-merge.txt | 2 +-
Documentation/merge-options.txt | 4
builtin/merge.c | 6 +++---
3 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/Documentation/git-merge.txt b/Documentation/git-merge.
through
git-submodule and git-submodule--helper.
Signed-off-by: Josh Steadmon
---
builtin/clone.c| 9 +++
builtin/submodule--helper.c| 41 +-
git-submodule.sh | 17 -
t/t5617-clone-submodules-remote.sh | 19
On 2019.06.20 14:06, Emily Shaffer wrote:
> On Wed, Jun 19, 2019 at 08:17:29AM -0700, Junio C Hamano wrote:
> > Emily Shaffer writes:
> >
> > > Maybe there's a case for storing them as a set of patch files that are
> > > revision-controlled somewhere within Documentation/? There was some
> > > di
Correct the api-trace2 documentation, which lists "signal" as an
expected field for the signal event type, but which actually outputs
"signo" as the field name.
Signed-off-by: Josh Steadmon
---
This patch has been split off from the "Add a JSON Schema for trace2
events&q
-off-by: Josh Steadmon
---
t/trace_schema_validator/.gitignore | 1 +
t/trace_schema_validator/Makefile | 10 +++
.../trace_schema_validator.go | 78 +++
3 files changed, 89 insertions(+)
create mode 100644 t/trace_schema_validator/.gitignore
Signed-off-by: Josh Steadmon
---
ci/run-build-and-tests.sh | 5 +
1 file changed, 5 insertions(+)
diff --git a/ci/run-build-and-tests.sh b/ci/run-build-and-tests.sh
index cdd2913440..0707c90549 100755
--- a/ci/run-build-and-tests.sh
+++ b/ci/run-build-and-tests.sh
@@ -14,6 +14,8 @@ make
]:
https://json-schema.org/understanding-json-schema/reference/combining.html#allof
Signed-off-by: Josh Steadmon
---
t/trace_schema_validator/README | 23 +
t/trace_schema_validator/event_schema.json| 398 ++
t/trace_schema_validator/list_schema.json | 401
ince V1 of this series:
* dropped the documenation fix, as it can be submitted separately from
this series
* added JSON-array versions of the schema (currently unused)
* added the validation test to the CI suite
Josh Steadmon (3):
trace2: Add a JSON schema for trace2 events
trace2: add a schema
On 2019.06.12 15:18, Jeff King wrote:
> On Wed, Jun 12, 2019 at 09:23:41AM -0700, Josh Steadmon wrote:
>
> > The problem with the existing validators is that they expect each file to
> > be a
> > complete JSON entity, whereas the trace output is one object per line. Yo
On 2019.06.14 11:59, Jeff Hostetler wrote:
>
>
> On 6/11/2019 7:31 PM, Josh Steadmon wrote:
> > Define a JSON schema[1] that can be used to validate trace2 event
> > objects. This can be used to add regression tests to verify that the
> > event output format d
On 2019.06.12 11:00, Junio C Hamano wrote:
> Josh Steadmon writes:
>
> > Correct the api-trace2 documentation, which lists "signal" as an
> > expected field for the signal event type, but which actually outputs
> > "signo" as the field name.
>
On 2019.06.12 15:28, Ævar Arnfjörð Bjarmason wrote:
>
> On Wed, Jun 12 2019, Josh Steadmon wrote:
>
> > trace_schema_validator can be used to verify that trace2 event output
> > conforms to the expectations set by the API documentation and codified
> > in event_schema.
-off-by: Josh Steadmon
---
t/trace_schema_validator/.gitignore | 1 +
t/trace_schema_validator/Makefile | 10 +++
.../trace_schema_validator.go | 74 +++
3 files changed, 85 insertions(+)
create mode 100644 t/trace_schema_validator/.gitignore
]:
https://json-schema.org/understanding-json-schema/reference/combining.html#allof
Signed-off-by: Josh Steadmon
---
t/trace_schema_validator/event_schema.json | 398 +++
t/trace_schema_validator/strict_schema.json | 511
2 files changed, 909 insertions(+)
create
Correct the api-trace2 documentation, which lists "signal" as an
expected field for the signal event type, but which actually outputs
"signo" as the field name.
Signed-off-by: Josh Steadmon
---
Documentation/technical/api-trace2.txt | 2 +-
1 file changed, 1 insertion(+),
-schema.org/
Josh Steadmon (3):
trace2: correct trace2 field name documentation
trace2: Add a JSON schema for trace2 events
trace2: add a schema validator for trace2 events
Documentation/technical/api-trace2.txt| 2 +-
t/trace_schema_validator/.gitignore | 1 +
t
On 2019.05.09 07:22, Derrick Stolee via GitGitGadget wrote:
> This series replaces ds/commit-graph-file-v2, and I'm using the same
> gitgitgadget PR to continue the version numbers and hopefully make that
> clear. This is a slight modification on patches 1-11 from the incremental
> file format RFC
On 2019.05.07 18:30, Jeff King wrote:
> Just as we instruct Apache to pass through ASAN_OPTIONS (so that
> server-side Git programs it spawns will respect our options while
> running the tests), we should do the same with LSAN_OPTIONS. Otherwise
> trying to collect a list of leaks like:
>
> ex
Free the commit graph when verify_commit_graph_lite() reports an error.
Credit to OSS-Fuzz for finding this leak.
Signed-off-by: Josh Steadmon
---
commit-graph.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/commit-graph.c b/commit-graph.c
index 66865acbd7..4bce70d35c
On 2019.05.01 22:52, Jeff King wrote:
> On Thu, Apr 25, 2019 at 03:16:57PM -0700, Josh Steadmon wrote:
>
> > On 2019.04.25 19:15, Junio C Hamano wrote:
> > > * js/partial-clone-connectivity-check (2019-04-21) 1 commit
> > > (merged to 'next' on 2019
Just a couple typo fixes listed below:
On 2019.04.23 12:34, Emily Shaffer wrote:
[snip]
> +=== Implementation
> +
> +It's probably useful to do at least something besides printing out a string.
> +Let's start by having a look at everything we get.
> +
> +Modify your `cmd_psuh` implementation to d
On 2019.04.25 19:15, Junio C Hamano wrote:
> * js/partial-clone-connectivity-check (2019-04-21) 1 commit
> (merged to 'next' on 2019-04-25 at ebd8b4bffd)
> + clone: do faster object check for partial clones
>
> During an initial "git clone --depth=..." partial clone, it is
> pointless to spen
1 - 100 of 253 matches
Mail list logo
