On Thu, Jun 6, 2019 at 10:18 PM Emily Shaffer wrote:
> I grepped the Git source and found that we only provide a non-NULL
> "omitted" when someone calls "git rev-list --filter-print-omitted",
> which we verify with a simple test case for "blobs:none", in which
> case the "border" objects which
On Thu, Jun 6, 2019 at 9:08 PM Emily Shaffer wrote:
> [...]
> The tutorial covers a basic overview of the structs involved during
> revision walk, setting up a basic commit walk, setting up a basic
> all-object walk, and adding some configuration changes to both walk
> types. It intentionally does
Hi Junio,
On Thu, 6 Jun 2019, Junio C Hamano wrote:
> Johannes Schindelin writes:
>
> >> I vaguely recall seeing just one 'x' once. I think last time I had a
> >> problem with truncating st_ino, but that should be fixed in e66ceca94b
> >> (clone: fix colliding file detection on APFS, 2018-11-20)
Hello Everyone!
Here is a blog[1] update about my last week. I'll send my first patch
within this week. Be sure to check this blog to know about what
interesting happened during the last week ;)
Thanks
Rohit
[1]: https://rashiwal.me/2019/ignoring-spaces/
There's a regression in the completion since the introduction of
__gitcomp.
Go to any directory that doesn't contain a git repository, like /tmp.
Then type the following:
git checkout --
You will see nothing. That's because
`git checkout --git-completion-helper` fails when you run it outside a
Here is today's test coverage report.
Thanks,
-Stolee
[1] https://derrickstolee.github.io/git-test-coverage/reports/2019-06-06.htm
[2] https://derrickstolee.github.io/git-test-coverage/reports/2019-06-06.txt
---
pu 4f91bbec8a3cc2fff435fb3dbb0dfa5f9d223141
jch e1895a3c3b1fef6d1bc80251d0
Add the final steps needed and implement the walk loop itself. We add a
method walken_commit_walk() which performs the final setup to revision.c
and then iterates over commits from get_revision().
This basic walk only prints the subject line of each commit in the
history. It is nearly equivalent t
One requirement of the Git test suite is that all commands support '-h',
which is captured by parse_options(). In order to support this flag, add
a short usage text to walken.c and invoke parse_options().
With this change, we can now add cmd_walken to the builtins set and
expect tests to pass, so
Provide a demonstration of a revision walk which traverses all types of
object, not just commits. This type of revision walk is used for
operations such as creating packfiles and performing fetches or clones,
so it's useful to teach new developers how it works. For starters, only
demonstrate the un
In order to demonstrate how to create grep filters for revision walks,
filter the walk performed by cmd_walken() to print only commits which
are authored by someone with a gmail address.
This commit demonstrates how to append a grep pattern to a
rev_info.grep_filter, to teach new contributors how
It may be illuminating to see which objects were not included within a
given filter. This also demonstrates, since filter-spec "tree:1" is
used, that the 'omitted' list contains all objects which are omitted,
not just the first objects which were omitted - that is, it continues to
dereference omitt
Eventually, we will want a good place to initialize default variables
for use during our revision walk(s) in `git walken`. For now, there's
nothing to do here, but let's add the scaffolding so that it's easy to
tell where to put the setup later on.
Signed-off-by: Emily Shaffer
---
builtin/walken
Demonstrate how filter specs can be used when performing a revision walk
of all object types. In this case, tree depth is used. Contributors who
are following the revision walking tutorial will be encouraged to run
the revision walk with and without the filter in order to compare the
number of obje
Demonstrate that just like commit walks, object walks can have their
order reversed. Additionally, add verbose logging of objects encountered
in order to let contributors prove to themselves that the walk has
actually been reversed. With this commit, `git walken` becomes extremely
chatty - it's rec
The final installment in the tutorial about sorting revision walk
outputs. This commit reverses the commit list, so that we see newer
commits last (handy since we aren't using a pager).
It's important to note that rev->reverse needs to be set after
add_head_to_pending() or before setup_revisions()
For now, we have no configuration options we want to set up for
ourselves, but in the future we may need to. At the very least, we
should invoke git_default_config() for each config option; we will do so
inside of a skeleton config callback so that we know where to add
configuration handling later
Order the revision walk by author or commit dates, to demonstrate how to
apply topo_sort to a revision walk.
While following the tutorial, new contributors are guided to run a walk
with each sort and compare the results.
Signed-off-by: Emily Shaffer
---
builtin/walken.c | 5 +
1 file change
This patchset is NOT intended to be merged to the Git project!
This patchset should indicate what a contributor would generate by following the
MyFirstRevWalk tutorial.
I intend to push a feature branch with these patches to my own mirror of
Git on Github (github.com/nasamuffin/git/tree/revwalk).
`struct rev_info` is what's used by the struct itself.
`repo_init_revisions()` initializes the struct; then we need to set it
up for the walk we want to perform, which is done in
`final_rev_info_setup()`.
The most important step here is adding the first object we want to walk
to the pending array.
Begin to add scaffolding for `git walken`, a toy command which we will
teach to perform a number of revision walks, in order to demonstrate the
mechanics of revision walking for developers new to the Git project.
This commit is the beginning of an educational series which correspond
to the tutoria
Existing documentation on revision walks seems to be primarily intended
as a reference for those already familiar with the procedure. This
tutorial attempts to give an entry-level guide to a couple of bare-bones
revision walks so that new Git contributors can learn the concepts
without having to wa
On 6/6/2019 3:05 PM, Jeff King wrote:
> On Thu, Jun 06, 2019 at 03:00:00PM -0400, Eric Sunshine wrote:
>
>>> I can't reproduce the intermittent failure either on 2.21.0, or with
>>> v2.22.0-rc3.
>>
>> I can't reproduce it either on Jeff's Solaris box. Perhaps Jeff can
>> add "-v -x" to his automat
On Thu, Jun 6, 2019 at 5:37 PM Durant Schoon wrote:
> diff --git a/contrib/completion/git-completion.zsh
> b/contrib/completion/git-completion.zsh
> index 886bf95d1f594..0e63004e2613e 100644
> --- a/contrib/completion/git-completion.zsh
> +++ b/contrib/completion/git-completion.zsh
> @@ -11,8 +1
If you are looking for the latest version of this patchset, it is here:
https://public-inbox.org/git/20190601003603.90794-1-matv...@google.com/
But also has these interdiffs:
https://public-inbox.org/git/20190604234951.gb43...@comcast.net/#t
https://public-inbox.org/git/2019060347.gg4...@com
Hi Durant,
Just a couple of small things:
On Thu, Jun 06, 2019 at 09:38:54PM +, Durant Schoon wrote:
> When the code comment in the zsh completion suggests that this file
> should be copied to `~/.zsh`, many users might be misled to believe that
> this refers to a file location. But it refers
On Mon, Jun 03, 2019 at 05:51:28PM -0400, Jeff Hostetler wrote:
> Since we are assuming 'compose' is an AND operation, there may be an
> opportunity to short-cut some of this loop for blobs. That is, if the
> object is a blob and any filter rejects it, it is omitted, so we don't
> need to keep loo
"Derrick Stolee via GitGitGadget" writes:
> + if (stat(chain_name, &st)) {
> ...
> + if (st.st_size <= the_hash_algo->hexsz) {
> ...
> + fp = fopen(chain_name, "r");
> + free(chain_name);
> +
> + if (!fp)
> + return NULL;
Checking for size before opening is an inv
Hi Stolee,
We may be talking at cross-purposes.
On 06/06/2019 18:09, Derrick Stolee wrote:
On 6/6/2019 8:10 AM, Philip Oakley wrote:
Hi Derrick ,
On 03/06/2019 17:03, Derrick Stolee via GitGitGadget wrote:
From: Derrick Stolee
Add a basic description of commit-graph chains.
Not really your
Before this patch, "git branch" would put "(HEAD detached...)" and "(no
branch, rebasing...)" lines before all the other branches *in most
cases* and only because of the fact that "(" is a low codepoint. This
would not hold in the Chinese locale, which uses a full-width "(" symbol
(codepoint FF08).
When the code comment in the zsh completion suggests that this file
should be copied to `~/.zsh`, many users might be misled to believe that
this refers to a file location. But it refers to a directory, and won't
work when it is a file.
Let's just add a slash, to make it abundantly clear that this
"Derrick Stolee via GitGitGadget" writes:
> +static void load_oid_from_graph(struct commit_graph *g, int pos, struct
> object_id *oid)
> +{
> + uint32_t lex_index;
> +
> + if (!g)
> + BUG("NULL commit-graph");
> +
> + while (pos < g->num_commits_in_base)
> + g
On Monday, June 3, 2019 10:14 AM, I wrote:
> On Monday, June 3, 2019 9:50 AM, Johannes Schindelin wrote:
> > To: Randall S. Becker
> > Cc: 'Junio C Hamano' ; git@vger.kernel.org
> > Subject: RE: [ANNOUNCE] Git v2.22.0-rc2
> >
> > Hi Randall,
> >
> > On Sun, 2 Jun 2019, Randall S. Becker wrote:
> >
Here are the topics that have been cooking. Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'. The ones marked with '.' do not appear in any of
the integration branches, but I am still holding onto them.
On top of -rc3, the tip of 'master
On Thu, Jun 06, 2019 at 03:00:00PM -0400, Eric Sunshine wrote:
> > I can't reproduce the intermittent failure either on 2.21.0, or with
> > v2.22.0-rc3.
>
> I can't reproduce it either on Jeff's Solaris box. Perhaps Jeff can
> add "-v -x" to his automated build/test script in order to help
> diag
Yesterday while down a rabbit hole, I discovered an interesting thing
about the 'omitted' object in many filters in
list-objects-filter-options.h. It appears that when we call
list-objects.h:traverse_commit_list_filtered() with a non-NULL
'omitted' argument, we still perform a walk of all objects
On Thu, Jun 6, 2019 at 1:35 PM Jeff King wrote:
> On Thu, Jun 06, 2019 at 01:18:01PM -0400, Eric Sunshine wrote:
> > > > not ok 12 - check normal git operations: twelve packs
> >
> > Jeff Walton reported this to me privately. I'm not familiar with this
> > code and don't have time presently to inv
On 06/06/2019 15:15, Derrick Stolee via GitGitGadget wrote:
> From: Derrick Stolee
>
> The split commit-graph feature is now fully implemented, but needs
> some more run-time configurability. Allow direct callers to 'git
> commit-graph write --split' to specify the values used in the
> merge s
On Wed, Jun 5, 2019 at 10:20 PM Taylor Blau wrote:
>
> Hi Miguel,
>
> On Tue, Jun 04, 2019 at 12:48:14AM +0200, Miguel Ojeda wrote:
> > The ForEachMacros list can reasonably be generated grepping
> > the C source code for macros with 'for_each' in their name.
> >
> > Taken almost verbatim from the
On Thu, Jun 06, 2019 at 01:18:01PM -0400, Eric Sunshine wrote:
> > > not ok 12 - check normal git operations: twelve packs
> > > #
> > > # midx_git_two_modes "rev-list --objects --all" &&
> > > # midx_git_two_modes "log --raw" &&
> > > #
[forwarding to the Git list]
On Sun, Jun 2, 2019 at 6:23 AM Jeffrey Walton wrote:
> On Sun, Jun 2, 2019 at 5:09 AM Jeffrey Walton wrote:
> > I'm catching a self test failure on Solaris 11.3. Git 2.21 from sources.
> >
> > ok 8 - check normal git operations: two packs
> > ok 9 - add more packs
>
On 6/6/2019 8:10 AM, Philip Oakley wrote:
> Hi Derrick ,
>
> On 03/06/2019 17:03, Derrick Stolee via GitGitGadget wrote:
>> From: Derrick Stolee
>>
>> Add a basic description of commit-graph chains.
> Not really your problem, but I did notice that we don't actually explain what
> we mean here by
Is this a spelling nit?
On 06/06/2019 15:15, Derrick Stolee via GitGitGadget wrote:
3. When writing a new commit-graph chain based on a commit-graph file
in another object directory, do not allow success if the base file
has of the name "commit-graph" instead of
"commit-graphs/graoh-{
"Derrick Stolee via GitGitGadget" writes:
> This is based on ds/commit-graph-write-refactor.
>
> Thanks, -Stolee
>
> [1]
> https://github.com/git/git/commit/43d356180556180b4ef6ac232a14498a5bb2b446
> commit-graph write: don't die if the existing graph is corrupt
>
> Derrick Stolee (14):
> comm
Johannes Schindelin writes:
>> I vaguely recall seeing just one 'x' once. I think last time I had a
>> problem with truncating st_ino, but that should be fixed in e66ceca94b
>> (clone: fix colliding file detection on APFS, 2018-11-20). So no idea
>> how this happens again.
>
> Good catch. I think
Derrick Stolee writes:
>> - perhaps we may eventually want to allow end users (via their
>>~/.gitconfig) and system administrators (via /etc/gitconfig)
>>define such a macro setting (e.g. setting macro.largeRepoSetting
>>sets pack.usebitmaps=true, pack.useSpars=true, etc.) *after* we
spelling nit in the commit message..
On 06/06/2019 15:15, Derrick Stolee via GitGitGadget wrote:
* graph position: the posiiton within the concatenated order
s/posiiton/position/
--
Philip
Hello,
I have a problem in my centos 7 machine. I am compiling git 2.18 from source.
When I use git svn it works fine with the subversion that comes with the
system. However, if I have a different subversion in my path:
PATH=/home/tools/sw/subversion/svn-1.8.8/rhel7-x86_64/bin:$PATH
LD_LIBRARY
From: Derrick Stolee
In an environment like a fork network, it is helpful to have a
commit-graph chain that spans both the base repo and the fork repo. The
fork is usually a small set of data on top of the large repo, but
sometimes the fork is much larger. For example, git-for-windows/git has
alm
From: Derrick Stolee
The split commit-graph feature is now fully implemented, but needs
some more run-time configurability. Allow direct callers to 'git
commit-graph write --split' to specify the values used in the
merge strategy and the expire time.
Update the documentation to specify these val
From: Derrick Stolee
Extend write_commit_graph() to write a commit-graph chain when given the
COMMIT_GRAPH_SPLIT flag.
This implementation is purposefully simplistic in how it creates a new
chain. The commits not already in the chain are added to a new tip
commit-graph file.
Much of the logic a
From: Derrick Stolee
Add a new "--split" option to the 'git commit-graph write' subcommand. This
option allows the optional behavior of writing a commit-graph chain.
The current behavior will add a tip commit-graph containing any commits that
are not in the existing commit-graph or commit-graph
From: Derrick Stolee
Prepare the logic for reading a chain of commit-graphs.
First, look for a file at $OBJDIR/info/commit-graph. If it exists,
then use that file and stop.
Next, look for the chain file at $OBJDIR/info/commit-graphs/commit-graph-chain.
If this file exists, then load the hash va
From: Derrick Stolee
To prepare for a chain of commit-graph files, augment the
commit_graph struct to point to a base commit_graph. As we load
commits from the graph, we may actually want to read from a base
file according to the graph position.
The "graph position" of a commit is given by conca
From: Derrick Stolee
The number of chunks in a commit-graph file can change depending on
whether we need the Extra Edges Chunk. We are going to add more optional
chunks, and it will be helpful to rearrange this logic around the chunk
count before doing so.
Specifically, we need to finalize the n
From: Derrick Stolee
If we wrote a commit-graph chain, we only modified the tip file in
the chain. It is valuable to verify what we wrote, but not waste
time checking files we did not write.
Add a '--shallow' option to the 'git commit-graph verify' subcommand
and check that it does not read the
From: Derrick Stolee
As we merge commit-graph files in a commit-graph chain, we should clean
up the files that are no longer used.
This change introduces an 'expiry_window' value to the context, which is
always zero (for now). We then check the modified time of each
graph-{hash}.graph file in th
From: Derrick Stolee
If we write a commit-graph file without the split option, then
we write to $OBJDIR/info/commit-graph and start to ignore
the chains in $OBJDIR/info/commit-graphs/.
Unlink the commit-graph-chain file and expire the graph-{hash}.graph
files in $OBJDIR/info/commit-graphs/ durin
From: Derrick Stolee
When searching for a commit in a commit-graph chain of G graphs with N
commits, the search takes O(G log N) time. If we always add a new tip
graph with every write, the linear G term will start to dominate and
slow the lookup process.
To keep lookups fast, but also keep most
From: Derrick Stolee
To quickly verify a commit-graph chain is valid on load, we will
read from the new "Base Graphs Chunk" of each file in the chain.
This will prevent accidentally loading incorrect data from manually
editing the commit-graph-chain file or renaming graph-{hash}.graph
files.
The
From: Derrick Stolee
Add a basic description of commit-graph chains. More details about the
feature will be added as we add functionality. This introduction gives a
high-level overview to the goals of the feature and the basic layout of
commit-graph chains.
Signed-off-by: Derrick Stolee
---
Do
From: Derrick Stolee
The helper function commit_compare() actually compares object_id
structs, not commits. A future change to commit-graph.c will need
to sort commit structs, so rename this function in advance.
Signed-off-by: Derrick Stolee
---
commit-graph.c | 4 ++--
1 file changed, 2 inser
This version is now ready for review.
The commit-graph is a valuable performance feature for repos with large
commit histories, but suffers from the same problem as git repack: it
rewrites the entire file every time. This can be slow when there are
millions of commits, especially after we stopped
Hi,
On Wed, 5 Jun 2019, Nickolai Belakovski wrote:
> On Thu, May 30, 2019 at 5:20 PM Junio C Hamano wrote:
> >
> > * nb/branch-show-other-worktrees-head (2019-05-07) 3 commits
> > - branch: add worktree info on verbose output
> > - branch: update output to include worktree info
> > - ref-filt
Hi Duy,
On Wed, 5 Jun 2019, Duy Nguyen wrote:
> On Wed, Jun 5, 2019 at 6:27 PM Jeff King wrote:
> >
> > On Wed, Jun 05, 2019 at 10:12:12AM +0200, Johannes Schindelin wrote:
> >
> > > This fails on macOS, in t5601, both in our osx-clang and osx-gcc jobs, as
> > > well as in the StaticAnalysis job
Hi Denton,
On Wed, 5 Jun 2019, Denton Liu wrote:
> Currently, if a user wishes to have individual settings per branch, they
> are required to manually keep track of the settings in their head and
> manually set the options on the command-line or change the config at
> each branch.
>
> Teach confi
Hi Denton,
On Wed, 5 Jun 2019, Denton Liu wrote:
> Thanks for the review, Johannes. I think it's a good idea to add another
> alias for `-p` so included that suggestion. Also, while I was at it, I
> found a typo so I fixed that too.
>
> Changes since v1:
>
> * s/loud-merge/loud-rebase/
> * Add `-
Commit 0e5ed7cca3 wrongly changed the extension of the bash script
to .zsh. The extension doesn't really matter, but it confuses people.
I've changed the text to make it clear that your zsh script goes to
~/.zsh/_git, and the bash script to ~/.git-completion.bash (or wherever
you want).
Also, upd
On 6/5/2019 4:39 PM, Junio C Hamano wrote:
> "Derrick Stolee via GitGitGadget" writes:
>
>> This patch series includes a few new config options we created to speed up
>> certain critical commands in VFS for Git. On their own, they would
>> contribute little value as it is hard to discover new con
Hi Derrick ,
On 03/06/2019 17:03, Derrick Stolee via GitGitGadget wrote:
From: Derrick Stolee
Add a basic description of commit-graph chains.
Not really your problem, but I did notice that we don't actually explain
what we mean here by a commit graph (before we start chaining them), and
the
...
ATTN:
Get up, take a step of faith to achieve your dreams and aspiration.
We offer loans to companies and individuals’ bodies at a negotiable or
modifiable interest rate.
Contact lim3...@foxmail.com for more details.
LOAN THAT CHANGES LIFE
a reputable, legal lending private firm
Publicity
On Wed, Jun 5, 2019 at 10:30 PM Ingo Wolf wrote:
>
> Am 05.06.2019 um 12:17 schrieb Duy Nguyen:
> > "worktree add --no-checkout --keep-worktree" is quite readable
>
> worktree add --no-checkout -f (orce)
>
> I've expected to work on an not empty directory
Yeah --force works too. Not sure how it i
--
Hello Dear,
Greetings and how is your day going?
I am Miss Noora Abdul from South Sudan and I am also an orphan and I
will like to discuss something very urgent with you when I hear from
you.
Regards
Noora Abdul
--
72 matches
Mail list logo
