Looks like the issue appeared after updating git from brew.
I tried it on a different mac laptop, git 2.18 still used English, but
after updating to 2.19 it started using secondary language.
A quick search revealed that brew changed how it builds git recently.
I think, it just didn't include i18n
Signed-off-by: Tao Qingyun
---
refs/refs-internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/refs/refs-internal.h b/refs/refs-internal.h
index 04425d6d1e..1fe5a7a22f 100644
--- a/refs/refs-internal.h
+++ b/refs/refs-internal.h
@@ -282,7 +282,7 @@ int refs_rename_ref_ava
Tried what you suggested - it seems, it only ignores English. In you
example, with Swedish as primary and German as secondary, git uses
Swedish.
With more that one secondary language, the one with a higher priority
is being used, as expected. I also tried using non-generic English
(English-UK and
On Fri, Sep 14, 2018 at 10:47 AM Junio C Hamano wrote:
>
> Junio C Hamano writes:
>
> > Break line after pipe "|", not before, and lose the backslash. You
> > do not need to over-indent the command on the downstream of the
> > pipe, i.e.
> >
> > awk ... |
> > xargs -n1 git -C ... &&
This fixes various places where the ordering was obviously wrong and it
was either related to other patches in this patchset or was easy
find with grep.
Signed-off-by: Matthew DeVore
---
t/t-basic.sh | 2 +-
t/t0021-conversion.sh | 4 +--
t/t1300-conf
Where ever there was code in the tests like this:
foo \
| bar
such as:
git rev-list HEAD \
| grep $COMMIT
replace it with this:
foo |
bar
And add a blank line before and after the pipe where it aids readability
(it usually does).
As requested in:
https://public-inbox.org/git/xmqqmuskas3a@gitster-ct.c.googlers.com/
this patchset corrects ordering of test_cmp arguments and | placement.
The request didn't explicitly state whether all the tests should be cleaned up,
but I did clean up as much as I reasonably could.
The l
> There's also the nascent "don't fetch all the blobs" work-in-progress
> clone mode which might be of interest to you:
> https://blog.github.com/2018-09-10-highlights-from-git-2-19/#partial-clones
Yes! I've been pretty excited about this functionality. It drives a
lot of GVFS/VFS for Git under th
At one time, the POSIX standard required the type used to represent
a thread handle (pthread_t) be an arithmetic type. This is no longer
the case, probably because different platforms used to regularly
ignore that requirement. For example, on cygwin a pthread_t is a
pointer to a structure (a qui
Signed-off-by: Ramsay Jones
---
Hi Derrick,
If you need to re-roll your 'ds/multi-pack-verify' branch, could you
please squash this into the relevant patch (commit 64cbf3df21,
"multi-pack-index: add 'verify' verb", 2018-09-13).
[noticed by sparse].
Thanks.
ATB,
Ramsay Jones
midx.c | 2 +-
On 08.09.18 01:38, Eric Sunshine wrote:
On Fri, Sep 7, 2018 at 6:44 PM Tim Schumacher wrote:
Introduce a testing suite that is dedicated to aliases.
For now, check only if nested aliases work and if looping
aliases are detected successfully.
The looping aliases check for mixed execution is the
Junio C Hamano writes:
> Ben Peart writes:
>
>> diff --git a/t/test-lib.sh b/t/test-lib.sh
>> index 653688c067..397eb71578 100644
>> --- a/t/test-lib.sh
>> +++ b/t/test-lib.sh
>> @@ -134,9 +134,9 @@ export EDITOR
>> GIT_TRACE_BARE=1
>> export GIT_TRACE_BARE
>>
>> -if test -n "${TEST_GIT_INDE
Ben Peart writes:
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 653688c067..397eb71578 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -134,9 +134,9 @@ export EDITOR
> GIT_TRACE_BARE=1
> export GIT_TRACE_BARE
>
> -if test -n "${TEST_GIT_INDEX_VERSION:+isset}"
> +if test -n "${G
On Fri, Sep 14 2018, Niko Dzhus wrote:
> It doesn't use English when other language is available as a secondary
> language.
>
> Reproducing:
>
> 1. Open "Language & Region" in macos settings
> 2. In "Preferred languages" box, set English as a primary language.
> 3. Add another language, that gi
Here are the topics that have been cooking. Commits prefixed with
'-' are only in 'pu' (proposed updates) while commits prefixed with
'+' are in 'next'. The ones marked with '.' do not appear in any of
the integration branches, but I am still holding onto them.
The tip of 'next' hasn't been rewo
Jonathan Nieder writes:
> Maybe something like:
>
> preload-index: use git_env_bool() not getenv() for customization
>
> GIT_FORCE_PRELOAD_TEST is only checked for presence by using getenv().
> Use git_env_bool() instead so that GIT_FORCE_PRELOAD_TEST=false can
> work as e
On Fri, Sep 14 2018, John Austin wrote:
> - improvements to large file management (mostly solved by LFS, GVFS)
There's also the nascent "don't fetch all the blobs" work-in-progress
clone mode which might be of interest to you:
https://blog.github.com/2018-09-10-highlights-from-git-2-19/#partia
Hey Taylor,
Great to have your support! I think LFS has done a great job so far
solving the large file issue. I've been working myself on strategies
for handling binary conflicts, and particularly how to do it in a
git-friendly way (ie. avoiding as much centralization as possible and
playing into
Hey Taylor,
Great to have your support! I think LFS has done a great job so far
solving the large file issue. I've been working myself on strategies
for handling binary conflicts, and particularly how to do it in a
git-friendly way (ie. avoiding as much centralization as possible and
playing into
Ben Peart wrote:
> Subject: preload-index: teach GIT_FORCE_PRELOAD_TEST to take a boolean
Reading this subject line alone (e.g. in "git log --oneline" output),
it's not obvious to me what this patch will do.
What behavior change does it make / what will it make newly possible?
Maybe something l
Hi,
Ben Peart wrote:
> Subject: correct typo/spelling error in t/README
nit: what is the difference between a typo/spelling error and another
kind of spelling error? Maybe this could be something like
t/README: correct spelling of "uncommon"
which makes it crystal clear what the patch
Rename TEST_GIT_INDEX_VERSION to GIT_TEST_INDEX_VERSION for consistency with
the other GIT_TEST_ special setups and properly document its use.
Add logic in t/test-lib.sh to give a warning when the old variable is set to
let people know they need to update their environment to use the new
variable.
Rename GIT_FSMONITOR_TEST to GIT_TEST_FSMONITOR for consistency with the
other GIT_TEST_ special setups and properly document its use.
Add logic in t/test-lib.sh to give a warning when the old variable is set to
let people know they need to update their environment to use the new
variable.
Signed
Rename GIT_FORCE_PRELOAD_TEST to GIT_TEST_PRELOAD_INDEX for consistency with
the other GIT_TEST_ special setups and properly document its use.
Add logic in t/test-lib.sh to give a warning when the old variable is set to
let people know they need to update their environment to use the new
variable.
Changes this round are to use Junio's more elegant script to test and warn
about using old variables and munging which changes are in which commit.
Base Ref: v2.19.0
Web-Diff: https://github.com/benpeart/git/commit/79d62d39e4
Checkout: git fetch https://github.com/benpeart/git git-test-cleanup-v2
Correct a spelling error in the documentation for GIT_TEST_OE_DELTA_SIZE
Signed-off-by: Ben Peart
---
t/README | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/README b/t/README
index 9028b47d92..56a417439c 100644
--- a/t/README
+++ b/t/README
@@ -315,7 +315,7 @@ packs on de
Teach GIT_FORCE_PRELOAD_TEST to take a boolean to turn on or off this test
feature instead of simply testing for existance.
Signed-off-by: Ben Peart
---
preload-index.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/preload-index.c b/preload-index.c
index 71cd2437a3..0a4e2
On Fri, Sep 14, 2018 at 10:23 AM Junio C Hamano wrote:
>
> Matthew DeVore writes:
>
> > Signed-off-by: Matthew DeVore
> >
> > fixup of 6defd70de
>
> That's probably meant to go below "---".
>
That line shouldn't be there at all, sorry!
It came from me putting that text in a commit which was me
It doesn't use English when other language is available as a secondary language.
Reproducing:
1. Open "Language & Region" in macos settings
2. In "Preferred languages" box, set English as a primary language.
3. Add another language, that git is translated to, as a secondary
language, for example,
Hi Sebastian,
On Wed, 5 Sep 2018, Sebastian Schuberth wrote:
> On 9/3/2018 11:10 PM, Johannes Schindelin via GitGitGadget wrote:
>
> > +if test -n "$TRAVIS_COMMIT"
> > +then
> > + # We are running within Travis CI
>
> Personally, I'd find a check like
>
> if test "$TRAVIS" = "true"
>
> more
Hi Peff,
On Wed, 5 Sep 2018, Jeff King wrote:
> On Wed, Sep 05, 2018 at 02:38:34PM -0400, Eric Sunshine wrote:
>
> > On Wed, Sep 5, 2018 at 8:39 AM Johannes Schindelin
> > wrote:
> > > So let's hear some ideas how to improve the situation, m'kay? Just
> > > as a reminder, this is the problem I
Hi John,
On Fri, Sep 14, 2018 at 10:55:39AM -0700, John Austin wrote:
> Is anyone interested in contributing/offering insights? I suspect most
> folks here are git users as is, but if you know someone stuck on
> Perforce, I'd love to chat with them!
I'm thrilled that other folks are interested in
Hi Eric,
On Wed, 5 Sep 2018, Eric Sunshine wrote:
> On Wed, Sep 5, 2018 at 8:39 AM Johannes Schindelin
> wrote:
> > So let's hear some ideas how to improve the situation, m'kay? Just as
> > a reminder, this is the problem I want to solve: I want to run the
> > tests in a light-weight manner, wi
Hi Luke,
On Wed, 5 Sep 2018, Luke Diamand wrote:
> On 5 September 2018 at 13:39, Johannes Schindelin
> wrote:
> >
> > On Wed, 5 Sep 2018, Luke Diamand wrote:
> >
> >> On 4 September 2018 at 12:09, Johannes Schindelin
> >> wrote:
> >> >
> >> > On Tue, 4 Sep 2018, Eric Sunshine wrote:
> >> >
> >>
On Fri, Sep 14, 2018 at 10:45 AM Tao Qingyun wrote:
> refs: docstirng typo
Typo: s/docstirng/docstring/
> ---
Please sign-off your patch. See Documentation/SubmittingPatches.
Thanks.
Hi Zachary,
On Fri, Sep 14, 2018 at 09:43:43AM -0500, Zachary Bryant wrote:
> When the installer asks for a default editor, it defaults to vim and
> when I select either VS Code option, it won't allow me to proceed.
It sounds like this is an issue pertaining to Git for Windows, which
uses an issu
Hi Mikkel,
On Fri, Sep 14, 2018 at 02:31:04PM +0200, Mikkel Hofstedt Juul wrote:
> See title
> in sentence:
> ...invocations of git add, packing refs, pruning reflog, rerere
> metadata or stale working trees.
I think that 'rerere' in this case, is correct, since it refers
bookkeeping from the 'gi
Ben Peart writes:
> The difference here is that core.fsmonitor isn't a boolean value. It
> is a string to a command that is executed so it can't be moved over to
> get_env_bool().
Ah, of course ;-)
Then please take the following as a review comment for 4/4; checking
if each getenv(VAR) should
Hey all,
I've been putting together a working group for game studios wanting to
use Git. There are a couple of blockers that keep most game and media
companies on Perforce or others, but most would love to use git if it
were feasible.
The biggest tasks I'd like to tackle are:
- improvements to l
On 9/14/2018 1:15 PM, Junio C Hamano wrote:
Ben Peart writes:
diff --git a/config.c b/config.c
index 3461993f0a..3555c63f28 100644
--- a/config.c
+++ b/config.c
@@ -2278,7 +2278,7 @@ int git_config_get_max_percent_split_change(void)
int git_config_get_fsmonitor(void)
{
if (git_c
Junio C Hamano writes:
>> diff --git a/t/t5616-partial-clone.sh b/t/t5616-partial-clone.sh
>> index bbbe7537d..8eeb85fbc 100755
>> --- a/t/t5616-partial-clone.sh
>> +++ b/t/t5616-partial-clone.sh
>> ...
>
> Break line after pipe "|", not before, and lose the backslash. You
> do not need to over-
Matthew DeVore writes:
> diff --git a/list-objects-filter-options.c b/list-objects-filter-options.c
> index c0e2bd6a0..14f251de4 100644
> --- a/list-objects-filter-options.c
> +++ b/list-objects-filter-options.c
> @@ -50,6 +50,20 @@ static int gently_parse_list_objects_filter(
>
Matthew DeVore writes:
> Currently, list-objects.c incorrectly treats all root trees of commits
> as USER_GIVEN. Also, it would be easier to mark objects that are
> non-user-given instead of user-given, since the places in the code
> where we access an object through a reference are more obvious
Ben Peart writes:
> diff --git a/config.c b/config.c
> index 3461993f0a..3555c63f28 100644
> --- a/config.c
> +++ b/config.c
> @@ -2278,7 +2278,7 @@ int git_config_get_max_percent_split_change(void)
> int git_config_get_fsmonitor(void)
> {
> if (git_config_get_pathname("core.fsmonitor", &
Junio C Hamano writes:
> Ben Peart writes:
>
>> +if test -n "$GIT_FSMONITOR_TEST"
>> +then
>> +if test -n "$GIT_TEST_FSMONITOR"
>> +then
>> +echo "warning: the GIT_FSMONITOR_TEST variable has been renamed
>> to GIT_TEST_FSMONITOR"
>> +else
>> +echo "error: th
Ben Peart writes:
> +if test -n "$GIT_FSMONITOR_TEST"
> +then
> + if test -n "$GIT_TEST_FSMONITOR"
> + then
> + echo "warning: the GIT_FSMONITOR_TEST variable has been renamed
> to GIT_TEST_FSMONITOR"
> + else
> + echo "error: the GIT_FSMONITOR_TEST variable h
Shulhan writes:
> if source is run successfully before I know the patch was correct, as
> the "t/README" said,
>
> Running Tests
> -
>
> The easiest way to run tests is to say "make". This runs all
> the tests.
t/README says that it is sufficient to run "make" to perform tes
Ben Peart writes:
>> I think it is OK to make it error only if the old one is set without
>> the new one. Then people can have _both_ set to the same value
>> during the period in which the topic sails through pu down to next
>> down to master, after seeing an failure once while building and
>>
Junio C Hamano wrote:
> Jonathan Nieder writes:
>>> I think though that instead of doing setlocale() it would be better to
>>> pass some flag saying we're operating in a machine-readable mode, and
>>> then we'd (as part of the protocol defintion) say we're going to emit
>>> GIT_ERR_UPLOAD_ARCHIVE
Jonathan Nieder writes:
>> I think though that instead of doing setlocale() it would be better to
>> pass some flag saying we're operating in a machine-readable mode, and
>> then we'd (as part of the protocol defintion) say we're going to emit
>> GIT_ERR_UPLOAD_ARCHIVE_EXPECTED_DELIM_PACKET or wh
Problem signature:
Problem Event Name: APPCRASH
Application Name: git.exe
Application Version: 2.19.0.1
Application Timestamp:5b980bc7
Fault Module Name:ntdll.dll
Fault Module Version: 6.1.7601.24117
Fault Module Timestamp: 5add228d
Exception Code: c00
When adding new remote name with empty string, git will print the
following error message,
fatal: '' is not a valid remote name\n
But when removing remote name with empty string as input, git shows the
empty string without quote,
fatal: No such remote: \n
To make these error messages consis
---
refs/refs-internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/refs/refs-internal.h b/refs/refs-internal.h
index 04425d6d1e..1fe5a7a22f 100644
--- a/refs/refs-internal.h
+++ b/refs/refs-internal.h
@@ -282,7 +282,7 @@ int refs_rename_ref_available(struct ref_store *ref
Hi,
I received the notification to update to the latest 2.19.0.
When the installer asks for a default editor, it defaults to vim and
when I select either VS Code option, it won't allow me to proceed.
I've reproduced this on two machines.
VS Code is up to date on both machines.
Both machines:
Wi
Rename GIT_FSMONITOR_TEST to GIT_TEST_FSMONITOR for consistency with the
other GIT_TEST_ special setups and properly document its use.
Add logic in t/test-lib.sh to give an error when the old variable is set to
let people know they need to update their environment to use the new
variable. If the n
Rename TEST_GIT_INDEX_VERSION to GIT_TEST_INDEX_VERSION for consistency with
the other GIT_TEST_ special setups and properly document its use.
Add logic in t/test-lib.sh to give an error when the old variable is set to
let people know they need to update their environment to use the new
variable.
Rename GIT_FORCE_PRELOAD_TEST to GIT_TEST_PRELOAD_INDEX for consistency with
the other GIT_TEST_ special setups and properly document its use.
Add logic in t/test-lib.sh to give an error when the old variable is set to
let people know they need to update their environment to use the new
variable.
Correct a spelling error in the documentation for GIT_TEST_OE_DELTA_SIZE
Signed-off-by: Ben Peart
---
t/README | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/README b/t/README
index 9028b47d92..56a417439c 100644
--- a/t/README
+++ b/t/README
@@ -315,7 +315,7 @@ packs on de
As documented in t/README, the whole test suite can be run to test some
special features that cannot be easily covered by a few specific test cases.
Not all of these that exist in the code have been named consistantly and
documented in r/README which leads to a discoverability problem. Update
sev
On Fri, Sep 14 2018, Jonathan Nieder wrote:
> Ævar Arnfjörð Bjarmason wrote:
>> On Wed, Sep 12 2018, Stefan Beller wrote:
>
>>> Would asking for a setlocale() on the server side be an unreasonable
>>> feature request for the capabilities (in a follow up patch, and then not
>>> just for archive b
On 9/13/2018 6:08 PM, Junio C Hamano wrote:
Thomas Gummerer writes:
Thanks, I do think this is a good idea. I do however share Ævar's
concern in https://public-inbox.org/git/87h8itkz2h@evledraar.gmail.com/.
I have TEST_GIT_INDEX_VERSION=4 set in my config.mak since quite a
long time, a
On 9/13/2018 2:54 PM, Ævar Arnfjörð Bjarmason wrote:
On Thu, Sep 13 2018, Ben Peart wrote:
diff --git a/config.c b/config.c
index 3461993f0a..3555c63f28 100644
--- a/config.c
+++ b/config.c
@@ -2278,7 +2278,7 @@ int git_config_get_max_percent_split_change(void)
int git_config_get_fsmonito
retry -- plain text mode
-- Forwarded message -
From: Mikkel Hofstedt Juul
Date: Fri, 14 Sep 2018 at 14:28
Subject: spelling mistake 'rerere' on docs/git-gc
To:
Hi
See title
in sentence:
...invocations of git add, packing refs, pruning reflog, rerere
metadata or stale working
On Thu, Sep 13, 2018 at 1:27 PM Ævar Arnfjörð Bjarmason
wrote:
>
>
> On Tue, Sep 11 2018, Michal Novotny wrote:
>
> > I need to emulate git tag --merged with very old git 1.8.3.1. Is that
> > somehow possible?
> > I am looking for a bash function that would take what git 1.8.3.1
> > offers and ret
On Thu, 13 Sep 2018 14:51:56 -0700
Junio C Hamano wrote:
> Shulhan writes:
>
> > When adding new remote name with empty string, git will print the
> > following error message,
> >
> > fatal: '' is not a valid remote name\n
> >
> > But when removing remote name with empty string as input, git
65 matches
Mail list logo
