On Thu, Feb 18, 2016 at 11:46 PM, Jeff King wrote:
> To trigger a credential fetch in actual use, you have to clone over
> http. See the credential tests in t5550, for example.
>
I'll look at these.
>> As for how to whitelist config to share with the submodule I am really
>> not 100% sure, since
On Thu, Feb 18, 2016 at 11:29:09PM -0800, Jacob Keller wrote:
> I would prefer to either.. blacklist stuff like core.worktree, or
> whitelist a bunch of stuff that makes sense. In this case though, I
> would prefer to have an explicit test of credential.helper, but I
> don't know if any of our tes
Junio C Hamano writes:
> Deciding what the 'safe' subset is must be done with a lot of
> thinking by people who intimately know what implications it has to
> ban each feature. I do not think it would be a good fit for a
> project to give to a relatively new participant to the Git project.
I hav
On Thu, Feb 18, 2016 at 8:30 PM, Jeff King wrote:
> On Thu, Feb 18, 2016 at 05:15:54PM -0800, Jacob Keller wrote:
>
>> I am looking at this more and I am stuck as to how best to provide a
>> test case.
>>
>> I think the problem as stated above is pretty straight forward, we
>> just want to stop cl
Duy Nguyen writes:
> On Thu, Feb 18, 2016 at 1:58 AM, Matthieu Moy
> wrote:
>> Feel free to start writting an idea for
>> http://git.github.io/SoC-2016-Ideas/. It'd be nice to have a few more
>> ideas before Friday. We can polish them later if needed.
>
> Probably too late now, anyway..
It's st
Hello everyone,
I'm Mehul Jain. I'm looking for participating in GSoC 2016.
I've started work on a Microproject" Teach git pull --rebase the
--no-autostash" option. While looking at Git's source code I have made
following observation: In the pull.c file
1. git_config_get_bool( , ) search in the
Hi all, especially active Git for Windows contributors,
I would like to ask you for (constructive ;-)) feedback on
https://github.com/git-for-windows/git/pull/661
I personally find it very important to keep it fun and pleasant to
contribute to Git for Windows anf hope that the updated Co
On Thu, Feb 18, 2016 at 05:15:54PM -0800, Jacob Keller wrote:
> I am looking at this more and I am stuck as to how best to provide a
> test case.
>
> I think the problem as stated above is pretty straight forward, we
> just want to stop clearing GIT_CONFIG_PARAMETERS but I can't find an
> easy wa
On Fri, Feb 19, 2016 at 10:20 AM, Junio C Hamano wrote:
> Duy Nguyen writes:
>
>> Probably too late now, anyway.. with David's multiple ref backend
>> work, we could have a third, no-dependency backend. We can use index
>> format to store refs. Then we can avoid case-sensitivity issue with
>> fil
Duy Nguyen writes:
> Probably too late now, anyway.. with David's multiple ref backend
> work, we could have a third, no-dependency backend. We can use index
> format to store refs. Then we can avoid case-sensitivity issue with
> filesystems.
I'd actually vote for a ref backend that is based on
Stefan Beller writes:
> On Thu, Feb 18, 2016 at 3:20 PM, Junio C Hamano wrote:
>> Stefan Beller writes:
>>
>>> On Thu, Feb 18, 2016 at 3:12 PM, Stefan Beller wrote:
> Unless you count "I want to write differently from what was
> suggested" is a desirable thing to do, I do not see a poi
On Thu, Feb 18, 2016 at 1:58 AM, Matthieu Moy
wrote:
> Feel free to start writting an idea for
> http://git.github.io/SoC-2016-Ideas/. It'd be nice to have a few more
> ideas before Friday. We can polish them later if needed.
Probably too late now, anyway.. with David's multiple ref backend
work,
On Fri, Feb 19, 2016 at 3:23 AM, David Turner wrote:
>> > +static int read_per_worktree_ref(const char *submodule, const char
>> > *refname,
>> > +struct MDB_val *val, int
>> > *needs_free)
>>
>> From what I read, I suspect these _per_worktree functions will be
>> ident
On Mon, Feb 15, 2016 at 3:15 AM, Duy Nguyen wrote:
> On Mon, Feb 15, 2016 at 12:52:26AM -0500, Eric Sunshine wrote:
>> Yes, dropping 'const' was implied. I didn't examine it too deeply, but
>> it did not appear as if there would be any major fallout from dropping
>> 'const'. It feels a bit cleaner
On Sun, Feb 7, 2016 at 7:44 PM, Jacob Keller wrote:
> On Sun, Feb 7, 2016 at 5:48 AM, Marc Strapetz
> wrote:
>> On 07.02.2016 05:41, Jacob Keller wrote:
>>>
>>> On Wed, Feb 3, 2016 at 3:44 PM, Jacob Keller
>>> wrote:
Ok so I am not sure we even really need to use "-c" option in
g
Just pass it along to "git submodule update", which may pick reasonable
defaults if you don't specify an explicit number.
Signed-off-by: Stefan Beller
Signed-off-by: Junio C Hamano
---
Documentation/git-clone.txt | 6 +-
builtin/clone.c | 19 +--
t/t7406-submodu
Adhere to the common coding style of Git and not check explicitly
for NULL throughout the file. There are still other occurrences in the
code base but that is usually inside of conditions with side effects.
Signed-off-by: Stefan Beller
Signed-off-by: Junio C Hamano
---
submodule-config.c | 6 ++
Currently submodule..update is only handled by git-submodule.sh.
C code will start to need to make use of that value as more of the
functionality of git-submodule.sh moves into library code in C.
Add the update field to 'struct submodule' and populate it so it can
be read as sm->update or from sm-
Thanks Junio, for the discussion about the last issue!
I changed to check for '!' in the code as well as addressing the
cleanup afterwards.
Thanks,
Stefan
Interdiff to v11(! not v12)
diff --git a/submodule-config.c b/submodule-config.c
index 02bcaa7..9fa2269 100644
--- a/submodule-config.c
+++
This allows to configure fetching and updating in parallel
without having the command line option.
This moved the responsibility to determine how many parallel processes
to start from builtin/fetch to submodule.c as we need a way to communicate
"The user did not specify the number of parallel proc
Reroute the error message for specified but initialized submodules
to stderr instead of stdout.
Signed-off-by: Stefan Beller
Signed-off-by: Junio C Hamano
---
git-submodule.sh | 4 ++--
t/t7400-submodule-basic.sh | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a
Expose possible parallelism either via the "--jobs" CLI parameter or
the "submodule.fetchJobs" setting.
By having the variable initialized to -1, we make sure 0 can be passed
into the parallel processing machine, which will then pick as many parallel
workers as there are CPUs.
Signed-off-by: Stef
This introduces a new helper function in git submodule--helper
which takes care of cloning all submodules, which we want to
parallelize eventually.
Some tests (such as empty URL, update_mode=none) are required in the
helper to make the decision for cloning. These checks have been
moved into the C
On Thu, Feb 18, 2016 at 3:20 PM, Junio C Hamano wrote:
> Stefan Beller writes:
>
>> On Thu, Feb 18, 2016 at 3:12 PM, Stefan Beller wrote:
Unless you count "I want to write differently from what was
suggested" is a desirable thing to do, I do not see a point in
favouring the above
Stefan Beller writes:
> On Thu, Feb 18, 2016 at 3:12 PM, Stefan Beller wrote:
>>> Unless you count "I want to write differently from what was
>>> suggested" is a desirable thing to do, I do not see a point in
>>> favouring the above that uses an extra variable and skip_prefix()
>>> over what I g
Junio C Hamano writes:
>> +strbuf_reset(&sb);
>> +strbuf_addf(&sb, "submodule.%s.url", sub->name);
>> +if (git_config_get_string(sb.buf, &url)) {
>> +url = xstrdup(sub->url);
>> +if (!url)
>> +die(_("No url found for submodule path '%s' in
On Thu, Feb 18, 2016 at 3:12 PM, Stefan Beller wrote:
>> Unless you count "I want to write differently from what was
>> suggested" is a desirable thing to do, I do not see a point in
>> favouring the above that uses an extra variable and skip_prefix()
>> over what I gave you as "how about" patch.
On Thu, Feb 18, 2016 at 2:55 PM, Junio C Hamano wrote:
> Stefan Beller writes:
>
>> Thanks Junio for a review of v11!
>>
>> I addressed the memory issue with the interdiff (in patch 1/7) as follows:
>> Interdiff to v11:
>>
>> diff --git a/submodule.c b/submodule.c
>> index 263cb2a..45d0967 100644
git-p4 can be successfully used from bare repository (which acts as a
bridge between Perforce repository and pure Git repositories). On submit
git-p4 performs unconditional rebase. Do rebase only on non-bare
repositories.
---
git-p4.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
di
Stefan Beller writes:
> Thanks Junio for a review of v11!
>
> I addressed the memory issue with the interdiff (in patch 1/7) as follows:
> Interdiff to v11:
>
> diff --git a/submodule.c b/submodule.c
> index 263cb2a..45d0967 100644
> --- a/submodule.c
> +++ b/submodule.c
> @@ -219,6 +219,9 @@ voi
On Tue, Feb 16, 2016 at 05:29:42PM -0500, Jeff King wrote:
> On Tue, Feb 16, 2016 at 01:24:29PM -0800, Brian Norris wrote:
>
> > On Tue, Feb 16, 2016 at 03:45:57PM -0500, Jeff King wrote:
> > > See the section on History Simplification in git-log. But basically,
> > > when you specify a pathspec,
Michael Haggerty writes:
> Now log_ref_write_1() doesn't do anything, so inline it.
Nice.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Michael Haggerty writes:
> This function will most often be called by log_ref_write_1(), which
> wants to append to the reflog file. In that case, it is silly to close
> the file only for the caller to reopen it immediately. So, in the case
> that the file was opened, pass the open file descripto
Expose possible parallelism either via the "--jobs" CLI parameter or
the "submodule.fetchJobs" setting.
By having the variable initialized to -1, we make sure 0 can be passed
into the parallel processing machine, which will then pick as many parallel
workers as there are CPUs.
Signed-off-by: Stef
Currently submodule..update is only handled by git-submodule.sh.
C code will start to need to make use of that value as more of the
functionality of git-submodule.sh moves into library code in C.
Add the update field to 'struct submodule' and populate it so it can
be read as sm->update or from sm-
Adhere to the common coding style of Git and not check explicitly
for NULL throughout the file. There are still other occurrences in the
code base but that is usually inside of conditions with side effects.
Signed-off-by: Stefan Beller
Signed-off-by: Junio C Hamano
---
submodule-config.c | 6 ++
Just pass it along to "git submodule update", which may pick reasonable
defaults if you don't specify an explicit number.
Signed-off-by: Stefan Beller
Signed-off-by: Junio C Hamano
---
Documentation/git-clone.txt | 6 +-
builtin/clone.c | 19 +--
t/t7406-submodu
This introduces a new helper function in git submodule--helper
which takes care of cloning all submodules, which we want to
parallelize eventually.
Some tests (such as empty URL, update_mode=none) are required in the
helper to make the decision for cloning. These checks have been
moved into the C
This allows to configure fetching and updating in parallel
without having the command line option.
This moved the responsibility to determine how many parallel processes
to start from builtin/fetch to submodule.c as we need a way to communicate
"The user did not specify the number of parallel proc
Reroute the error message for specified but initialized submodules
to stderr instead of stdout.
Signed-off-by: Stefan Beller
Signed-off-by: Junio C Hamano
---
git-submodule.sh | 4 ++--
t/t7400-submodule-basic.sh | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a
Thanks Junio for a review of v11!
I addressed the memory issue with the interdiff (in patch 1/7) as follows:
Interdiff to v11:
diff --git a/submodule.c b/submodule.c
index 263cb2a..45d0967 100644
--- a/submodule.c
+++ b/submodule.c
@@ -219,6 +219,9 @@ void gitmodules_config(void)
int parse_submo
Michael Haggerty writes:
> Change log_ref_setup() to use raceproof_create_file() to create the new
> logfile. This makes it more robust against a race against another
> process that might be trying to clean up empty directories while we are
> trying to create a new logfile.
>
> This also means th
Michael Haggerty writes:
> * Don't capitalize error strings
> * Report true paths of affected files
Obvious improvements. Good.
> Signed-off-by: Michael Haggerty
> ---
> Maybe these error strings should be internationalized? If so, there
> are a bunch of similar error strings in related funct
Jeff King writes:
> On Thu, Feb 11, 2016 at 09:59:21AM -0800, Junio C Hamano wrote:
>
>> Elia Pinto writes:
>>
>> > Add the FORMATPRINTF macro for declaring the gcc function attribute
>> > 'format printf'
>> > for code style consistency with similar macro that git already use for
>> > other g
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hello,
could you please give me some recommendations how to merge two
branches in a git-svn repository, without loosing svn-properties?
As the git-svn man-page says:
> We ignore all SVN properties except svn:executable. Any unhandled
> properties ar
David Turner writes:
> On Thu, 2016-02-18 at 15:50 +0700, Duy Nguyen wrote:
>
> [snip]
>
> Thanks; applied the above
Please. Your other messages did excessively quote parts of the
message you are not responding to, but this will not tell anybody
but you what "the above" refers to, not even to D
Stefan Beller writes:
> By having the `init` functionality in C, we can reference it easier
> from other parts in the code.
>
> Signed-off-by: Stefan Beller
> ---
> builtin/submodule--helper.c | 107
>
> git-submodule.sh| 39 +--
Stefan Beller writes:
> +static int starts_with_dot_slash(const char *str)
> +{
> + return str[0] == '.' && is_dir_sep(str[1]);
> +}
> +
> +static int starts_with_dot_dot_slash(const char *str)
> +{
> + return str[0] == '.' && str[1] == '.' && is_dir_sep(str[2]);
> +}
> +
> +/*
> + * Retu
On Thu, 2016-02-18 at 15:50 +0700, Duy Nguyen wrote:
[snip]
Thanks; applied the above
> This permission makes me wonder if we need adjust_shared_perm() here
> and some other places.
So just add this after every mkdir?
if (shared_repository)
adjust_shared_perm(db_path);
Stefan Beller writes:
>> This replaces origin/sb/submodule-parallel-update
>> and is based on origin/master
>>
>> * broke out the patch for redirecting errors to stderr in "submodule update"
>> (Thanks Jonathan, Jacob)
>> * use git_config_int and manually check for less than 0.
>> (Thanks Jun
Stefan Beller writes:
> @@ -340,6 +342,16 @@ static int parse_config(const char *var, const char
> *value, void *data)
> free((void *) submodule->url);
> submodule->url = xstrdup(value);
> }
> + } else if (!strcmp(item.buf, "update"))
Stefan Beller writes:
> On Thu, Feb 18, 2016 at 12:41 AM, Lars Schneider
> wrote:
>>> Feel free to start writting an idea for
>>> http://git.github.io/SoC-2016-Ideas/. It'd be nice to have a few more
>>> ideas before Friday. We can polish them later if needed.
>>
>> I published my ideas here:
>>
On Thu, Feb 18, 2016 at 12:41 AM, Lars Schneider
wrote:
>> Feel free to start writting an idea for
>> http://git.github.io/SoC-2016-Ideas/. It'd be nice to have a few more
>> ideas before Friday. We can polish them later if needed.
>
> I published my ideas here:
> https://github.com/git/git.github
On Thu, 2016-02-18 at 13:07 +0100, Michael Haggerty wrote:
> On 02/18/2016 03:44 AM, David Turner wrote:
> > On Fri, 2016-02-12 at 16:07 +0100, Michael Haggerty wrote:
> > > On 02/05/2016 08:44 PM, David Turner wrote:
> > > > Always handle non-normal (per-worktree or pseudo) refs in the
> > > > fil
Jeff King writes:
> On Wed, Feb 17, 2016 at 02:34:08PM -0800, Junio C Hamano wrote:
>
>> * jk/tighten-alloc (2016-02-15) 18 commits
>> ...
> Please hold off a bit; I have a re-roll coming for this one.
>
>> * nd/dwim-wildcards-as-pathspecs (2016-02-10) 3 commits
>> ...
> Even if we drop it, I thi
Hello,
I am Mr. John Smith , personal assistance to the former oil and gas resources
minister. I wish to transact a business with you that will be of immense
benefits to both of us. I have a deal worth US$75 Million. Kindly contact me
for more information.
Best Regards,
John Smith, Jr
--
To un
On 02/17/2016 08:23 PM, Junio C Hamano wrote:
> Michael Haggerty writes:
>
>> The exit path for SCLD_EXISTS wasn't setting errno, as expected by at
>> least one caller. Fix the problem and document that the function sets
>> errno correctly to help avoid similar regressions in the future.
>
>> di
On Thu, Feb 18, 2016 at 3:49 AM, Junio C Hamano wrote:
> Jeff King writes:
>
>> On Wed, Feb 17, 2016 at 05:11:50PM -0500, Eric Sunshine wrote:
>>
>>> On Wed, Feb 17, 2016 at 1:06 PM, Karthik Nayak
>>> wrote:
>>> > From: Jeff King
>>> >
>>> > We don't do any post-processing on the resulting str
On 02/17/2016 09:47 PM, David Turner wrote:
> On Fri, 2016-02-12 at 16:26 +0100, Michael Haggerty wrote:
>> [...]
>> Is it worth testing re-initializing with the same --ref-storage?
>> Perhaps
>> not.
>
> Would be nice, but since we cannot guarantee that any alternate backend
> exists, we have no
On 02/18/2016 03:44 AM, David Turner wrote:
> On Fri, 2016-02-12 at 16:07 +0100, Michael Haggerty wrote:
>> On 02/05/2016 08:44 PM, David Turner wrote:
>>> Always handle non-normal (per-worktree or pseudo) refs in the files
>>> backend instead of alternate backends.
>>>
>>> Sometimes a ref transact
On 02/18/2016 01:29 AM, David Turner wrote:
> On Fri, 201-02-12 at 15:09 +0100, Michael Haggerty wrote:]
>> On 02/05/2016 08:44 PM, David Turner wrote:
>>> Before committing ref updates, split symbolic ref updates into two
>>> parts: an update to the underlying ref, and a log-only update to
>>> the
On Wed, 2016-02-17 at 13:33 -0800, Junio C Hamano wrote:
> Jeff King writes:
>
> > On Wed, Feb 17, 2016 at 09:21:20PM +0100, Matthieu Moy wrote:
> >
> > > > I am wondering if we heard from libgit2 folks if they want us
> > > > to
> > > > host them (or they want to participate in GSoC at all).
>
Caveat: I did not study how to use lmdb. I just guessed what it does
based on function names. I don't know much about refs handling either
(especially since the transaction thing is introduced)
> diff --git a/Documentation/technical/refs-lmdb-backend.txt
> b/Documentation/technical/refs-lmdb-back
On 17 Feb 2016, at 14:12, Johannes Schindelin
wrote:
> Hi Lars,
>
> On Mon, 15 Feb 2016, larsxschnei...@gmail.com wrote:
>
>> From: Lars Schneider
>>
>> Use the config type to print more detailed error messages that inform
>> the user about the origin of a config error (file, stdin, blob).
On 17 Feb 2016, at 22:31, Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> larsxschnei...@gmail.com writes:
>>
>>> From: Lars Schneider
>>>
>>> Use the config type to print more detailed error messages that inform
>>> the user about the origin of a config error (file, stdin, blob).
>>
>
On 17 Feb 2016, at 19:58, Matthieu Moy wrote:
> Lars Schneider writes:
>
>> Coincidentally I started working on similar thing already (1) and I have
>> lots of ideas around it.
>
> I guess it's time to start sharing these ideas then ;-).
>
> I think there's a lot to do. If we want to push th
66 matches
Mail list logo
