Re: [PATCH] git-send-email: treat field names as case-independent

Nickolai Zeldovich writes: > On Sun, Jan 6, 2013 at 10:27 PM, Junio C Hamano wrote: >> While I think this patch is a sensible thing to do, I at the same >> time wonder who is writing "cc:" in the lowercase in the first >> place, and if that is one of our tools, we should fix that part as >> well

Re: Moving (renaming) submodules, recipe/script

Jens Lehmann writes: > Am 07.01.2013 02:39, schrieb Jonathan Nieder: >> (just cc-ing Jens and Peter, who might be interested) > > I´m currently working on teaching mv to move submodules and intend > to send those patches to the list after finishing submodule deinit. Thanks for a heads-up. As a

Re: Version 1.8.1 does not compile on Cygwin 1.7.14

"Jason Pyeron" writes: [administrivia: please never cull CC list when you respond to a message on this list without a good reason] >> circumvent the Cygwin API (and by extension, Cygwin project goals). >> >> So, perhaps a better path forward is to disable / remove the >> above code by default.

Re: Moving (renaming) submodules, recipe/script

Am 07.01.2013 02:39, schrieb Jonathan Nieder: > (just cc-ing Jens and Peter, who might be interested) I´m currently working on teaching mv to move submodules and intend to send those patches to the list after finishing submodule deinit. Please see https://github.com/jlehmann/git-submod-enhanceme

RE: Version 1.8.1 does not compile on Cygwin 1.7.14

> -Original Message- > From: Mark Levedahl > Sent: Sunday, January 06, 2013 17:17 > > On 01/06/2013 02:54 PM, Junio C Hamano wrote: > > Jonathan Nieder writes: > > > >> Mark Levedahl wrote: > >> > >>> > However, > >>> the newer w

RE: Nike Air Max Shop

Is there a practical way to eliminate the spam here? Could vger.kernel.org use a postini (list maintainers contact me offline about this) account? -Jason -- -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=- - - - Jason

Re: [PATCH 1/4] t0024, t5000: clear variable UNZIP, use GIT_UNZIP instead

René Scharfe wrote: > InfoZIP's unzip takes default parameters from the environment variable > UNZIP. Unset it in the test library and use GIT_UNZIP for specifying > alternate versions of the unzip command instead. > > t0024 wasn't even using variable for the actual extraction. t5000 > was, but

Re: What's cooking in git.git (Jan 2013, #03; Sun, 6)

Junio C Hamano writes: > I forgot to say that tonight's 'pu' seems to break t0008 and does > not pass the self-test. I didn't try figuring out if this is the > result of some mismerge, or one (or more) of the topics are broken. An addendum. This comes from the check-ignore patch and seems to ma

recovering a corrupted git repo

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I have not had any issue until I ran a git fsck recently, which repored gzip and crc errors in some pack files. git fsck does not seem to repair the errors, only report them. I would like to try to rebuild my repository, without downloading any more

Re: git push --force to update tag

On Sun, Jan 6, 2013 at 8:23 PM, 乙酸鋰 wrote: > about git 1.8.2 > > * "git push" now requires "-f" to update a tag, even if it is a >fast-forward, as tags are meant to be fixed points. > > Does the server side validate this? Do we need to upgrade git on > server side to support this? This check

Re: [PATCH] git-send-email: treat field names as case-independent

On Sun, Jan 6, 2013 at 10:27 PM, Junio C Hamano wrote: > While I think this patch is a sensible thing to do, I at the same > time wonder who is writing "cc:" in the lowercase in the first > place, and if that is one of our tools, we should fix that part as > well. Such a header would leak out to

Nike Air Max Shop

Via Nike Air Max Facebook-Seite, sehen wir verschiedene Farbvarianten, darunter Team Gelb und Schwarz, Spiel Royal and Black, Black and Volt Versionen. Die Fotos bieten auch näher Blicke auf einige der 2013 Air Max-Funktionen, einschließlich Akzente aus r

Re: [PATCH] git-send-email: treat field names as case-independent

Nickolai Zeldovich writes: > Field names like To:, Cc:, etc should be treated as case-independent; > use a case-insensitive regexp to match them as such. Previously, > git-send-email would send email messages with a lowercase "cc:" line in > the body without actually sending a copy of the messag

Re: What's cooking in git.git (Jan 2013, #03; Sun, 6)

I forgot to say that tonight's 'pu' seems to break t0008 and does not pass the self-test. I didn't try figuring out if this is the result of some mismerge, or one (or more) of the topics are broken. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord

What's cooking in git.git (Jan 2013, #03; Sun, 6)

What's cooking in git.git (Jan 2013, #03; Sun, 6) -- Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The tip of 'next' will be rewound and rebu

git push --force to update tag

about git 1.8.2 * "git push" now requires "-f" to update a tag, even if it is a fast-forward, as tags are meant to be fixed points. Does the server side validate this? Do we need to upgrade git on server side to support this? -- To unsubscribe from this list: send the line "unsubscribe git" i

Re: [PATCH] clone: forbid --bare --separate-git-dir

Duy Nguyen writes: > On Mon, Jan 7, 2013 at 6:13 AM, Junio C Hamano wrote: >>> I don't know what would go in the blank above, >>> though. Is it possible that some people are relying on this option >>> combination? >> >> I do not necessarily think we must say "it happens not to work >> already

[PATCH] git-send-email: treat field names as case-independent

Field names like To:, Cc:, etc should be treated as case-independent; use a case-insensitive regexp to match them as such. Previously, git-send-email would send email messages with a lowercase "cc:" line in the body without actually sending a copy of the message to that address. Signed-off-by: Ni

Re: Suggested improvements to the git-p4 documentation (branch-related)

2013/1/5 Pete Wyckoff : > sh...@keba.be wrote on Thu, 03 Jan 2013 15:58 -0500: >> While struggling to get git-p4 to work properly with branches, I >> thought the documentation on http://git-scm.com/docs/git-p4 could use >> some improvements: > > Thanks, I definitely appreciate the constructive comm

Re: Moving (renaming) submodules, recipe/script

(just cc-ing Jens and Peter, who might be interested) W. Trevor King wrote: > Today I had to move my first submodule, and I discovered that Git's > support for this is pretty limited. There have been a few patch > series attempting to address this [1,2], but none of them seems to > have pushed t

Re: [PATCH] clone: forbid --bare --separate-git-dir

On Mon, Jan 7, 2013 at 6:13 AM, Junio C Hamano wrote: >> I don't know what would go in the blank above, >> though. Is it possible that some people are relying on this option >> combination? > > I do not necessarily think we must say "it happens not to work > already for such and such reasons, lu

Re: [PATCH 03/21] pathspec: make sure the prefix part is wildcard-clean

On Sun, Jan 6, 2013 at 1:20 PM, Nguyễn Thái Ngọc Duy wrote: > --- a/setup.c > +++ b/setup.c > @@ -250,6 +250,8 @@ static unsigned prefix_pathspec(struct pathspec_item > *item, > *raw = item->match; > item->len = strlen(item->match); > item->nowildcard_len = simple_length(i

Moving (renaming) submodules, recipe/script

Today I had to move my first submodule, and I discovered that Git's support for this is pretty limited. There have been a few patch series attempting to address this [1,2], but none of them seems to have pushed through into master (although I can't put my finger on a reason for why). There are al

Re: [PATCH v4] git-clean: Display more accurate delete messages

Zoltan Klinger wrote: > $ git clean -fd > Removing tracked_dir/some_untracked_file > Removing untracked_file > Removing untracked_foo/ > Removing untracked_some.git/ > > The message displayed to the user is slightly misleading. The foo/ > directory has not been removed because of foo/fro

[PATCH v4] git-clean: Display more accurate delete messages

(1) Only print out the names of the files and directories that got actually deleted. (2) Show warning message for ignored untracked git repositories Consider the following repo layout: test.git/ |-- tracked_dir/ | |-- some_tracked_file | |-- some_untracked_file |-- t

Re: [PATCH] docs: manpage XML depends on asciidoc.conf

Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes

Adam Spiers writes: > That's a valid point. However, the ary[0] part which assumes external > knowledge of the internal implementation can trivially be avoided by > squashing this patch onto the commit we are discussing: > > diff --git a/builtin/clean.c b/builtin/clean.c > index dd89737..6e21ca6

Re: [PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes

On Sun, Jan 06, 2013 at 10:53:11PM +, Adam Spiers wrote: > That's a valid point. However, the ary[0] part which assumes external > knowledge of the internal implementation can trivially be avoided by > squashing this patch onto the commit we are discussing: [snipped] > diff --git a/builtin/l

Re: [PATCH] clone: forbid --bare --separate-git-dir

Jonathan Nieder writes: > Nguyễn Thái Ngọc Duy wrote: > >> --separate-git-dir was added to clone with the repository away from >> standard position /.git. It does not make sense to use it >> without creating working directory. >> >> Signed-off-by: Nguyễn Thái Ngọc Duy > > The patch correctly imp

Re: [PATCH] git-fast-import(1): reorganise options

John Keeping writes: > On Sun, Jan 06, 2013 at 05:51:09AM -0800, Jonathan Nieder wrote: > ... >> Nice description. >> >> > While doing this, fix the duplicate '--done' documentation by taking the >> > best bits of each. Also combine the descriptions of '--relative-marks' >> > and '--no-relative

Re: [PATCH 04/10] mailmap: simplify map_user() interface

Antoine Pelisse writes: > diff --git a/builtin/blame.c b/builtin/blame.c > index dd4aff9..86450e3 100644 > --- a/builtin/blame.c > +++ b/builtin/blame.c > ... > @@ -1356,51 +1356,61 @@ static void get_ac_line(const char *inbuf, const char > *what, > len = strlen(tmp); > else

Re: [PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes

On Sun, Jan 06, 2013 at 12:25:48PM -0800, Junio C Hamano wrote: > Adam Spiers writes: > > > On Fri, Jan 04, 2013 at 01:03:59PM -0800, Junio C Hamano wrote: > >> Adam Spiers writes: > >> > >> > diff --git a/builtin/clean.c b/builtin/clean.c > >> > index 0c7b3d0..bd18b88 100644 > >> > --- a/built

Re: Version 1.8.1 does not compile on Cygwin 1.7.14

On 01/06/2013 02:54 PM, Junio C Hamano wrote: Jonathan Nieder writes: Mark Levedahl wrote: However, the newer win32api is provided only for the current cygwin release series, which can be reliably identified by having dll version 1.7.

[PATCH v2] status: always report ignored tracked directories

Tracked directories (i.e. directories containing tracked files) that are ignored must be reported as ignored if they contain untracked files. Currently, files in the index can't be reported as ignored and are automatically dropped from the list: - When core.ignorecase is false, directories (whic

Re: Version 1.8.1 does not compile on Cygwin 1.7.14

On 01/06/2013 04:35 PM, Junio C Hamano wrote: Thanks; so perhaps you can give me an OK to forge your S-o-b to the following? -- >8 -- From: Mark Levedahl Date: Sun, 6 Jan 2013 11:56:33 -0800 Subject: [PATCH] Makefile: add comment on CYGWIN_V15_WIN32API There is no documented, reliable, and fut

Re: [PATCH 2/4] t0024, t5000: use test_lazy_prereq for UNZIP

Am 06.01.2013 19:06, schrieb Matt Kraai: On Sun, Jan 06, 2013 at 06:49:00PM +0100, René Scharfe wrote: This change makes the code smaller and we can put it at the top of the script, its rightful place as setup code. Would it be better to add the setting of GIT_UNZIP and test_lazy_prereq to tes

RE: Version 1.8.1 does not compile on Cygwin 1.7.14

> -Original Message- > From: Junio C Hamano > Sent: Sunday, January 06, 2013 16:36 > > Thanks; so perhaps you can give me an OK to forge your S-o-b > to the following? I am personally fine with it, because cygwin is used by developers not production systems and I expect my developers to

Re: [PATCH 00/21] "struct pathspec" conversion

Nguyễn Thái Ngọc Duy writes: > This is another step towards the pathspec unification. This series > introduces a get_pathspec() alternative: parse_pathspec(). The new > function intializes struct pathspec directly. Many builtin commands > (except mv) are converted to use this function. As a resu

Re: Version 1.8.1 does not compile on Cygwin 1.7.14

Thanks; so perhaps you can give me an OK to forge your S-o-b to the following? -- >8 -- From: Mark Levedahl Date: Sun, 6 Jan 2013 11:56:33 -0800 Subject: [PATCH] Makefile: add comment on CYGWIN_V15_WIN32API There is no documented, reliable, and future-proof method to determine the installed w32a

Re: Version 1.8.1 does not compile on Cygwin 1.7.14

On 01/06/2013 03:51 PM, Torsten Bögershausen wrote: Hm, I haven't understood the connection between the dll (cygwin1.dll ?) which is used in runtime, and the header files which are used when compiling. Are they updated at the same time when updating from 1.7.16 to 1.7.17 ? Until I updated my cy

RE: Version 1.8.1 does not compile on Cygwin 1.7.14

> -Original Message- > From: git-ow...@vger.kernel.org > [mailto:git-ow...@vger.kernel.org] On Behalf Of Mark Levedahl > Sent: Sunday, January 06, 2013 16:10 > To: Junio C Hamano > Cc: Jonathan Nieder; Torsten Bögershausen; Stephen & Linda > Smith; Jason Pyeron; git@vger.kernel.org; Eric

Re: Version 1.8.1 does not compile on Cygwin 1.7.14

On 01/06/2013 02:54 PM, Junio C Hamano wrote: Jonathan Nieder writes: Mark Levedahl wrote: However, the newer win32api is provided only for the current cygwin release series, which can be reliably identified by having dll version 1.7.

Re: [PATCH] api-allocation-growing.txt: encourage better variable naming

Adam Spiers writes: >> Sounds good. To follow "not type but contents", a further rewrite >> with s/array/item/ is even better, no? > > I agree. Thanks for a quick response; let's do this then. -- >8 -- From: Adam Spiers The documentation for the ALLOC_GROW API implicitly encouraged developer

Re: [PATCH] api-allocation-growing.txt: encourage better variable naming

On Sun, Jan 06, 2013 at 12:29:33PM -0800, Junio C Hamano wrote: > Adam Spiers writes: > > > The documentation for the ALLOC_GROW API implicitly encouraged > > developers to use "ary" as the variable name for the array which is > > dynamically grown. However "ary" is an unusual abbreviation hardl

Re: Version 1.8.1 does not compile on Cygwin 1.7.14

On 06.01.13 20:54, Junio C Hamano wrote: > Jonathan Nieder writes: > >> Mark Levedahl wrote: >> >>> However, the newer >>> win32api is provided only for the current cygwin release series, which can >>> be reliably identified by having dll v

Re: Re: [PATCH] Remove the suggestion to use parsecvs, which is currently broken.

Heiko Voigt : > > I'm parsecvs's maintainer now. It's not in good shape; there is at > > least one other known showstopper besides the build issue. I would > > strongly prefer to direct peoples' attention away from it until I > > have time to fix it and cut a release. This is not a distant > >

Re: [PATCH] api-allocation-growing.txt: encourage better variable naming

Adam Spiers writes: > The documentation for the ALLOC_GROW API implicitly encouraged > developers to use "ary" as the variable name for the array which is > dynamically grown. However "ary" is an unusual abbreviation hardly > used anywhere else in the source tree, and it is also better to name >

Re: [PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes

Adam Spiers writes: > On Fri, Jan 04, 2013 at 01:03:59PM -0800, Junio C Hamano wrote: >> Adam Spiers writes: >> >> > diff --git a/builtin/clean.c b/builtin/clean.c >> > index 0c7b3d0..bd18b88 100644 >> > --- a/builtin/clean.c >> > +++ b/builtin/clean.c >> > @@ -97,9 +97,10 @@ int cmd_clean(int

Re: [PATCH jk/pathspec-literal] t6130-pathspec-noglob: Windows does not allow a file named "f*"

Jeff King writes: > On Sun, Jan 06, 2013 at 03:07:43PM +0100, Johannes Sixt wrote: > >> Windows disallows file names that contain a star. Arrange the test setup >> to insert the file name "f*" in the repository without the corresponding >> file in the worktree. >> [...] >> -test_commit star "

Re: Version 1.8.1 does not compile on Cygwin 1.7.14

Jonathan Nieder writes: > Mark Levedahl wrote: > >> However, the newer >> win32api is provided only for the current cygwin release series, which can >> be reliably identified by having dll version 1.7.x, while the older frozen >> releases (

Re: [PATCH v4] git-completion.bash: add support for path completion

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 05/01/2013 21:23, Marc Khouzam ha scritto: > [...] > Thanks for this, it improves the situation dramatically. > I did further testing with your patch and found some less obvious > issues. I didn't debug the script myself as I'm not that familiar wi

Re: [PATCH 2/4] t0024, t5000: use test_lazy_prereq for UNZIP

On Sun, Jan 06, 2013 at 06:49:00PM +0100, René Scharfe wrote: > This change makes the code smaller and we can put it at the top of > the script, its rightful place as setup code. Would it be better to add the setting of GIT_UNZIP and test_lazy_prereq to test-lib.sh so they aren't duplicated in bot

Re: [PATCH v4] git-completion.bash: add support for path completion

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 05/01/2013 07:27, Junio C Hamano ha scritto: > Junio C Hamano writes: > >> Marc Khouzam writes: >> >>> I've been playing with it but I'm not getting the expected >>> behavior when I cd to a sub-directory. >> >> Thanks for testing. Manlio? > >

[PATCH 4/4] t5002: check if unzip supports symlinks

Only add a symlink to the repository if both the filesystem and unzip support symlinks. To check the latter, add a ZIP file containing a symlink, created like this with InfoZIP zip 3.0: $ echo sample text >textfile $ ln -s textfile symlink $ zip -y infozip-symlinks.zip tex

[PATCH 3/4] t5000, t5002: move ZIP tests into their own script

This makes ZIP specific tweaks easier. Signed-off-by: Rene Scharfe --- t/t5000-tar-tree.sh| 69 t/t5002-archive-zip.sh | 119 + 2 files changed, 119 insertions(+), 69 deletions(-) create mode 100755 t/t5002-archiv

[PATCH 2/4] t0024, t5000: use test_lazy_prereq for UNZIP

This change makes the code smaller and we can put it at the top of the script, its rightful place as setup code. Signed-off-by: Rene Scharfe --- t/t0024-crlf-archive.sh | 12 +--- t/t5000-tar-tree.sh | 12 +--- 2 files changed, 10 insertions(+), 14 deletions(-) diff --git a/

[PATCH 1/4] t0024, t5000: clear variable UNZIP, use GIT_UNZIP instead

InfoZIP's unzip takes default parameters from the environment variable UNZIP. Unset it in the test library and use GIT_UNZIP for specifying alternate versions of the unzip command instead. t0024 wasn't even using variable for the actual extraction. t5000 was, but when setting it to InfoZIP's unz

[PATCH 0/4] ZIP test fixes

Fix a bug in two scripts that call unzip, use the opportunity for a small cleanup, move all ZIP related tests out of t5000 and finally skip testing symlinks if unzip doesn't support them. The first one allows running t5000 with the unzip from pkgsrc manually on NetBSD, which succeeds. The last on

[PATCH v4 06/11] add.c: move pathspec matchers into new pathspec.c for reuse

Extract the following functions from builtin/add.c to pathspec.c, in preparation for reuse by a new git check-ignore command: - fill_pathspec_matches() - find_used_pathspec() The functions being extracted are not changed in any way, except removal of the 'static' qualifier. Also add comments

[PATCH v4 07/11] pathspec.c: rename newly public functions for clarity

Perform the following function renames to make it explicit that these pathspec handling functions are for matching against the index, rather than against a tree or the working directory. - fill_pathspec_matches() -> add_pathspec_matches_against_index() - find_used_pathspec() -> find_pathspecs_matc

[PATCH v4 08/11] add.c: extract check_path_for_gitlink() from treat_gitlinks() for reuse

Extract the body of the for loop in treat_gitlinks() into a separate check_path_for_gitlink() function so that it can be reused elsewhere. This paves the way for a new check-ignore sub-command. Also document treat_gitlinks(). Signed-off-by: Adam Spiers --- Unlike v3, this series doesn't make tre

[PATCH v4 09/11] add.c: extract new die_if_path_beyond_symlink() for reuse

This will be reused by a new git check-ignore command. Also document validate_pathspec(). Signed-off-by: Adam Spiers --- Unlike v3, this series doesn't make validate_pathspec() public. builtin/add.c | 10 ++ pathspec.c| 12 pathspec.h| 1 + 3 files changed, 19 ins

[PATCH v4 11/11] add git-check-ignore sub-command

This works in a similar manner to git-check-attr. Thanks to Jeff King and Junio C Hamano for the idea: http://thread.gmane.org/gmane.comp.version-control.git/108671/focus=108815 Signed-off-by: Adam Spiers --- Several minor improvements since v3: - rename char *dir to slash - fix some declar

[PATCH v4 10/11] setup.c: document get_pathspec()

Since we have just created a new pathspec-handling library, now is a good time to add some comments explaining get_pathspec(). Signed-off-by: Adam Spiers --- The deprecation warning is new since v3. setup.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/setup.c b/setup

[PATCH v4 05/11] add.c: remove unused argument from validate_pathspec()

The 'argc' argument passed to validate_pathspec() was never used. Signed-off-by: Adam Spiers --- builtin/add.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/builtin/add.c b/builtin/add.c index c689f37..1f62ba3 100644 --- a/builtin/add.c +++ b/builtin/add.c @@ -197,7 +

[PATCH v4 01/11] dir.c: use a single struct exclude_list per source of excludes

Previously each exclude_list could potentially contain patterns from multiple sources. For example dir->exclude_list[EXC_FILE] would typically contain patterns from .git/info/exclude and core.excludesfile, and dir->exclude_list[EXC_DIRS] could contain patterns from multiple per-directory .gitignor

[PATCH v4 02/11] dir.c: keep track of where patterns came from

For exclude patterns read in from files, the filename is stored in the exclude list, and the originating line number is stored in the individual exclude (counting starting at 1). For exclude patterns provided on the command line, a string describing the source of the patterns is stored in the excl

[PATCH v4 03/11] dir.c: provide clear_directory() for reclaiming dir_struct memory

By the end of a directory traversal, a dir_struct instance will typically contains pointers to various data structures on the heap. clear_directory() provides a convenient way to reclaim that memory. Signed-off-by: Adam Spiers --- Documentation/technical/api-directory-listing.txt | 2 ++ dir.c

[PATCH v4 04/11] dir.c: improve docs for match_pathspec() and match_pathspec_depth()

Fix a grammatical issue in the description of these functions, and make it more obvious how and why seen[] can be reused across multiple invocations. Signed-off-by: Adam Spiers --- dir.c | 38 ++ dir.h | 6 ++ 2 files changed, 32 insertions(+), 12 deletio

[PATCH v4 00/11] new git check-ignore sub-command

This is the v4 re-roll of the check-ignore series, which is based on Junio's as/dir-c-cleanup topic branch f6198812 (dir.c: rename free_excludes() to clear_exclude_list(), 2012-12-27). As previously discussed, the earlier parts of the v3 series seem to be complete and are progressing to 'next'. S

Re: [PATCH] status: report ignored yet tracked directories

On Sun, Jan 6, 2013 at 12:03 AM, Jeff King wrote: > On Sat, Jan 05, 2013 at 09:42:43PM +0100, Antoine Pelisse wrote: > >> Tracked directories (i.e. directories containing tracked files) that >> are ignored must be reported as ignored if they contain untracked files. >> >> Currently, tracked files

Re: Re: [PATCH] Remove the suggestion to use parsecvs, which is currently broken.

Hi, On Fri, Dec 28, 2012 at 11:42:00PM -0500, Eric S. Raymond wrote: > Heiko Voigt : > > Maybe you could add that information to the parsecvs compile > > instructions? I think just because it takes some effort to compile does > > not justify to remove this useful pointer here. When I was convertin

Re: as/check-ignore (was Re: What's cooking in git.git (Jan 2013, #02; Thu, 3))

On Fri, Jan 04, 2013 at 01:13:12PM -0800, Junio C Hamano wrote: > Adam Spiers writes: > > On Thu, Jan 3, 2013 at 7:17 PM, Junio C Hamano wrote: > >> * as/check-ignore (2012-12-28) 19 commits > >> - Add git-check-ignore sub-command > >> - setup.c: document get_pathspec() > >> - pathspec.c: extr

[PATCH] api-allocation-growing.txt: encourage better variable naming

The documentation for the ALLOC_GROW API implicitly encouraged developers to use "ary" as the variable name for the array which is dynamically grown. However "ary" is an unusual abbreviation hardly used anywhere else in the source tree, and it is also better to name variables based on their conten

Re: [PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes

On Fri, Jan 04, 2013 at 11:54:34PM -0800, Junio C Hamano wrote: > Junio C Hamano writes: > > Adam Spiers writes: > > > >> diff --git a/builtin/clean.c b/builtin/clean.c > >> index 0c7b3d0..bd18b88 100644 > >> --- a/builtin/clean.c > >> +++ b/builtin/clean.c > >> @@ -97,9 +97,10 @@ int cmd_clean(i

[PATCH] archive-zip: write uncompressed size into header even with streaming

We record the uncompressed and compressed sizes and the CRC of streamed files as zero in the local header of the file. The actual values are recorded in an extra data descriptor after the file content, and in the usual ZIP directory entry at the end of the archive. While we know the compressed si

Re: [PATCH v3 11/19] dir.c: use a single struct exclude_list per source of excludes

On Fri, Jan 04, 2013 at 01:03:59PM -0800, Junio C Hamano wrote: > Adam Spiers writes: > > > diff --git a/builtin/clean.c b/builtin/clean.c > > index 0c7b3d0..bd18b88 100644 > > --- a/builtin/clean.c > > +++ b/builtin/clean.c > > @@ -97,9 +97,10 @@ int cmd_clean(int argc, const char **argv, const

Re: [PATCH jk/pathspec-literal] t6130-pathspec-noglob: Windows does not allow a file named "f*"

On Sun, Jan 06, 2013 at 03:07:43PM +0100, Johannes Sixt wrote: > Windows disallows file names that contain a star. Arrange the test setup > to insert the file name "f*" in the repository without the corresponding > file in the worktree. > [...] > - test_commit star "f*" && > + # insert fil

Re: [PATCH] git-fast-import(1): reorganise options

On Sun, Jan 06, 2013 at 05:51:09AM -0800, Jonathan Nieder wrote: > John Keeping wrote: >> I left the "Semantics of execution" options with the general options >> since I couldn't think of a sensible heading > > Neat trick. :) I took inspiration from git-pull(1), which has a few general options fo

Re: Version 1.8.1 does not compile on Cygwin 1.7.14

On Sunday, January 06, 2013 04:09:17 AM Jonathan Nieder wrote: > Mark Levedahl wrote: > > However, the > > newer > > > > win32api is provided only for the current cygwin release series

[PATCH jk/pathspec-literal] t6130-pathspec-noglob: Windows does not allow a file named "f*"

Windows disallows file names that contain a star. Arrange the test setup to insert the file name "f*" in the repository without the corresponding file in the worktree. Signed-off-by: Johannes Sixt --- t/t6130-pathspec-noglob.sh | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff -

Re: [PATCH] git-fast-import(1): reorganise options

John Keeping wrote: > How about this? Ah, our patches crossed. > I left the "Semantics of execution" options with the general options > since I couldn't think of a sensible heading Neat trick. :) [...] > -- <8 -- > The options in git-fast-import(1) are not currently arranged in a > logical ord

[PATCH/RFC] fast-import doc: split OPTIONS into subsections

The OPTIONS section of this manpage has grown long without any particular organization to ensure it remains manageable. Split into categories to make the documentation for each option easier to find. The categories: 1. Features of the input format, such as the date format and whether the fil

[PATCH] git-fast-import(1): reorganise options

On Sat, Jan 05, 2013 at 11:12:25PM -0800, Junio C Hamano wrote: > Jonathan Nieder writes: >> But in fact the current options list doesn't seem to be well organized at >> all. >> What do you think would be a logical way to group these? >> >> Features of input syntax >> >> --date-format >>

Re: [PATCH] docs: manpage XML depends on asciidoc.conf

On Sun, Jan 06, 2013 at 04:01:53AM -0800, Jonathan Nieder wrote: > When building manual pages, the source text is transformed to XML with > AsciiDoc before the man pages are generated from the XML with xmlto. > > Fix the dependencies in the Makefile so that the XML files are rebuilt > when asciido

Re: Version 1.8.1 does not compile on Cygwin 1.7.14

Mark Levedahl wrote: > However, the newer > win32api is provided only for the current cygwin release series, which can > be reliably identified by having dll version 1.7.x, while the older frozen > releases (dll versions 1.6.x from redhat, 1

[PATCH] docs: manpage XML depends on asciidoc.conf

When building manual pages, the source text is transformed to XML with AsciiDoc before the man pages are generated from the XML with xmlto. Fix the dependencies in the Makefile so that the XML files are rebuilt when asciidoc.conf changes and not just the manual pages from unchanged XML, and move t

Re: [PATCH v3 02/19] Improve documentation and comments regarding directory traversal API

On Wed, Jan 02, 2013 at 12:54:19PM +, Adam Spiers wrote: > On Tue, Jan 1, 2013 at 8:52 PM, Junio C Hamano wrote: > > Adam Spiers writes: > >> diff --git a/dir.c b/dir.c > >> index ee8e711..89e27a6 100644 > >> --- a/dir.c > >> +++ b/dir.c > >> @@ -2,6 +2,8 @@ > >> * This handles recursive fi

Re: Version 1.8.1 does not compile on Cygwin 1.7.14

On 01/06/2013 04:57 AM, Jonathan Nieder wrote: Torsten Bögershausen wrote: The short version: Cygwin versions 1.7.1 up to 1.7.16 use the same header files as cygwin 1.5 [...] I don't know if we want to improve the Makefile to enable CYGWIN_V15_WIN32API = YesPlease for cygwin versions 1.7.1 .

Re: cvsps, parsecvs, svn2git and the CVS exporter mess

On 01/05/2013 04:11 PM, Eric S. Raymond wrote: > Perhaps I was unclear. I consider the interface design error to > be not in the fact that all the blobs are written first or detached, > but rather that the implementation detail of the two separate journal > files is ever exposed. > > I understand

Re: [PATCH] clone: forbid --bare --separate-git-dir

Nguyễn Thái Ngọc Duy wrote: > --separate-git-dir was added to clone with the repository away from > standard position /.git. It does not make sense to use it > without creating working directory. > > Signed-off-by: Nguyễn Thái Ngọc Duy The patch correctly implements the above. The description l

Re: Version 1.8.1 does not compile on Cygwin 1.7.14

Torsten Bögershausen wrote: > The short version: > Cygwin versions 1.7.1 up to 1.7.16 use the same header files as cygwin 1.5 [...] > I don't know if we want to improve the Makefile to enable > CYGWIN_V15_WIN32API = YesPlease > for cygwin versions 1.7.1 .. 1.7.16 (which are outdated) Confusing

[PATCH] clone: forbid --bare --separate-git-dir

--separate-git-dir was added to clone with the repository away from standard position /.git. It does not make sense to use it without creating working directory. Signed-off-by: Nguyễn Thái Ngọc Duy --- On Sun, Jan 6, 2013 at 4:16 PM, Jonathan Nieder wrote: > Duy Nguyen wrote: > >>

Re: Version 1.8.1 does not compile on Cygwin 1.7.14

On 06.01.13 10:32, Jonathan Nieder wrote: > Hi, > > Torsten Bögershausen wrote: >>> Stephen & Linda Smith wrote: > git co 9fca6c && make all ... The make errored out as before > [...] git co 9fca6c^ && make all ... and this compiles to completion CYGWIN_NT-5.1 WIN

Re: Version 1.8.1 does not compile on Cygwin 1.7.14

Hi, Torsten Bögershausen wrote: >> Stephen & Linda Smith wrote: >>> git co 9fca6c && make all >>> ... The make errored out as before [...] >>> git co 9fca6c^ && make all >>> ... and this compiles to completion >>> >>> CYGWIN_NT-5.1 WINXPMACHINE 1.7.14(0.260/5/3) 2012-04-24 17:22 >>> i686 Cygw

Re: [PATCH] clone: support atomic operation with --separate-git-dir

Duy Nguyen wrote: > And > because junk_work_tree is not set up for --bare, I guess we still need > to fix "--bare --separate-git-dir" case, or forbid it because i'm not > sure if that case makes sense at all. Forbidding it makes sense

Re: [PATCH] SubmittingPatches: Document how to request a patch review tag

Michael Haggerty writes: > On 01/04/2013 10:47 PM, Junio C Hamano wrote: >> "Reviewed-by" is for those who are familiar with the part of the >> system being touched to say "I reviewed this patch, it looks good", >> and Michael indeed was involved in recent updates to the refs.c >> infrastructure,

Re: [PATCH] clone: support atomic operation with --separate-git-dir

On Sun, Jan 6, 2013 at 1:43 PM, Junio C Hamano wrote: > How is the file that points at the real git dir removed with this > fix, by the way? It's part of the worktree cleanup, pointed by junk_work_tree. And because junk_work_tree is not set up for --bare, I guess we still need to fix "--bare --se