-1 as well. For strange build requirements that need to inject class files,
that would still only be applied to the binary artifacts (e.g., injecting a
module-info.class file at build time rather than requiring Java 9+ to build
regardless).
On 12 May 2018 at 21:17, Dave Fisher wrote:
> Hi Pulsar
On 11 May 2018 at 19:07, Justin Mclean wrote:
> Hi,
> I think the confusion around copyrights in NOTICE files happens because
> when you bundle a 3rd party ALv2 for with a minimum NOTICE file it is
> likely that it contains a copyright line you need to copy into your NOTICE
> file. But for other
Thanks Justin and Dave,
the Jar multifunction.jar is used in the context of some unit tests. I
suspect it went in as an quick way to add the test (in this case the
functionality is indeed to take a Jar with user code and load it) and then
eventually we forgot to automate that in the Maven build.
Hi Matt,
can you expand a bit more on the issue, because I'm not 100% sure I
understand it correctly.
> -1 as well. For strange build requirements that need to inject class
files,
that would still only be applied to the binary artifacts
The code in question is testing a feature that takes Jars f
On 13 May 2018 at 12:10, Matteo Merli wrote:
> The code in question is testing a feature that takes Jars from a user and
> execute the code contained. Indeed the Jar should not be in the sources,
> though I believe the test is correct here: we need to validate the specific
> feature by dynamicall
On Sun, May 13, 2018 at 7:49 PM Matt Sicker wrote:
> By generating the binary jar from source files at test time, you'd avoid
> bundling any binary output files.
>
Correct, we are fixing that and we'll generated a new candidate release.
Thanks,
Matteo
--
Matteo Merli
Canceling this vote thread to remove pre-packaged jar used in unit tests.
Matteo
On Sat, May 12, 2018 at 7:18 PM Dave Fisher wrote:
> Hi Pulsar Devs,
>
> Thanks Justin! I know that Pulsar Functions are new.
>
> $ jar tvf
> apache-pulsar-2.0.0-rc1-incubating/pulsar-functions/utils/src/test/resou
