On 13 May 2018 at 12:10, Matteo Merli <mme...@apache.org> wrote: > The code in question is testing a feature that takes Jars from a user and > execute the code contained. Indeed the Jar should not be in the sources, > though I believe the test is correct here: we need to validate the specific > feature by dynamically loading a Jar. >
By generating the binary jar from source files at test time, you'd avoid bundling any binary output files. > > (e.g., injecting a > module-info.class file at build time rather than requiring Java 9+ to build > regardless). > > I don't see any place in the code where we are using "module-info.class" > and the project requires Java 8 and not 9. > Sorry for the confusion, that was just an example from a problem I've seen before in another project. -- Matt Sicker <boa...@gmail.com>
