Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2

2019-02-14 Thread Adrian Cole
Perfectly fine naming suggestion. thanks, Dave. "Apache Zipkin Brave (incubating) for Apache Karaf" I will put that into a pull request and suspect no-one will contest it. -A On Fri, Feb 15, 2019, 7:43 AM Dave Fisher Hi Adrian, > > (NOTE - cross posted to private lists. Take care with replies.

Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2

2019-02-14 Thread Dave Fisher
Hi Adrian, (NOTE - cross posted to private lists. Take care with replies.) Thanks for your patience regarding the branding issue I mentioned. > On Feb 14, 2019, at 4:29 AM, Adrian Cole wrote: > Finally, there was an unresolved question about branding of the repo. I > dont think we should att

Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2

2019-02-14 Thread Adrian Cole
We would really prefer us to not have to add a non standard and explicit line in the NOTICE file about "The OpenZipkin Authors" as it doesnt exist as a legal entity and even if it did, it didn't sign an SGA. We would like that to not only be a non-blocker for this release, but also subsequent ones

Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2

2019-02-14 Thread John D. Ament
On Thu, Feb 14, 2019 at 6:35 AM Justin Mclean wrote: > Hi, > > > I can follow up with the developer to fix their headers via a github > issue (if no one else gets to it before me). > > I already have raise it as an issue :-) Add to it it if you want. [1] > > > Including prior statements about NO

Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2

2019-02-14 Thread Justin Mclean
Hi, > I can follow up with the developer to fix their headers via a github issue > (if no one else gets to it before me). I already have raise it as an issue :-) Add to it it if you want. [1] > Including prior statements about NOTICE is completely optional, but in the > case of no SGA would be

Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2

2019-02-14 Thread John D. Ament
Hi all, I just want to point out that the issue is that MavenWrapperDownloader has incorrect license headers in its source repository, see [1]. We should not fault Apache projects for leveraging this, since the upstream is not properly setup. I can follow up with the developer to fix their heade

Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2

2019-02-13 Thread Adrian Cole
> > Did the Zipkin project file an SGA? If no, the contribution is all ICLA > based and you are correct. > If yes, then AFAIK Justin is correct, but there may be other edge cases. > There was no SGA. This particular codebase was also primarily authored by iCLA signers. In Zipkin, we did an odd th

Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2

2019-02-13 Thread Dave Fisher
Hi Adrian/Justin, We are discussing the wrong points. The clear question is what is MavenWrapperDownloader.java and why does it need to be in source release? It doesn’t. The Zipkin build instruction should include the installation instructions for MavenWrapper. [3] Adrian will that work for Z

Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2

2019-02-13 Thread Dave Fisher
Hi Adrian, Simple question inline. Sent from my iPhone On Feb 13, 2019, at 8:33 PM, Adrian Cole wrote: >> See [1][2] on policy and many many projects do it except those that were >> developed solely at the ASF. > In practice, you can find many, many that have stock files and were > not develo

Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2

2019-02-13 Thread Justin Mclean
Hi, > Again, this seems a site of unique enforcement with questionable > clarity as a result. You seem to want us to add a statement saying > that this code came from the Takari maven plugin and/or to investigate > their CLA process. Um no I want you to respect the license and headers of 3rd part

Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2

2019-02-13 Thread Adrian Cole
> See [1][2] on policy and many many projects do it except those that were > developed solely at the ASF. In practice, you can find many, many that have stock files and were not developed solely at the ASF. Considering our statement was "The OpenZipkin Authors", I have not seen any file at all li

Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2

2019-02-13 Thread Justin Mclean
Hi, > I've not seen any example of a project noting prior headers like this, > so I winged a pull request. Feedback welcome! See [1][2] on policy and many many projects do it except those that were developed solely at the ASF. > similar to above, I've not found any apache project special-casing

Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2

2019-02-13 Thread Adrian Cole
> Re NOTICE did you project come to the ASF in 2016? Who did it come from, and > if the headers were changed to ASF ones then they should be mentioned in > NOTICE. I've not seen any example of a project noting prior headers like this, so I winged a pull request. Feedback welcome! https://github.c

Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2

2019-02-13 Thread Adrian Cole
> The product name is a problem. > > Please explain how this release relates to Apache Karaf? We can give you > branding guidance once you do. Sure thing. Zipkin is a tracing system and Brave is the original name of the tracing libary, and the most widely used one. We currently file "Brave" under

Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2

2019-02-13 Thread Dave Fisher
The product name is a problem. Please explain how this release relates to Apache Karaf? We can give you branding guidance once you do. Regards, Dave Sent from my iPhone > On Feb 13, 2019, at 6:07 PM, Justin Mclean wrote: > > Hi, > > Sorry but it’s -1 (binding) as it contains compiled code (

Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2

2019-02-13 Thread Justin Mclean
Hi, > As recutting, revoting, and reverifying is time consuming for the > volunteers I will wait for someone else to also look at this (besides our > mentors who already have) to save our folks the frustration of 3rd go round > leading to a 4th. That’s always a good idea any other IPMC have some

Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2

2019-02-13 Thread Adrian Cole
thanks justin. I missed this part about the jar and know there are options to it. the license warnings were already resolved for the next release. On the NOTICE, the headers originally said copyright "The OpenZipkin Authors" I can put that into a pull request prior to re-cutting. As recutting, r

Re: [VOTE] Release Apache Zipkin Brave Karaf (Incubating) version 0.1.2

2019-02-13 Thread Justin Mclean
Hi, Sorry but it’s -1 (binding) as it contains compiled code (a .jar) [1], an ASF release must consist of source code only. The other issue are minor IMO and can be fixed in a future release. I checked: - incubating in name - signature and hashed correct - LICENSE is fine - NOTICE has some mino