Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-05-25 Thread Justin Mclean
Hi, +1 (binding) I checked: - incubating in name - Signatures and hashed good - DISCLAIMER exists - LICENSE is fine - NOTICE may have a minor issue (see below) - source file have ASF headers - No unexpected binary files - fails to compile from source a s I have wrong version of protobuf installed

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-05-24 Thread sebb
On 24 May 2018 at 22:40, Josh Elser wrote: > +1 (binding), but with one issue ;) > > The source release looks fine, as do sigs/xsums. DISCLAIMER, LICENSE and > NOTICE are all fine too. > > Only thing I see is that your new additions made in > https://dist.apache.org/repos/dist/dev/incubator/omid/0

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-05-24 Thread Josh Elser
+1 (binding), but with one issue ;) The source release looks fine, as do sigs/xsums. DISCLAIMER, LICENSE and NOTICE are all fine too. Only thing I see is that your new additions made in https://dist.apache.org/repos/dist/dev/incubator/omid/0.9.0.0-rc3/KEYS must be reflected in https://dist.

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-05-21 Thread James Taylor
+1 (transferring my vote over from dev list vote) On Mon, May 21, 2018 at 12:39 PM, Ohad Shacham wrote: > Hi, > > > The Apache Omid community has voted on and approved a proposal > to release Apache Omid 0.9.0.0-incubating. > > PPMC Vote Call:http://mail-archives.apache.org/mod_mbox/omid-dev/ >

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-05-11 Thread Justin Mclean
Hi, > Could you please review the notice file in OMID-44 > before I'll cook a new > release candidate? I’ve taken a look at NOTICE file now looks good. However where did those yahoo files come from? If it was from here [3] then you need to add thi

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-05-10 Thread Ohad Shacham
Thanks Justin. Could you please review the notice file in OMID-44 before I'll cook a new release candidate? Thanks, Ohad On Thu, May 10, 2018 at 2:13 AM, Justin Mclean wrote: > Hi, > > > Has the project taken YCSB notice file into account [1] an

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-05-09 Thread Justin Mclean
Hi, > Has the project taken YCSB notice file into account [1] and can you confirm > YCSB has taken MTBT notice file into account [2]. From a casual look (and I > could be mistaken) this doesn’t seem to be the case. BTW I don’t think this is a major issue and it can be fine in a later release i

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-05-09 Thread Justin Mclean
Hi, > Both MTBT and Omid took files from YCSB, therefore, I don’t understand why > we should take MTBT’s NOTICE file into account? Has the project taken YCSB notice file into account [1] and can you confirm YCSB has taken MTBT notice file into account [2]. From a casual look (and I could be mis

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-05-09 Thread Ohad Shacham
Hi, Both MTBT and Omid took files from YCSB, therefore, I don’t understand why we should take MTBT’s NOTICE file into account? Thx, Ohad On Wed, May 9, 2018 at 5:14 AM, Justin Mclean wrote: > Hi, > > > @Justin - thanks for taking the time to review. Really appreciate it. > Looks > > li

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-05-08 Thread Justin Mclean
Hi, > @Justin - thanks for taking the time to review. Really appreciate it. Looks > like there's some confusion, though. Prior to starting this vote, you > approved the change on the JIRA here[1], but now you've -1'ed the release. AFAICS this is still unanswered: Not 100% certain but I think tha

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-05-08 Thread James Taylor
@Justin - thanks for taking the time to review. Really appreciate it. Looks like there's some confusion, though. Prior to starting this vote, you approved the change on the JIRA here[1], but now you've -1'ed the release. At this point, we're trying to get clarification on OMID-44 so that when we go

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-04-13 Thread Matt Sicker
The protobuf issue I was able to fix locally by installing protobuf@2.6 (homebrew) and modifying my PATH for the build command. I still had failing tests, though. On 12 April 2018 at 19:23, Justin Mclean wrote: > Hi, > > -1 binding as NOTICE is incorrect. The NOTICE file need to be keep as > sma

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-04-12 Thread Justin Mclean
Hi, -1 binding as NOTICE is incorrect. The NOTICE file need to be keep as small as possible [1] I checked: - incubating in file name - signatures good although it would be best to sign with an apache.org email address - LICENSE is fine - NOTICE file contains wrong year (2016) and incorrectly li

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-04-12 Thread Alan Gates
Forwarding my +1 from the dev list. Alan. On Thu, Apr 12, 2018 at 9:52 AM, Matt Sicker wrote: > * Signatures ok > * Disclaimer, license, notice ok > * Rat check ok > > I am, however, getting a test failure: > > Failed tests: > > TestTSOClientConnectionToTSO.testSuccessOfTSOClientReconnec > tion

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-04-12 Thread Matt Sicker
* Signatures ok * Disclaimer, license, notice ok * Rat check ok I am, however, getting a test failure: Failed tests: TestTSOClientConnectionToTSO.testSuccessOfTSOClientReconnectionsToARestartedTSOWithZKPublishing:214 » Execution TestTSOClientConnectionToTSO.testSuccessfulConnectionToTSOThrough

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-03-23 Thread Justin Mclean
Hi, -1 binding as NOTICE is incorrect. This normally would be is a minor thing but you have been previously asked to fix this. [1] Also unable to build from source please include instruction on how to build from source in the releasee. I checked: - incubating in name - signatures and hashed go

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-03-23 Thread Matt Sicker
* Rat check ok * Signatures ok I'm having issues building from source. I fixed on issue involving protoc by installing version 2.5 (as used in the travis config) and adding it to my PATH for the build. However, I came across another error: [ERROR] Failed to execute goal org.apache.maven.plugins:

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-03-23 Thread James Taylor
Forwarding my +1 from the dev list. James On Thu, Mar 22, 2018 at 8:31 AM Henk P. Penning wrote: > On Thu, 22 Mar 2018, Ohad Shacham wrote: > > > Date: Thu, 22 Mar 2018 13:29:55 +0100 > > From: Ohad Shacham > > To: general@incubator.apache.org > > Subject: [VOTE] Release Apache Omid 0.9.0.

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-03-22 Thread Henk P. Penning
On Thu, 22 Mar 2018, Ohad Shacham wrote: Date: Thu, 22 Mar 2018 13:29:55 +0100 From: Ohad Shacham To: general@incubator.apache.org Subject: [VOTE] Release Apache Omid 0.9.0.0 (incubating) Hi, The Apache Omid community has voted on and approved a proposal to release Apache Omid 0.9.0.0-incuba

Re: [VOTE] Release Apache Omid 0.9.0.0 (incubating)

2018-03-22 Thread Alan Gates
Forwarding my +1 from the dev list. Alan. On Thu, Mar 22, 2018 at 5:29 AM, Ohad Shacham wrote: > Hi, > > > The Apache Omid community has voted on and approved a proposal > to release Apache Omid 0.9.0.0-incubating. > > PPMC Vote Call:http://mail-archives.apache.org/mod_mbox/incubator- > omid-de