Hi,

> Could you please review the notice file in OMID-44
> <https://issues.apache.org/jira/browse/OMID-44> before I'll cook a new
> release candidate?


I’ve taken a look at NOTICE file now looks good. However where did those yahoo 
files come from? If it was from here [3] then you need to add this:
This product includes software developed by
Yahoo! Inc. (www.yahoo.com)
Copyright (c) 2010 Yahoo! Inc.  All rights reserved.

to the notice file as that is in the projects NOTICE file. [4]

You may also want to add the license for [1] (and other files) to LICENSE. It’s 
not required but a good idea to do so. [2]

Thanks,
Jutsin

1. 
https://github.com/apache/incubator-omid/blob/0c371361781957c96b20295290a167f7be3b33e2/benchmarks/src/main/java/org/apache/omid/benchmarks/utils/Generator.java
 
2. http://www.apache.org/dev/licensing-howto.html#alv2-dep
3. https://github.com/mdhim/ycsb
4. https://github.com/mdhim/ycsb/blob/master/NOTICE.txt
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Reply via email to