Re: [VOTE] Apache Ignite 1.2.0 release (RC2)

2015-06-27 Thread Justin Mclean
Hi, Changing my vote to +0 (binding). Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Apache Ignite 1.2.0 release (RC2)

2015-06-27 Thread Roman Shaposhnik
On Thu, Jun 25, 2015 at 5:08 AM, Branko Čibej wrote: > On 24.06.2015 08:34, Dmitriy Setrakyan wrote: >> On Tue, Jun 23, 2015 at 8:26 AM, Justin Mclean >> wrote: >> >>> Hi, >>> Moreover, modules under extdata are test only and are not used anywhere >>> in the project. They are used to te

Re: [VOTE] Apache Ignite 1.2.0 release (RC2)

2015-06-25 Thread Branko Čibej
On 24.06.2015 08:34, Dmitriy Setrakyan wrote: > On Tue, Jun 23, 2015 at 8:26 AM, Justin Mclean > wrote: > >> Hi, >> >>> Moreover, modules under extdata are test only and are not used anywhere >> in >>> the project. They are used to test code deployment functionality. >> Perhaps it would be best to

Re: [VOTE] Apache Ignite 1.2.0 release (RC2)

2015-06-23 Thread Dmitriy Setrakyan
On Tue, Jun 23, 2015 at 8:26 AM, Justin Mclean wrote: > Hi, > > > Moreover, modules under extdata are test only and are not used anywhere > in > > the project. They are used to test code deployment functionality. > > Perhaps it would be best to make it clearer that they are used for test > data o

Re: [VOTE] Apache Ignite 1.2.0 release (RC2)

2015-06-23 Thread Justin Mclean
Hi, > I think the real problem is that many projects actually have different > binaries in their release which are needed for the project > (not only test data), and looking at our TLP projects nobody complains. In general most binary files are not an issue but jars, wars or other compiled files

Re: [VOTE] Apache Ignite 1.2.0 release (RC2)

2015-06-23 Thread Justin Mclean
Hi, > There's nothing wrong with having binary files in a source release, and > some just can't be generated. There’s no issue with .png, .gif, or .jog or the like that’s true, but in this case the files in question are the equivalent of a war file i.e. compiled code. Thanks, Justin ---

Re: [VOTE] Apache Ignite 1.2.0 release (RC2)

2015-06-23 Thread jan i
On 23 June 2015 at 21:17, Branko Čibej wrote: > On 23.06.2015 21:14, Branko Čibej wrote: > > The fact that a file is binary, no matter what it's used for, can't be > > reason for holding back a release. > > Let me amend that: "as long as it doesn't affect the functionality of > the product in any

Re: [VOTE] Apache Ignite 1.2.0 release (RC2)

2015-06-23 Thread Branko Čibej
On 23.06.2015 21:14, Branko Čibej wrote: > The fact that a file is binary, no matter what it's used for, can't be > reason for holding back a release. Let me amend that: "as long as it doesn't affect the functionality of the product in any way". -- Brane -

Re: [VOTE] Apache Ignite 1.2.0 release (RC2)

2015-06-23 Thread Branko Čibej
On 23.06.2015 17:26, Justin Mclean wrote: > Hi, > >> Moreover, modules under extdata are test only and are not used anywhere in >> the project. They are used to test code deployment functionality. > Perhaps it would be best to make it clearer that they are used for test data > or better still gene

Re: [VOTE] Apache Ignite 1.2.0 release (RC2)

2015-06-23 Thread Justin Mclean
Hi, > Moreover, modules under extdata are test only and are not used anywhere in > the project. They are used to test code deployment functionality. Perhaps it would be best to make it clearer that they are used for test data or better still generate them. Can the files be generated from source?

Re: [VOTE] Apache Ignite 1.2.0 release (RC2)

2015-06-23 Thread Yakov Zhdanov
Justin, You are right on binaries, however these 4 binaries are test only. Moreover, modules under extdata are test only and are not used anywhere in the project. They are used to test code deployment functionality. I agree that they should not be included in the source release, but the previous

Re: [VOTE] Apache Ignite 1.2.0 release (RC2)

2015-06-22 Thread Justin Mclean
Hi, Sorry -1 binding due to binary files in the source release. Will change my vote if there's a good reason for this or if I’m mistaken. I checked: - release contains incubating - DISCLAIMER exists - LICENSE and NOTICE good - Possible unexpected binary (see below) - All source files have Apache