Re: [IP CLEARANCE] Radii8 for Apache Flex (2nd pass)

2014-08-26 Thread jan i
On 25 August 2014 23:29, Alex Harui wrote: > I have received more information from the grantor and updated the review > package. > > http://incubator.apache.org/ip-clearance/flex-radii8.html > > The review URL is the same. I removed the old zip of sources and replaced > it with the updated packa

Re: [IP CLEARANCE] Radii8 for Apache Flex

2014-08-22 Thread Justin Mclean
Hi, > It would not be wise to require public scrubbing, and nothing speaks > against informing the grantor what needs to done, and let the grantor do a > scrubbed release. And nothing speaks against involving the PMC in the process on it's private list, IMO that should be encouraged. It would be

Re: [IP CLEARANCE] Radii8 for Apache Flex

2014-08-22 Thread Justin Mclean
Hi 2) Regarding icons. The icons in question are common and trivial (">" and ">>" for 'more' and 'lots more', down arrow, etc). Give that the origin of the original icons are unknown and presumedly the non blacked out icons in question came from the same place (although that is also

Re: [IP CLEARANCE] Radii8 for Apache Flex

2014-08-22 Thread jan i
On 22 August 2014 22:16, Alex Harui wrote: > > > On 8/22/14 12:59 PM, "jan i" wrote: > > > >In my opinion you did the right thing, but I could not find the process > >you > >ran through documented. > > > >I would have liked to see a txt file, documenting > >1) that you changed the files, of cour

Re: [IP CLEARANCE] Radii8 for Apache Flex

2014-08-22 Thread Alex Harui
On 8/22/14 12:59 PM, "jan i" wrote: > >In my opinion you did the right thing, but I could not find the process >you >ran through documented. > >I would have liked to see a txt file, documenting >1) that you changed the files, of course with permission >2) which files you removed. > >Having done

Re: [IP CLEARANCE] Radii8 for Apache Flex

2014-08-22 Thread jan i
On 22 August 2014 19:46, Alex Harui wrote: > Good questions, I have asked the grantor about that one source file. > Maybe incubator folks with more experience can help answer these questions. > I am no an Incubator IP-clearance specialist, but I give my input based on my industrial experience.

Re: [IP CLEARANCE] Radii8 for Apache Flex

2014-08-22 Thread jan i
On 22 August 2014 05:43, Justin Mclean wrote: > Hi, > > Mostly good but -1 (binding) as it still needs a little more clean up > -1 (binding), but I hope the project can fast solve the minor issues mentioned. The code granted seems well written and quite interesting. > > First off the code in bu

Re: [IP CLEARANCE] Radii8 for Apache Flex

2014-08-22 Thread Alex Harui
Good questions, I have asked the grantor about that one source file. Maybe incubator folks with more experience can help answer these questions. 1) Regarding the package matching the grant. The code base granted was not going to pass IP clearance. It needed headers and a proper LICENSE and NOTIC

Re: [IP CLEARANCE] Radii8 for Apache Flex

2014-08-21 Thread Justin Mclean
Hi, Mostly good but -1 (binding) as it still needs a little more clean up First off the code in bundle for IP clearance doesn't match what is recorded in the grant. The grant specifies this [1]. Not sure if this is a major issue or not but I expected them to be the same. While the Github repo