[RESULT][VOTE] Release Apache Seata (incubating) 2.3.0-RC4

2025-03-17 Thread yixia
Hello Everyone, The vote to release Apache Seata(incubating) 2.3.0-RC4 has passed with 3 +1 votes. votes: - PJ Fanning (binding) - Xin Wang (binding) - Huxing Zhang Vote thread: https://lists.apache.org/thread/npzv0jbgm54jls7fd8jwy0l9zl8ky5ls Thanks everyone for your vote. I will finalize

Re: [VOTE] Release Apache Seata (Incubating) 2.3.0-RC4

2025-03-16 Thread Xin Wang
+1 binding (xinwang IMPC) [x] Download links are valid. [x] Checksums and signatures. [x] LICENSE/NOTICE files exist [x] No unexpected binary files [x] All source files have ASF headers [x] Can compile from source On Thu, Mar 13, 2025 at 10:15 PM Huxing Zhang wrote: > +1 approve > > Checklist

Re: [VOTE] Release Apache Seata (Incubating) 2.3.0-RC4

2025-03-13 Thread Huxing Zhang
+1 approve Checklist for reference: [x] Download links are valid. [x] Checksums and signatures. [x] LICENSE/NOTICE files exist [x] No unexpected binary files [x] All source files have ASF headers [x] Can compile from source Minor issues: when I am building from source code on my m1 Macbook, there

Re: [VOTE] Release Apache Seata (Incubating) 2.3.0-RC4

2025-03-11 Thread PJ Fanning
https://github.com/apache/incubator-seata/blob/151ea4f6757fab260ea21227ab793e0cdeee2d92/server/src/main/java/org/apache/seata/server/logging/logback/ExtendedWhitespaceThrowableProxyConverter.java#L28 This file has an invalid source header. Since the source file was copied from spring-boot, it sho

Re: [VOTE] Release Apache Seata (Incubating) 2.3.0-RC4

2025-03-11 Thread PJ Fanning
+1 binding (fanningpj IPMC) * Download links are valid. * Incubating in name * Checksums and signatures. * LICENSE/NOTICE/DISCLAIMER files exist * No unexpected binary files * Source files have ASF headers * Can compile from source On 2025/03/11 12:56:51 Min Ji wrote: > Hi PJ, > > Thanks for y

[VOTE] Release Apache Seata (Incubating) 2.3.0-RC4

2025-03-11 Thread yixia
Hello, This is a call for vote to release Apache Seata(incubating) 2.3.0-RC4. The vote thread: https://lists.apache.org/thread/gfvr1rjh9zgfpbbcow0bmbqpg8ngq9wk Vote Result: https://lists.apache.org/thread/yc16ch0s99yfvhb7xvvw6d0gmjdh0r1j The release candidates: https://dist.apache.org/rep

Re: [VOTE] Release Apache Seata (Incubating) 2.3.0-RC4

2025-03-11 Thread Min Ji
Hi PJ, Thanks for your careful review. As you've seen, these files were indeed copied from a third party, and we've mentioned that in the comments.The related code is mainly about extracting properties from JavaScript objects and a couple of lines for concatenating log format strings.Given the sim

Re: [VOTE] Release Apache Seata (Incubating) 2.3.0-RC4

2025-03-11 Thread PJ Fanning
This is a vote on the tar.gz that you supplied. I cannot find the license change in apache-seata-2.3.0-incubating-src.tar.gz that relates to ExtendedWhitespaceThrowableProxyConverter. On Tue, 11 Mar 2025 at 07:08, Min Ji wrote: > > Hi PJ, > > PJ Fanning 于2025年3月11日周二 03:00写道: > > > > https://git

Re: [VOTE] Release Apache Seata (Incubating) 2.3.0-RC4

2025-03-11 Thread PJ Fanning
Ok. I have the commit now. https://github.com/apache/incubator-seata/commit/d2f3554a656aa84ae423cf6cf84aa214fc8c#diff-724497593d9df5966fe458e68a556e9c715fc69dce406b93acf7b3858d020976 This seems like a minor rewrite that does exactly the same thing. Since the code is simple enough, I guess it

Re: [VOTE] Release Apache Seata (Incubating) 2.3.0-RC4

2025-03-10 Thread Min Ji
Hi PJ, PJ Fanning 于2025年3月11日周二 03:00写道: > > https://github.com/apache/incubator-seata/blob/151ea4f6757fab260ea21227ab793e0cdeee2d92/server/src/main/java/org/apache/seata/server/logging/logback/ExtendedWhitespaceThrowableProxyConverter.java#L28 > > This file has an invalid source header. Since th