Hi PJ, Thanks for your careful review. As you've seen, these files were indeed copied from a third party, and we've mentioned that in the comments.The related code is mainly about extracting properties from JavaScript objects and a couple of lines for concatenating log format strings.Given the simplicity and general nature of the code, along with future maintenance considerations, we decided to refactor these parts instead of adding them to the license.
Warm regards, Ji Min PJ Fanning <fannin...@gmail.com> 于2025年3月11日周二 17:56写道： > > Ok. I have the commit now. > > https://github.com/apache/incubator-seata/commit/d2f3554a656aa84ae423cf6cf84aa214fc8ceeee#diff-724497593d9df5966fe458e68a556e9c715fc69dce406b93acf7b3858d020976 > > This seems like a minor rewrite that does exactly the same thing. > Since the code is simple enough, I guess it is hard to completely > rewrite it. > > I will retract my -1. > > > On Tue, 11 Mar 2025 at 10:49, PJ Fanning <fannin...@gmail.com> wrote: > > > > This is a vote on the tar.gz that you supplied. I cannot find the > > license change in apache-seata-2.3.0-incubating-src.tar.gz that > > relates to ExtendedWhitespaceThrowableProxyConverter. > > > > On Tue, 11 Mar 2025 at 07:08, Min Ji <ji...@apache.org> wrote: > > > > > > Hi PJ, > > > > > > PJ Fanning <fannin...@apache.org> 于2025年3月11日周二 03:00写道： > > > > > > > > https://github.com/apache/incubator-seata/blob/151ea4f6757fab260ea21227ab793e0cdeee2d92/server/src/main/java/org/apache/seata/server/logging/logback/ExtendedWhitespaceThrowableProxyConverter.java#L28 > > > > > > > > This file has an invalid source header. Since the source file was > > > > copied from spring-boot, it should retain the header from the > > > > spring-boot file. > > > > > > > > The key thing missing is the copyright. > > > > > > > > https://github.com/spring-projects/spring-boot/blob/b6bccc13789224e80328057506c31b9d2dee9026/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/logging/logback/ExtendedWhitespaceThrowableProxyConverter.java#L2 > > > > > > > > -1 (binding) because the LICENSE change was not made to mention > > > > ExtendedWhitespaceThrowableProxyConverter and the fact that it comes > > > > from spring-boot. > > > > > > Jean-Baptiste already pointed out this issue during the 2.3.0-RC3 > > > voting process [1]. As a result, we canceled the RC3 vote, refactored > > > the relevant code, and initiated the 2.3.0-RC4 voting thread. The > > > files that were flagged have been updated in the new commit. So, I > > > think we should check using the commit ID > > > `0ad2847465fa877a2c65ea84ed43f5b0984c3ce9` mentioned in the voting > > > email. I've verified that the source code on GitHub and what's > > > submitted to SVN has been updated [2][3]. > > > > > > [1]. https://lists.apache.org/thread/wbq6jsykj2cd9nn91ys1b8r99bfl1h2r > > > [2]. > > > https://github.com/apache/incubator-seata/tree/0ad2847465fa877a2c65ea84ed43f5b0984c3ce9/server/src/main/java/org/apache/seata/server/logging/logback > > > [3]. > > > https://dist.apache.org/repos/dist/dev/incubator/seata/incubator-seata/2.3.0-RC4/apache-seata-2.3.0-incubating-src.tar.gz > > > > > > > > > > > > > > On 2025/03/10 06:18:52 yixia wrote: > > > > > Hello, > > > > > > > > > > This is a call for vote to release Apache Seata(incubating) 2.3.0-RC4. > > > > > > > > > > > > > > > The vote thread: > > > > > > > > > > https://lists.apache.org/thread/gfvr1rjh9zgfpbbcow0bmbqpg8ngq9wk > > > > > > > > > > > > > > > Vote Result: > > > > > > > > > > https://lists.apache.org/thread/yc16ch0s99yfvhb7xvvw6d0gmjdh0r1j > > > > > > > > > > > > > > > The release candidates: > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/seata/incubator-seata/2.3.0-RC4/ > > > > > > > > > > > > > > > The staging repo: > > > > > > > > > > https://repository.apache.org/content/repositories/orgapacheseata-1137/ > > > > > > > > > > > > > > > Git tag for the release: > > > > > > > > > > https://github.com/apache/incubator-seata/releases/tag/v2.3.0 > > > > > > > > > > > > > > > Git commit id for the release: > > > > > > > > > > https://github.com/apache/incubator-seata/commit/0ad2847465fa877a2c65ea84ed43f5b0984c3ce9 > > > > > > > > > > > > > > > Release Notes: > > > > > > > > > > https://github.com/apache/incubator-seata/releases/tag/v2.3.0 > > > > > > > > > > > > > > > The artifacts have been signed with Key [ 7ACD1A52F5AEF76A ], > > > > > corresponding > > > > > to[ yi...@apache.org ] > > > > > > > > > > which can be found in the keys file: > > > > > > > > > > https://downloads.apache.org/incubator/seata/KEYS > > > > > > > > > > > > > > > Build Environment: JDK 8+, Apache Maven 3.6.0+. > > > > > > > > > > - > > > > > > > > > > osx_aarch64： ./mvnw clean package -DskipTests=true -Parrch64 > > > > > - > > > > > > > > > > osx-x86_64/other: ./mvnw clean package -DskipTests=true > > > > > > > > > > > > > > > CI Test Workflow: > > > > > > > > > > https://github.com/apache/incubator-seata/actions/runs/13435379453/job/37579216082 > > > > > > > > > > > > > > > The vote will be open for at least 72 hours. > > > > > > > > > > Please vote accordingly: > > > > > > > > > > [ ] +1 approve > > > > > > > > > > [ ] +0 no opinion > > > > > > > > > > [ ] -1 disapprove with the reason > > > > > > > > > > > > > > > Checklist for reference: > > > > > > > > > > [ ] Download links are valid. > > > > > > > > > > [ ] Checksums and signatures. > > > > > > > > > > [ ] LICENSE/NOTICE files exist > > > > > > > > > > [ ] No unexpected binary files > > > > > > > > > > [ ] All source files have ASF headers > > > > > > > > > > [ ] Can compile from source > > > > > > > > > > > > > > > To learn more about Apache Seata , please see > > > > > https://seata.apache.org/ > > > > > > > > > > > > > > > Warm regards, > > > > > > > > > > Te Wang > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
