Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC2

2017-04-24 Thread Niclas Hedhman
On Sun, Apr 23, 2017 at 7:26 PM, John D. Ament wrote: > Sure - but there's still issues with it. And you still need a NOTICE file > in your source distribution. > True. But it would be a single "from Apache..." note, as we are not bundling anything else. > I thought about your points a bit mo

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC2

2017-04-23 Thread sospartan
john, I'll take the work and make NOTICE and LICENSE(s) right. Thanks for this discussion, which will be a good lesson for our newbies. The full-licensed file(SimpleWeexActivity.java) is in old branch, we have fix that in dev. I'll push to master after we have our first RC. On Sun, Apr 23, 20

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC2

2017-04-23 Thread John D. Ament
On Sat, Apr 22, 2017 at 9:43 PM Niclas Hedhman wrote: > John, > thanks for pointing me to the issue. I argue against Marvin on it, based on > "this is a tool" that is made conveniently available for those who are not > paranoid. > > NOTICE; Ok, let's rename the file. > NOTICES-POSSIBLY-NEEDED-FOR

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC2

2017-04-22 Thread Niclas Hedhman
John, thanks for pointing me to the issue. I argue against Marvin on it, based on "this is a tool" that is made conveniently available for those who are not paranoid. NOTICE; Ok, let's rename the file. NOTICES-POSSIBLY-NEEDED-FOR-BINARY-DISTRIBUTION Ok? On Sun, Apr 23, 2017 at 8:01 AM, John D.

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC2

2017-04-22 Thread John D. Ament
On Sat, Apr 22, 2017 at 7:57 AM Niclas Hedhman wrote: > On Sat, Apr 22, 2017 at 7:25 PM, John D. Ament > wrote: > > > > On Sat, Apr 22, 2017 at 6:41 AM Niclas Hedhman > wrote: > > > > > Note on gradle-wrapper.jar, > > > Agreed, and this is mostly my argument as well. However, in *nix the JAR >

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC2

2017-04-22 Thread Niclas Hedhman
On Sat, Apr 22, 2017 at 7:25 PM, John D. Ament wrote: > > On Sat, Apr 22, 2017 at 6:41 AM Niclas Hedhman wrote: > > > Note on gradle-wrapper.jar, > Agreed, and this is mostly my argument as well. However, in *nix the JAR > will get downloaded automatically if not present. On windows, you need

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC2

2017-04-22 Thread John D. Ament
On Sat, Apr 22, 2017 at 6:41 AM Niclas Hedhman wrote: > Note on gradle-wrapper.jar, > For source releases, we expect the project to be buildable by the user. The > Gradle wrapper is the easiest way to make that happen. It (together with > the gradlew and gradlew.bat scripts) ensures that that the

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC2

2017-04-22 Thread Daniel Dekany
Saturday, April 22, 2017, 12:41:23 PM, Niclas Hedhman wrote: > Note on gradle-wrapper.jar, > For source releases, we expect the project to be buildable by the user. The > Gradle wrapper is the easiest way to make that happen. It (together with > the gradlew and gradlew.bat scripts) ensures that th

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC2

2017-04-22 Thread Niclas Hedhman
Note on gradle-wrapper.jar, For source releases, we expect the project to be buildable by the user. The Gradle wrapper is the easiest way to make that happen. It (together with the gradlew and gradlew.bat scripts) ensures that that the build will be the same, and not suffer from different Gradle ve

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC2

2017-04-22 Thread John D. Ament
Sorry but -1 due to misnamed package and binary content. - No "incubating" / "incubator" in package name - JAR files are present in the source release (gradle-wrapper.jar) - Ideally the expanded package would include "apache" in the folder, not a big deal. - DISCLAIMER present Your NOTICE seems w

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC2

2017-04-20 Thread Niclas Hedhman
+1 binding On Thu, Apr 20, 2017 at 4:10 PM, sospartan wrote: > Hi all, > I'll calling a vote for Weex-incubating 0.12.0-RC2 release. > > The PPMC vote for this release has passed: > https://lists.apache.org/thread.html/d544a60a4038f9d053f7ea1eca0d16 > 2b9aef392551a02a0401041e8f@%3Cdev.weex.apach

[VOTE]: Apache Weex-incubating Release 0.12.0-RC2

2017-04-20 Thread sospartan
Hi all, I'll calling a vote for Weex-incubating 0.12.0-RC2 release. The PPMC vote for this release has passed: https://lists.apache.org/thread.html/d544a60a4038f9d053f7ea1eca0d162b9aef392551a02a0401041e8f@%3Cdev.weex.apache.org%3E The tag to be voted upon: https://git-wip-us.apache.org/repos/asf?